[esb-issues] [JBoss JIRA] Closed: (JBESB-2905) FtpImpl timeout global and not always respected
[
https://jira.jboss.org/browse/JBESB-2905?page=com.atlassian.jira.plugin.s...
]
David Ward closed JBESB-2905.
-----------------------------
Resolution: Done
1. Regarding constructors: The unused one was removed, the one only used by a subclass was
made protected, and the one only used by a test case was made package-protected.
2. Regarding the timeout in the constructor: This is now okay given the change in #1
above. Timeouts (plural: see #5) are always respected by the ESB.
3. Regarding "inifinite" - it has been left as 0 ("infinite") so as
not to change established behavior, however...
4. The timeout properties (plural: see #5) are now in the default jbossesb-properties.xml
with descriptions so people know they exist, and understand what they mean.
5. There are now 4 timeout properties available. Please refer to JBESB-3177 for more
information.
Committed on trunk, revision 33380.
FtpImpl timeout global and not always respected
-----------------------------------------------
Key: JBESB-2905
URL: https://jira.jboss.org/browse/JBESB-2905
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.5, 4.6
Reporter: Tom Eicher
Assignee: David Ward
Fix For: 4.9
org.jboss.internal.soa.esb.util.FtpImpl does look for a property
org.jboss.soa.esb.ftp.timeout in jbossesb.sar/jbossesb-properties.xml, however:
it does so only in 1 out of 3 constructors! ;-)
code "String timeout = ModulePropertyManager..." should be moved from the
"public FtpImpl (FTPEpr p_oP)"
to the "protected void initialize (boolean bConnect)".
other parameters in the 3 constructor should also be checked if they are respected in all
three cases.
Also:
- "infinite" is not so good a default, as the thread will hang forever in case
of firewall issues (I have one 48hrs old now ;-)
even a ridiculous long one like 6hrs woule be better...("_timeout = 0;" in 2
places)
- please add "<property name="org.jboss.soa.esb.ftp.timeout"
value="60000"/>" to the default jbossesb-properties.xml
so that people may know that this setting exists
- please also allow configuration of timeout from ConfigTree (method
"checkParams()" and Constant in "RemoteFileSystem")
and from FileEpr. (and then add to doc ;-)
Cheers & kind regards,
Tom.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira