[esb-issues] [JBoss JIRA] Commented: (JBESB-2466) SecureFtpImpl is missing logging and is silently hiding exceptions
[
https://jira.jboss.org/jira/browse/JBESB-2466?page=com.atlassian.jira.plu...
]
Tom Eicher commented on JBESB-2466:
-----------------------------------
if the contract is "missing files return null", then it would be mostly cool to
document this as a "@return" javadoc.
nonody (expect people who've had this before) would expect null for an empty
directory, but rather String[0]...
SecureFtpImpl is missing logging and is silently hiding exceptions
------------------------------------------------------------------
Key: JBESB-2466
URL: https://jira.jboss.org/jira/browse/JBESB-2466
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Rosetta, Transports
Affects Versions: 4.4 CP2
Reporter: Martin Vecera
Assignee: Kevin Conner
Priority: Minor
Fix For: 4.4 CP3
We experienced a difficulty with SFTP gateway which did not read any files. No
information was present in server log. Due to the following block of code, we were not
able to find out, that the server has wrong configuration of it's root path and thus
not able to access the files.
catch (SftpException ex)
{
if (ex.id == ChannelSftp.SSH_FX_NO_SUCH_FILE)
{
return null ; <-- this is the problem
}
throw new RemoteFileSystemException(ex);
}
At least DEBUG level log information would be highly appreciated. All in all, I don't
like that the class uses logging only at 3 places.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira