[esb-issues] [JBoss JIRA] (JBESB-3722) ActionProcessingPipeline incorrectly uses LOGGER.debug() instead of LOGGER.error() for exceptions
[
https://issues.jboss.org/browse/JBESB-3722?page=com.atlassian.jira.plugin...
]
Ryan LaMothe updated JBESB-3722:
--------------------------------
Description:
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
{code}
Suggested fix:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
{code}
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with
debugging.
was:
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
Suggested fix:
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with
debugging.
ActionProcessingPipeline incorrectly uses LOGGER.debug() instead of
LOGGER.error() for exceptions
-------------------------------------------------------------------------------------------------
Key: JBESB-3722
URL: https://issues.jboss.org/browse/JBESB-3722
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.8, 4.9, 4.10
Reporter: Ryan LaMothe
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
{code}
Suggested fix:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
{code}
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with debugging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira