3:21 p.m.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Mark Little
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 p.m.
New subject: [JBoss JIRA] Work started: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=all ]
Work on JBESB-678 started by Kurt Stam.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 p.m.
New subject: [JBoss JIRA] Updated: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=all ]
Kurt Stam updated JBESB-678:
----------------------------
Assignee: Kurt Stam (was: Mark Little)
Well the second time around it obtains a fresh update from the registry. This is part of
the fail-over, load-balancing work I did. I'm currently working on redelivery
functionality, which is will take care of actual retries which are configurable. So let me
take this one.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
New subject: [JBoss JIRA] Commented: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=comments#action_12368783 ]
Mark Little commented on JBESB-678:
-----------------------------------
Sure, but if 2 is better than 1, then surely 3 is better than 2 ;-) Basically: why 2 and
not some configurable option?
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
New subject: [JBoss JIRA] Commented: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=comments#action_12368787 ]
Kurt Stam commented on JBESB-678:
---------------------------------
Only 2 makes sense. Under normal processing, bad (cached) EPRs are thrown out. However,
the problem with that is that over time you may have no EPRs left. At that point you want
to retry one more time to obtain a fresh set of EPRs from the registry. If things still
fail after that, then we should persist to the messageStore and try for redelivery at a
later time. The number of retries for that and the interval between retries should be
configurable.
Like I said, this is what I'm working on and it will have more comments and make more
sense when that work is complete.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 p.m.
New subject: [JBoss JIRA] Commented: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=comments#action_12368791 ]
Mark Little commented on JBESB-678:
-----------------------------------
But that's precisely what I mean. We're going to the message store after 2
attempts. That's probably fine for most people, but what if someone really wants to
avoid the message store and try 3, 4 or 5 times? Or alterantively they don't want to
bother checking at all if the first cache fails? We should try to offer flexibility, even
if 80% of the time it isn't needed.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:57 p.m.
New subject: [JBoss JIRA] Commented: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=comments#action_12368792 ]
Kurt Stam commented on JBESB-678:
---------------------------------
I will rename the parameter and not call it "retryTattempt",because that is not
what it is. It is just a way be able to cache information from the Registry, without
getting into trouble.
Message Redelivery will be configurable.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:02 a.m.
New subject: [JBoss JIRA] Closed: (JBESB-678) Remove retry hard-coded magic number
[ http://jira.jboss.com/jira/browse/JBESB-678?page=all ]
Kurt Stam closed JBESB-678.
---------------------------
Resolution: Done
Removed the magic number, and replaced it by a staleEPRCache boolean.
Remove retry hard-coded magic number
------------------------------------
Key: JBESB-678
URL: http://jira.jboss.com/jira/browse/JBESB-678
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 3
Reporter: Mark Little
Assigned To: Kurt Stam
Fix For: 4.2
ServiceInvoker appears to retry deliver twice:
private Message deliver(Message message, boolean synchronous) throws
MessageDeliverException
{
int numberOfAttemps=0;
while (numberOfAttemps++ < 2) {
2 is an arbitrary number. Rather than hard-code it, it should be configurable, at least
via a run-time property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6816
days inactive
6850
days old
7 comments
2 participants
participants (2)
-
Kurt Stam (JIRA) -
Mark Little (JIRA)