[JBoss JIRA] Created: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
4:34 a.m.
JMSCorrelationID pulled from message body when it should be the header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:34 a.m.
New subject: [JBoss JIRA] Work started: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=all ]
Work on JBESB-656 started by Mark Little.
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:53 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=comments#action_12367828 ]
Daniel Bevenius commented on JBESB-656:
---------------------------------------
It look like this is related to jira : http://jira.jboss.com/jira/browse/JBESB-651.
/Daniel
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=comments#action_12367836 ]
Mark Little commented on JBESB-656:
-----------------------------------
Definitely related, but my original assumption was wrong. For some reason we're not
using the MessageID in the header field for relating JMS messages. Not sure why we
don't do that and I've created another issue for that. Turns out this issue is
really about badly naming the body element as MessageId when we already have something
called MessageID.
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:02 a.m.
New subject: [JBoss JIRA] Closed: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=all ]
Mark Little closed JBESB-656.
-----------------------------
Resolution: Done
I've changed the name from MessageId to
org.jboss.soa.esb.message.transport.jms.correlationID (to avoid any further confusion!),
added this to Environment.java so it is globally available and not hard-coded into the
classes that use it, and changed those two classes to use it. That just leaves the related
issues!
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:28 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=comments#action_12367842 ]
Daniel Bevenius commented on JBESB-656:
---------------------------------------
Could we name the JMSMessageID to org.jboss.soa.esb.message.transport.jms.messageID, or
simply let it be named JMSMessageID?
If we also pass along the JMSCorrelationID with the ESB Message object later there will be
confusion about which is which.
The reason for this is that an application can set the JMSCorrelationID to an application
specific string and it does not have to involve the JMSMessageID.
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:48 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=comments#action_12367975 ]
Daniel Bevenius commented on JBESB-656:
---------------------------------------
Hi Mark,
just to follow up on this. I checked out the jms spec last night and this is what it says
about the JMSCorrelationID:
3.4.5 JMSCorrelationID
A client can use the JMSCorrelationID header field to link one message with
another. A typical use is to link a response message with its request message.
JMSCorrelationID can hold one of the following:
• A provider-specific message ID
• An application-specific String
• A provider-native byte[] value
...
In some cases, an application (made up of several clients) needs to use an
application-specific value for linking messages. For instance, an application
may use JMSCorrelationID to hold a value referencing some external
information.
How about a default implementation for JMSRouter to set the JMSCorrelationID to the
JMSMessageID and with the refactoring of JBESB-651 others can extend JMSRouter to meet
their specific needs?
Thanks,
Daniel
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:48 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-656) JMSCorrelationID pulled from message body when it should be the header
[ http://jira.jboss.com/jira/browse/JBESB-656?page=comments#action_12368020 ]
Mark Little commented on JBESB-656:
-----------------------------------
Sounds reasonable to me.
JMSCorrelationID pulled from message body when it should be the
header
----------------------------------------------------------------------
Key: JBESB-656
URL: http://jira.jboss.com/jira/browse/JBESB-656
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.2 Milestone Release 2
Reporter: Mark Little
Assigned To: Mark Little
Priority: Critical
Fix For: 4.2 Milestone Release 3
if (message.getBody().get("MessageId")!=null) {
oMsg.setJMSCorrelationID((String)message.getBody().get("MessageId"));
}
Does not make sense, because the MessageId is from the EPR, which is within the header.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6849
days inactive
6850
days old
7 comments
2 participants
participants (2)
-
Daniel Bevenius (JIRA) -
Mark Little (JIRA)