[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] Kevin Conner commented on JBESB-2922: ------------------------------------- Fantastic, thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] David Ward commented on JBESB-2922: ----------------------------------- I've debugged this a bit. The problem appears to be in a behavioral difference of javax.xml.validation.Validator between JDK 1.5 and 1.6. Inside SchemaValidationAction.java's validate(String):void method, you will find these lines: ... final DOMResult result = new DOMResult(); try { final Validator validator = schema.newValidator(); validator.validate(createDomSourceFromPayload(xml), result); } catch (final SAXException e) { final String errorMsg = "SAXException while trying to validate against schema '" + xsd + "'"; log.error(errorMsg, e); throw new ValidationException(errorMsg, e, result); ... What I see while debugging is that the "result" object's node is not being populated in JDK 1.6, whereas it is in JDK 1.5. This means that when the ValidationException is created, and the DOMResult.getNode() is serialized, in JDK 1.6 the serialized String is only the XML header (<?xml version=...?>), whereas in JDK 1.5 it is the entire (albeit invalid) document (including <shiporder orderid=...>). This then has a ripple effect such that when ValidationException.getDomResult() is called, and we try to parse the serialized String, in JDK 1.6 (which only has the XML header), we get a "Premature end of file". Now, here comes the big question... The only code that ever calls ValidationException.getDomResult() are JUnit tests: JBESB_2916_UnitTest (which passes), and SchemaValidationActionUnitTest (which fails under JDK 1.6 due to the above, but this test was added on the branch that broke the CI build). So, do we try to get javax.xml.validation.Validator to work the same on JDK 1.6 as it does on JDK 1.5, or is this an invalid test? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] David Ward commented on JBESB-2922: ----------------------------------- Seems like I'm not the only person who noticed a change in behavior: http://forums.java.net/jive/thread.jspa?messageID=326144 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] Kevin Conner commented on JBESB-2922: ------------------------------------- Is there any good reason for having that result? If not, just remove it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBESB-2922: ------------------------------------- The reason I didn't remove this was because it's part of the public API and I thought policy was that we didn't modify it without going through a deprecation cycle first. I can't imagine anyone using it, but you never know I guess. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBESB-2922: ------------------------------------- You could deprecate it for now? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] Kevin Conner commented on JBESB-2922: ------------------------------------- Well, I'm not sure how much use (or sense) sending a DOMResult makes but, as it is an object reference, we could still keep the methods (API) on the exception and have it permanently set to null. It hasn't made it into the platform yet so we are not tied so strictly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] David Ward commented on JBESB-2922: ----------------------------------- Yeah, but that still "breaks" it for community people. My vote is to go with Tom's idea of deprecating it, but I'll concede to your decision, which is...? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] Kevin Conner commented on JBESB-2922: ------------------------------------- It doesn't break anything for the community unless they have assumed that the DOMResult is always present. We can keep the API compatibility by returning null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBESB-2922?page=com.atlassian.jira.plu... ] David Ward closed JBESB-2922. ----------------------------- Resolution: Done [dward@dwardlinux trunk]$ svn commit Sending product/rosetta/src/org/jboss/soa/esb/actions/validation/SchemaValidationAction.java Sending product/rosetta/src/org/jboss/soa/esb/actions/validation/ValidationException.java Deleting product/rosetta/tests/src/org/jboss/soa/esb/actions/validation/JBESB_2916_UnitTest.java Sending product/rosetta/tests/src/org/jboss/soa/esb/actions/validation/SchemaValidationActionUnitTest.java Transmitting file data ... Committed revision 29936. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira