[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12363053 ] Tom Fennelly commented on JBESB-575: ------------------------------------ I think we're gone off in a bit of a tangent there. I'm not suggesting we change how EPRs etc are used, or what they mean. I'm just stating the fact that within the core ESB code, we have 3 different ways of doing essentially the same thing - going from a service cat:name combo to a working courier that can deliver a message to that service. In most of the situations that I've seen, the code has been (for the most part) a c+p job. This is how I ended up creating the MessageDeliveryAdapter and Bill ended up creating the ServiceInvoker. Neither of these classes change anything about how EPRs etc are used. They just encapsulate this 90%+ usecase into an easy to use class, cutting out the need to write all that ugly code that most people are not interested in (IMO). So out of that I was trying to highlight 2 main problems: 1. Situations where the core ESB code could be cleaned up by replacing this boiler plate code with one of the 2 classes I mentioned. 2. The fact that we have 2 classes doing the same thing - MessageDeliveryAdapter and ServiceInvoker. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12363171 ] Tom Fennelly commented on JBESB-575: ------------------------------------ +1 :-) Yeah, we need to settle on one of those 2 classes first, and then remove the duplication on a case by case basis. What I was originally suggesting was that perhaps we could just remove them as we encounter them via bug fixes etc, but they might never get removed doing it that way ;-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12363245 ] Mark Little commented on JBESB-575: ----------------------------------- So which of the two classes goes? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12365993 ] Mark Little commented on JBESB-575: ----------------------------------- Not really. It's more a generic client stub. The closest things we have to dispatchers would be a mix of the interceptors and the actions. I'd leave this as MDA for now, to avoid confusion (we've talked about Dispatchers for a long time and calling something a dispatcher now that isn't quite could confuse issues). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12367171 ] Mark Little commented on JBESB-575: ----------------------------------- You mean remove MessageDeliverAdapter ;-)? Sure, go for it! We need just one approach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12367173 ] Tom Fennelly commented on JBESB-575: ------------------------------------ lol, no... I mean remove ServiceInvoker and rename MessageDeliveryAdapter to ServiceInvoker. The only thing we want from ServiceInvoker is its name ;-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBESB-575?page=comments#action_12368575 ] Tom Fennelly commented on JBESB-575: ------------------------------------ Some of the refactorings are done for this but there are a few important ones left. Some of the Gateways are still using the EPSs and Couriers by hand, which is not only unmaintainable, but it also means we get no benefit from the loadbalancing etc code that' in the ServiceInvoker. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira