4:37 p.m.
Author: dkatayev
Date: 2010-06-02 10:37:24 -0400 (Wed, 02 Jun 2010)
New Revision: 2451
Modified:
core/trunk/exo.core.component.document/src/main/java/org/exoplatform/services/document/impl/MSExcelDocumentReader.java
Log:
EXOJCR-765 String concatenation replaced with StringBuilder.append()
Modified:
core/trunk/exo.core.component.document/src/main/java/org/exoplatform/services/document/impl/MSExcelDocumentReader.java
===================================================================
---
core/trunk/exo.core.component.document/src/main/java/org/exoplatform/services/document/impl/MSExcelDocumentReader.java 2010-06-02
12:23:09 UTC (rev 2450)
+++
core/trunk/exo.core.component.document/src/main/java/org/exoplatform/services/document/impl/MSExcelDocumentReader.java 2010-06-02
14:37:24 UTC (rev 2451)
@@ -67,7 +67,7 @@
throw new NullPointerException("InputStream is null.");
}
- String text = "";
+ StringBuilder builder = new StringBuilder("");
try
{
@@ -78,7 +78,7 @@
}
catch (IOException e)
{
- return text;
+ return builder.toString();
}
for (int sheetNum = 0; sheetNum < wb.getNumberOfSheets(); sheetNum++)
{
@@ -105,25 +105,25 @@
{
Date date = HSSFDateUtil.getJavaDate(d);
String cellText = this.DATE_FORMAT.format(date);
- text = text + cellText + " ";
+ builder.append(cellText).append(" ");
}
else
{
- text = text + d + " ";
+ builder.append(d).append(" ");
}
break;
}
case HSSFCell.CELL_TYPE_FORMULA :
- text = text + cell.getCellFormula().toString() + "
";
+
builder.append(cell.getCellFormula().toString()).append(" ");
break;
case HSSFCell.CELL_TYPE_BOOLEAN :
- text = text + cell.getBooleanCellValue() + "
";
+ builder.append(cell.getBooleanCellValue()).append("
");
break;
case HSSFCell.CELL_TYPE_ERROR :
- text = text + cell.getErrorCellValue() + " ";
+ builder.append(cell.getErrorCellValue()).append("
");
break;
case HSSFCell.CELL_TYPE_STRING :
- text = text + cell.getStringCellValue().toString() +
" ";
+
builder.append(cell.getStringCellValue().toString()).append(" ");
break;
default :
break;
@@ -148,7 +148,7 @@
}
}
}
- return text;
+ return builder.toString();
}
public String getContentAsText(InputStream is, String encoding) throws IOException,
DocumentReadException