Author: tolusha Date: 2010-11-18 04:52:21 -0500 (Thu, 18 Nov 2010) New Revision: 3480 Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/jbosscache/JBossCacheWorkspaceStorageCache.java Log: JCR-1505: Avoid iterating over a List thanks to its iterator when it is possible Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/jbosscache/JBossCacheWorkspaceStorageCache.java =================================================================== --- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/jbosscache/JBossCacheWorkspaceStorageCache.java 2010-11-18 09:50:00 UTC (rev 3479) +++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/jbosscache/JBossCacheWorkspaceStorageCache.java 2010-11-18 09:52:21 UTC (rev 3480) @@ -812,8 +812,10 @@ } // add property as many times as has referenced values - for (ValueData vdata : prop.getValues()) + List<ValueData> lData = prop.getValues(); + for (int i = 0, length = lData.size(); i < length; i++) { + ValueData vdata = lData.get(i); try { if (new String(vdata.getAsByteArray(), Constants.DEFAULT_ENCODING).equals(identifier)) @@ -1163,8 +1165,10 @@ // add referenced property if (modifyListsOfChild != ModifyChildOption.NOT_MODIFY && prop.getType() == PropertyType.REFERENCE) { - for (ValueData vdata : prop.getValues()) + List<ValueData> lData = prop.getValues(); + for (int i = 0, length = lData.size(); i < length; i++) { + ValueData vdata = lData.get(i); String nodeIdentifier = null; try {