Author: andrew.plotnikov Date: 2012-01-26 08:37:19 -0500 (Thu, 26 Jan 2012) New Revision: 5525 Modified: ws/branches/2.3.x/exo.ws.rest.core/src/main/java/org/exoplatform/services/rest/impl/InputHeadersMap.java ws/branches/2.3.x/exo.ws.rest.core/src/test/java/org/exoplatform/services/rest/impl/header/InputHeadersMapTest.java ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/ResourceKey.java ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/RestResource.java ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/invocation/SimpleMethodInvoker.java ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/provider/XSLTStreamingOutput.java Log: EXOJCR-1725: Fixed the Blocker/Critical violations and the easiest Major ones raised by eXo Quality Level 1.2 Modified: ws/branches/2.3.x/exo.ws.rest.core/src/main/java/org/exoplatform/services/rest/impl/InputHeadersMap.java =================================================================== --- ws/branches/2.3.x/exo.ws.rest.core/src/main/java/org/exoplatform/services/rest/impl/InputHeadersMap.java 2012-01-26 13:35:42 UTC (rev 5524) +++ ws/branches/2.3.x/exo.ws.rest.core/src/main/java/org/exoplatform/services/rest/impl/InputHeadersMap.java 2012-01-26 13:37:19 UTC (rev 5525) @@ -71,7 +71,7 @@ { if (m == null) { - throw new IllegalArgumentException(); + throw new IllegalArgumentException("parameter \"m\" cannot be null"); } this.m = new HashMap<String, List<String>>(m.size()); for (Map.Entry<String, List<String>> e : m.entrySet()) Modified: ws/branches/2.3.x/exo.ws.rest.core/src/test/java/org/exoplatform/services/rest/impl/header/InputHeadersMapTest.java =================================================================== --- ws/branches/2.3.x/exo.ws.rest.core/src/test/java/org/exoplatform/services/rest/impl/header/InputHeadersMapTest.java 2012-01-26 13:35:42 UTC (rev 5524) +++ ws/branches/2.3.x/exo.ws.rest.core/src/test/java/org/exoplatform/services/rest/impl/header/InputHeadersMapTest.java 2012-01-26 13:37:19 UTC (rev 5525) @@ -43,7 +43,7 @@ try { um = new InputHeadersMap(null); - fail("NullPointerException should be here"); + fail("IllegalArgumentException should be here"); } catch (IllegalArgumentException e) { Modified: ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/ResourceKey.java =================================================================== --- ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/ResourceKey.java 2012-01-26 13:35:42 UTC (rev 5524) +++ ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/ResourceKey.java 2012-01-26 13:37:19 UTC (rev 5525) @@ -33,7 +33,7 @@ { if (name == null) { - throw new IllegalArgumentException(); + throw new IllegalArgumentException("parameter name cannot be null"); } this.name = name; } Modified: ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/RestResource.java =================================================================== --- ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/RestResource.java 2012-01-26 13:35:42 UTC (rev 5524) +++ ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/RestResource.java 2012-01-26 13:37:19 UTC (rev 5525) @@ -242,7 +242,7 @@ } catch (Exception e) { - LOG.error(e.getMessage()); + LOG.error("An exception occured: " + e.getMessage()); return Response.serverError(); } finally Modified: ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/invocation/SimpleMethodInvoker.java =================================================================== --- ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/invocation/SimpleMethodInvoker.java 2012-01-26 13:35:42 UTC (rev 5524) +++ ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/management/invocation/SimpleMethodInvoker.java 2012-01-26 13:37:19 UTC (rev 5525) @@ -38,7 +38,7 @@ { if (method == null) { - throw new IllegalArgumentException(); + throw new IllegalArgumentException("The method cannot be null"); } // Modified: ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/provider/XSLTStreamingOutput.java =================================================================== --- ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/provider/XSLTStreamingOutput.java 2012-01-26 13:35:42 UTC (rev 5524) +++ ws/branches/2.3.x/exo.ws.rest.ext/src/main/java/org/exoplatform/services/rest/ext/provider/XSLTStreamingOutput.java 2012-01-26 13:37:19 UTC (rev 5525) @@ -109,8 +109,7 @@ } else { - String msg = "XSLT scheme name is null."; - throw new IllegalArgumentException(msg); + throw new IllegalArgumentException("XSLT scheme name is null."); } transformer.initResult(new StreamResult(outStream)); if (xsltParams != null)