August 2013 - forge-issues - Jboss List Archives

[JBoss JIRA] (FORGE-1045) Unit tests should not have a fixed version

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-1045?page=com.atlassian.jira.plugin... ] George Gastaldi commented on FORGE-1045: ---------------------------------------- Given that the reactor build is not sharing state with the dependency resolution provided by the furnace-manager-resolver-maven implementation, the best solution is to change the release:prepare goals to perform _clean install_ as explained above. Other solutions could involve adding a new goal to the furnace-maven-plugin, however I believe that changing the release:prepare goals should be enough. > Unit tests should not have a fixed version > ------------------------------------------ > > Key: FORGE-1045 > URL: https://issues.jboss.org/browse/FORGE-1045 > Project: Forge > Issue Type: Enhancement > Components: Test Harness > Affects Versions: 2.0.0.Alpha7 > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.0.0.Alpha10 > > > Tests now depend on 2.0.0-SNAPSHOT, which may fail when a new version of the addon dependency is released. > We should find some way to avoid declaring the addon dependencies version directly in the Java class. > Excerpt from IRC: > {quote} > <gastaldi> lincolnthree, about the version in the dependencies > <gastaldi> in the tests > <lincolnthree> yes > <gastaldi> What if we consider that if no @Dependencies annotation were provided it should use the pom's dependencies ? > <lincolnthree> can't do that > <gastaldi> why ? > <lincolnthree> because you should be able to depend on dependencies that don't exist > <lincolnthree> without having to remove them from the pom > <lincolnthree> it's a valid failure scenario (laughs at that wording) > <lincolnthree> so we need to be able to test it > <lincolnthree> gastaldi: i would much prefer setting the version to "POM" > <lincolnthree> or omitting the version entirely > <lincolnthree> from the @AddonDependency annotation > <gastaldi> I think it's already optional, no ? > <lincolnthree> it is > <lincolnthree> and the default is LATEST > <lincolnthree> default should probably be POM, which we should intercept and replace with the pom version > <lincolnthree> or throw a deployment exception if it could not be resolved > <gastaldi> I see > <lincolnthree> thoughts? > <gastaldi> What about the AddonDependencyEntry.create statements ? > <gastaldi> sounds fair so far > <gastaldi> we could introduce a new method in ForgeArchive > <gastaldi> addAddonDependenciesAsDeclaredInPOMForGodsSake() > <lincolnthree> ah… right > <lincolnthree> well > <lincolnthree> the version there doesn't matter, remember? > <lincolnthree> so we could actually make the version optional > <lincolnthree> it could default to "anything" > <gastaldi> so so we need a AnythingGoesVersion implements Version subclass > <gastaldi> an enum > <gastaldi> public enum Anything implements Version { INSTANCE;} > <gastaldi> hum, or the version could be empty, right > <gastaldi> in that case there is already the EmptyVersion class > <lincolnthree> right > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1045) Unit tests should not have a fixed version

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-1045?page=com.atlassian.jira.plugin... ] Work on FORGE-1045 started by George Gastaldi. > Unit tests should not have a fixed version > ------------------------------------------ > > Key: FORGE-1045 > URL: https://issues.jboss.org/browse/FORGE-1045 > Project: Forge > Issue Type: Enhancement > Components: Test Harness > Affects Versions: 2.0.0.Alpha7 > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.0.0.Alpha10 > > > Tests now depend on 2.0.0-SNAPSHOT, which may fail when a new version of the addon dependency is released. > We should find some way to avoid declaring the addon dependencies version directly in the Java class. > Excerpt from IRC: > {quote} > <gastaldi> lincolnthree, about the version in the dependencies > <gastaldi> in the tests > <lincolnthree> yes > <gastaldi> What if we consider that if no @Dependencies annotation were provided it should use the pom's dependencies ? > <lincolnthree> can't do that > <gastaldi> why ? > <lincolnthree> because you should be able to depend on dependencies that don't exist > <lincolnthree> without having to remove them from the pom > <lincolnthree> it's a valid failure scenario (laughs at that wording) > <lincolnthree> so we need to be able to test it > <lincolnthree> gastaldi: i would much prefer setting the version to "POM" > <lincolnthree> or omitting the version entirely > <lincolnthree> from the @AddonDependency annotation > <gastaldi> I think it's already optional, no ? > <lincolnthree> it is > <lincolnthree> and the default is LATEST > <lincolnthree> default should probably be POM, which we should intercept and replace with the pom version > <lincolnthree> or throw a deployment exception if it could not be resolved > <gastaldi> I see > <lincolnthree> thoughts? > <gastaldi> What about the AddonDependencyEntry.create statements ? > <gastaldi> sounds fair so far > <gastaldi> we could introduce a new method in ForgeArchive > <gastaldi> addAddonDependenciesAsDeclaredInPOMForGodsSake() > <lincolnthree> ah… right > <lincolnthree> well > <lincolnthree> the version there doesn't matter, remember? > <lincolnthree> so we could actually make the version optional > <lincolnthree> it could default to "anything" > <gastaldi> so so we need a AnythingGoesVersion implements Version subclass > <gastaldi> an enum > <gastaldi> public enum Anything implements Version { INSTANCE;} > <gastaldi> hum, or the version could be empty, right > <gastaldi> in that case there is already the EmptyVersion class > <lincolnthree> right > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1089) EnumConstant interface should extend AnnotationTarget

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/FORGE-1089?page=com.atlassian.jira.plugin... ] Matt Benson reassigned FORGE-1089: ---------------------------------- Assignee: Matt Benson > EnumConstant interface should extend AnnotationTarget > ----------------------------------------------------- > > Key: FORGE-1089 > URL: https://issues.jboss.org/browse/FORGE-1089 > Project: Forge > Issue Type: Feature Request > Components: Parsers / File Manipulation > Affects Versions: 2.0.0.Alpha9 > Reporter: Matt Benson > Assignee: Matt Benson > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1089) EnumConstant interface should extend AnnotationTarget

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/FORGE-1089?page=com.atlassian.jira.plugin... ] Work on FORGE-1089 started by Matt Benson. > EnumConstant interface should extend AnnotationTarget > ----------------------------------------------------- > > Key: FORGE-1089 > URL: https://issues.jboss.org/browse/FORGE-1089 > Project: Forge > Issue Type: Feature Request > Components: Parsers / File Manipulation > Affects Versions: 2.0.0.Alpha9 > Reporter: Matt Benson > Assignee: Matt Benson > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1089) EnumConstant interface should extend AnnotationTarget

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/FORGE-1089?page=com.atlassian.jira.plugin... ] Matt Benson resolved FORGE-1089. -------------------------------- Resolution: Done Resolved with commit 816c028cd5fb0c7411d33beff92a86f2bd7814f1. > EnumConstant interface should extend AnnotationTarget > ----------------------------------------------------- > > Key: FORGE-1089 > URL: https://issues.jboss.org/browse/FORGE-1089 > Project: Forge > Issue Type: Feature Request > Components: Parsers / File Manipulation > Affects Versions: 2.0.0.Alpha9 > Reporter: Matt Benson > Assignee: Matt Benson > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1089) EnumConstant interface should extend AnnotationTarget

by Matt Benson (JIRA)

Matt Benson created FORGE-1089: ---------------------------------- Summary: EnumConstant interface should extend AnnotationTarget Key: FORGE-1089 URL: https://issues.jboss.org/browse/FORGE-1089 Project: Forge Issue Type: Feature Request Components: Parsers / File Manipulation Affects Versions: 2.0.0.Alpha9 Reporter: Matt Benson -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1087) DependencyFacet.removeProperty should be moved to MetadataFacet

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-1087?page=com.atlassian.jira.plugin... ] George Gastaldi closed FORGE-1087. ---------------------------------- Resolution: Done > DependencyFacet.removeProperty should be moved to MetadataFacet > --------------------------------------------------------------- > > Key: FORGE-1087 > URL: https://issues.jboss.org/browse/FORGE-1087 > Project: Forge > Issue Type: Enhancement > Components: Builtin Plugins > Affects Versions: 2.0.0.Alpha9 > Reporter: George Gastaldi > Assignee: George Gastaldi > Fix For: 2.0.0.Alpha10 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1088) DependencyFacet.setProperty and removeProperty should be renamed to setDirectProperty and removeDirectProperty

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-1088?page=com.atlassian.jira.plugin... ] George Gastaldi closed FORGE-1088. ---------------------------------- Resolution: Done > DependencyFacet.setProperty and removeProperty should be renamed to setDirectProperty and removeDirectProperty > -------------------------------------------------------------------------------------------------------------- > > Key: FORGE-1088 > URL: https://issues.jboss.org/browse/FORGE-1088 > Project: Forge > Issue Type: Enhancement > Components: Builtin Plugins > Affects Versions: 2.0.0.Alpha9 > Reporter: George Gastaldi > Assignee: George Gastaldi > Priority: Trivial > Fix For: 2.0.0.Alpha10 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1088) DependencyFacet.setProperty and removeProperty should be renamed to setDirectProperty and removeDirectProperty

by George Gastaldi (JIRA)

George Gastaldi created FORGE-1088: -------------------------------------- Summary: DependencyFacet.setProperty and removeProperty should be renamed to setDirectProperty and removeDirectProperty Key: FORGE-1088 URL: https://issues.jboss.org/browse/FORGE-1088 Project: Forge Issue Type: Enhancement Components: Builtin Plugins Affects Versions: 2.0.0.Alpha9 Reporter: George Gastaldi Assignee: George Gastaldi Priority: Trivial Fix For: 2.0.0.Alpha10 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (FORGE-964) New Project Wizard - Forge Addon Type throws an exception when run in Windows 7

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-964?page=com.atlassian.jira.plugin.... ] George Gastaldi closed FORGE-964. --------------------------------- Assignee: (was: George Gastaldi) Fix Version/s: (was: 2.x Future) Resolution: Incomplete Description > New Project Wizard - Forge Addon Type throws an exception when run in Windows 7 > ------------------------------------------------------------------------------- > > Key: FORGE-964 > URL: https://issues.jboss.org/browse/FORGE-964 > Project: Forge > Issue Type: Bug > Components: Windows > Affects Versions: 2.0.0.Alpha5 > Reporter: George Gastaldi > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues August 2013