[JBoss JIRA] (FORGE-1081) REST plugin should create the REST resources in the same package as the @ApplicationPath annotated class
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1081?page=com.atlassian.jira.plugin... ]
Vineet Reynolds commented on FORGE-1081:
----------------------------------------
This would help the cause of consistency, especially in TicketMonster where some existing REST resources are already created along side an already existing {{@ApplicationPath}} activator class.
When the current REST plugin creates resources from JPA entities in TicketMonster, they're created in a new package instead of being placed alongside the existing one.
> REST plugin should create the REST resources in the same package as the @ApplicationPath annotated class
> --------------------------------------------------------------------------------------------------------
>
> Key: FORGE-1081
> URL: https://issues.jboss.org/browse/FORGE-1081
> Project: Forge
> Issue Type: Feature Request
> Components: Builtin Plugins
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
>
> When REST is setup in a project and activated through the {{@ApplicationPath}} annotated class, it would be preferable to generate all the REST resources in the same package instead of using the computed package from the project's group Id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (FORGE-1045) Unit tests should not have a fixed version
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1045?page=com.atlassian.jira.plugin... ]
George Gastaldi reassigned FORGE-1045:
--------------------------------------
Assignee: George Gastaldi
> Unit tests should not have a fixed version
> ------------------------------------------
>
> Key: FORGE-1045
> URL: https://issues.jboss.org/browse/FORGE-1045
> Project: Forge
> Issue Type: Enhancement
> Components: Test Harness
> Affects Versions: 2.0.0.Alpha7
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Fix For: 2.0.0.Alpha10
>
>
> Tests now depend on 2.0.0-SNAPSHOT, which may fail when a new version of the addon dependency is released.
> We should find some way to avoid declaring the addon dependencies version directly in the Java class.
> Excerpt from IRC:
> {quote}
> <gastaldi> lincolnthree, about the version in the dependencies
> <gastaldi> in the tests
> <lincolnthree> yes
> <gastaldi> What if we consider that if no @Dependencies annotation were provided it should use the pom's dependencies ?
> <lincolnthree> can't do that
> <gastaldi> why ?
> <lincolnthree> because you should be able to depend on dependencies that don't exist
> <lincolnthree> without having to remove them from the pom
> <lincolnthree> it's a valid failure scenario (laughs at that wording)
> <lincolnthree> so we need to be able to test it
> <lincolnthree> gastaldi: i would much prefer setting the version to "POM"
> <lincolnthree> or omitting the version entirely
> <lincolnthree> from the @AddonDependency annotation
> <gastaldi> I think it's already optional, no ?
> <lincolnthree> it is
> <lincolnthree> and the default is LATEST
> <lincolnthree> default should probably be POM, which we should intercept and replace with the pom version
> <lincolnthree> or throw a deployment exception if it could not be resolved
> <gastaldi> I see
> <lincolnthree> thoughts?
> <gastaldi> What about the AddonDependencyEntry.create statements ?
> <gastaldi> sounds fair so far
> <gastaldi> we could introduce a new method in ForgeArchive
> <gastaldi> addAddonDependenciesAsDeclaredInPOMForGodsSake()
> <lincolnthree> ah… right
> <lincolnthree> well
> <lincolnthree> the version there doesn't matter, remember?
> <lincolnthree> so we could actually make the version optional
> <lincolnthree> it could default to "anything"
> <gastaldi> so so we need a AnythingGoesVersion implements Version subclass
> <gastaldi> an enum
> <gastaldi> public enum Anything implements Version { INSTANCE;}
> <gastaldi> hum, or the version could be empty, right
> <gastaldi> in that case there is already the EmptyVersion class
> <lincolnthree> right
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months
[JBoss JIRA] (FORGE-1045) Unit tests should not have a fixed version
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1045?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-1045:
-----------------------------------
Fix Version/s: (was: 2.x Future)
> Unit tests should not have a fixed version
> ------------------------------------------
>
> Key: FORGE-1045
> URL: https://issues.jboss.org/browse/FORGE-1045
> Project: Forge
> Issue Type: Enhancement
> Components: Test Harness
> Affects Versions: 2.0.0.Alpha7
> Reporter: George Gastaldi
>
> Tests now depend on 2.0.0-SNAPSHOT, which may fail when a new version of the addon dependency is released.
> We should find some way to avoid declaring the addon dependencies version directly in the Java class.
> Excerpt from IRC:
> {quote}
> <gastaldi> lincolnthree, about the version in the dependencies
> <gastaldi> in the tests
> <lincolnthree> yes
> <gastaldi> What if we consider that if no @Dependencies annotation were provided it should use the pom's dependencies ?
> <lincolnthree> can't do that
> <gastaldi> why ?
> <lincolnthree> because you should be able to depend on dependencies that don't exist
> <lincolnthree> without having to remove them from the pom
> <lincolnthree> it's a valid failure scenario (laughs at that wording)
> <lincolnthree> so we need to be able to test it
> <lincolnthree> gastaldi: i would much prefer setting the version to "POM"
> <lincolnthree> or omitting the version entirely
> <lincolnthree> from the @AddonDependency annotation
> <gastaldi> I think it's already optional, no ?
> <lincolnthree> it is
> <lincolnthree> and the default is LATEST
> <lincolnthree> default should probably be POM, which we should intercept and replace with the pom version
> <lincolnthree> or throw a deployment exception if it could not be resolved
> <gastaldi> I see
> <lincolnthree> thoughts?
> <gastaldi> What about the AddonDependencyEntry.create statements ?
> <gastaldi> sounds fair so far
> <gastaldi> we could introduce a new method in ForgeArchive
> <gastaldi> addAddonDependenciesAsDeclaredInPOMForGodsSake()
> <lincolnthree> ah… right
> <lincolnthree> well
> <lincolnthree> the version there doesn't matter, remember?
> <lincolnthree> so we could actually make the version optional
> <lincolnthree> it could default to "anything"
> <gastaldi> so so we need a AnythingGoesVersion implements Version subclass
> <gastaldi> an enum
> <gastaldi> public enum Anything implements Version { INSTANCE;}
> <gastaldi> hum, or the version could be empty, right
> <gastaldi> in that case there is already the EmptyVersion class
> <lincolnthree> right
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 6 months