May 2014 - forge-issues - Jboss List Archives

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Lincoln Baxter III (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Lincoln Baxter III commented on ROASTER-13: ------------------------------------------- >From what I see in the code, it probably makes sense for these checks to occur in the isMutator() method... it's only used in one place, and if you find yourself duplicating the checks in getMutator() that are not included in isMutator() for some reason, then it's possible those additional checks should be pulled into the method. It's an implementation detail, and if pulling this together makes the code simpler, I'm all for it. > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1820) Include document that describes how to get your addon listed in the Forge 2 addon repository

by Lincoln Baxter III (JIRA)

Lincoln Baxter III created FORGE-1820: ----------------------------------------- Summary: Include document that describes how to get your addon listed in the Forge 2 addon repository Key: FORGE-1820 URL: https://issues.jboss.org/browse/FORGE-1820 Project: Forge Issue Type: Sub-task Components: Website Affects Versions: 2.5.0.Final Reporter: Lincoln Baxter III Fix For: 2.x Future There should also be a link to this document from the addon search page and single addon view pages. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1821) Download links on Forge 2 website should actually work and probably should automatically point to the latest release

by Lincoln Baxter III (JIRA)

Lincoln Baxter III created FORGE-1821: ----------------------------------------- Summary: Download links on Forge 2 website should actually work and probably should automatically point to the latest release Key: FORGE-1821 URL: https://issues.jboss.org/browse/FORGE-1821 Project: Forge Issue Type: Sub-task Components: Website Affects Versions: 2.5.0.Final Reporter: Lincoln Baxter III Fix For: 2.x Future -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1819) Include red hat logo on footer of all pages of website

by Lincoln Baxter III (JIRA)

Lincoln Baxter III created FORGE-1819: ----------------------------------------- Summary: Include red hat logo on footer of all pages of website Key: FORGE-1819 URL: https://issues.jboss.org/browse/FORGE-1819 Project: Forge Issue Type: Sub-task Components: Website Affects Versions: 2.5.0.Final Reporter: Lincoln Baxter III Fix For: 2.x Future -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1818) Forge `addon-install` should POST to the website REST services to update download count statistics

by Lincoln Baxter III (JIRA)

Lincoln Baxter III created FORGE-1818: ----------------------------------------- Summary: Forge `addon-install` should POST to the website REST services to update download count statistics Key: FORGE-1818 URL: https://issues.jboss.org/browse/FORGE-1818 Project: Forge Issue Type: Sub-task Components: Addon Manager, Website Affects Versions: 2.5.0.Final Reporter: Lincoln Baxter III Fix For: 2.x Future The website should be able to track download statistics for addons, as well as daily usage statistics. This should be built in to the addon-install command (if user has agreed to send stats.) The addon-install command should post that an addon has been installed, and provide its maven coordinates, addon-id, the source repo if available, and any other information that can be extracted during installation. Stats will only appear publicly if the addon is listed on the website. Otherwise stats will be held privately in confidence. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1817) Create an `addon-search` command that uses the website REST services as a data-source.

by Lincoln Baxter III (JIRA)

Lincoln Baxter III created FORGE-1817: ----------------------------------------- Summary: Create an `addon-search` command that uses the website REST services as a data-source. Key: FORGE-1817 URL: https://issues.jboss.org/browse/FORGE-1817 Project: Forge Issue Type: Sub-task Components: Addon Manager, Website Affects Versions: 2.5.0.Final Reporter: Lincoln Baxter III Fix For: 2.x Future The Forge website publishes REST services to allow automated discovery of community addons. This should be used as the basis of a search from the forge addon manager commands. This functionality previously existed in Forge 1. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1797) JavaResource not injected

by Lincoln Baxter III (JIRA)

[ https://issues.jboss.org/browse/FORGE-1797?page=com.atlassian.jira.plugin... ] Lincoln Baxter III commented on FORGE-1797: ------------------------------------------- Glad you got this figured out Michael. Hopefully in Forge 2 this should not be as problematic. Have you considered porting to Forge 2? (Sorry we know it's not exactly 1:1) > JavaResource not injected > ------------------------- > > Key: FORGE-1797 > URL: https://issues.jboss.org/browse/FORGE-1797 > Project: Forge > Issue Type: Bug > Components: Addon Development > Affects Versions: 1.4.4.Final > Reporter: Michael Schwartz > Fix For: 1.x Future > > > Start forge 1.4.4 external from eclipse with newest eclipse-forge plugin 1.3.0.Beta2-v20140507-1551-B609. > - pickup file > - start plugin > - Exception because of missing JavaResource not injected > {code} > @Inject > @Current > private JavaResource resource; > {code} > same with DirectoryResource. > Exception: > {noformat} > java.lang.RuntimeException: The internal resource variable was not injected > at com.mschwartz.forge.scaffold.ScaffoldPlugin.init(ScaffoldPlugin.java:418) > at com.mschwartz.forge.scaffold.ScaffoldPlugin.entitycheck(ScaffoldPlugin.java:229) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.forge.shell.command.Execution.perform(Execution.java:160) > at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109) > at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47) > at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:796) > at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:819) > at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:609) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48) > at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125) > at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.doShell(ShellImpl$Proxy$_$$_WeldClientProxy.java) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305) > at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54) > at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163) > at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299) > at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188) > at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59) > at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198) > at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282) > at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265) > at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234) > at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635) > at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622) > at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616) > at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:186) > at java.lang.Thread.run(Thread.java:745) > {noformat} > rebuilding the plugin does not help. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1816) Display all contributors on the community page

by Lincoln Baxter III (JIRA)

Lincoln Baxter III created FORGE-1816: ----------------------------------------- Summary: Display all contributors on the community page Key: FORGE-1816 URL: https://issues.jboss.org/browse/FORGE-1816 Project: Forge Issue Type: Sub-task Components: Website Affects Versions: 2.5.0.Final Reporter: Lincoln Baxter III Fix For: 2.x Future -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matej Briskar (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matej Briskar edited comment on ROASTER-13 at 5/14/14 11:25 AM: ---------------------------------------------------------------- However, if the `#isMutator()` already access the property name to check the name of the property, wouldn't it be better if it does the job completely and do the checks that are now done afterwards in the method {code}#getMutator(){code} was (Author: mbriskar): However, if the {code}#isMutator(){code} already access the property name to check the name of the property, wouldn't it be better if it does the job completely and do the checks that are now done afterwards in the method {code}#getMutator(){code} > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matej Briskar (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matej Briskar edited comment on ROASTER-13 at 5/14/14 11:25 AM: ---------------------------------------------------------------- However, if the {code}#isMutator(){code} already access the property name to check the name of the property, wouldn't it be better if it does the job completely and do the checks that are now done afterwards in the method {code}#getMutator(){code} was (Author: mbriskar): However, if the `#isMutator()` already access the property name to check the name of the property, wouldn't it be better if it does the job completely and do the checks that are now done afterwards in the method {code}#getMutator(){code} > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues May 2014