May 2014 - forge-issues - Jboss List Archives

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matej Briskar (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matej Briskar edited comment on ROASTER-13 at 5/14/14 11:25 AM: ---------------------------------------------------------------- However, if the `#isMutator()` already access the property name to check the name of the property, wouldn't it be better if it does the job completely and do the checks that are now done afterwards in the method {code}#getMutator(){code} was (Author: mbriskar): However, if the {code}#isMutator(){code} already access the property name to check the name of the property, wouldn't it be better if it does the job completely and do the checks that are now done afterwards in the method {code}#getMutator(){code} > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matt Benson edited comment on ROASTER-13 at 5/14/14 10:54 AM: -------------------------------------------------------------- {{#isMutator()}} cannot be defined independently of {{PropertyImpl}} because it considers the property name. was (Author: mbenson): {{#isMutator()}} cannot be defined outside of {{PropertyImpl}} because it considers the property name. > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matt Benson edited comment on ROASTER-13 at 5/14/14 10:53 AM: -------------------------------------------------------------- {{#isMutator()}} cannot be defined outside of {{PropertyImpl}} because it considers the property name. was (Author: mbenson): {{#isMutator()}} is defined on {{PropertyImpl}} because it considers the property name. > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matt Benson commented on ROASTER-13: ------------------------------------ {{#isMutator()}} is defined on {{PropertyImpl}} because it considers the property name. > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matt Benson (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matt Benson commented on ROASTER-13: ------------------------------------ I don't understand how this is a problem... #isMutator() is just a helper method to determine whether a given method is eligible as a mutator _generally_, then the call site validates that is is indeed "the droid we're looking for." > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1797) JavaResource not injected

by Michael Schwartz (JIRA)

[ https://issues.jboss.org/browse/FORGE-1797?page=com.atlassian.jira.plugin... ] Michael Schwartz closed FORGE-1797. ----------------------------------- Resolution: Done > JavaResource not injected > ------------------------- > > Key: FORGE-1797 > URL: https://issues.jboss.org/browse/FORGE-1797 > Project: Forge > Issue Type: Bug > Components: Addon Development > Affects Versions: 1.4.4.Final > Reporter: Michael Schwartz > Fix For: 1.x Future > > > Start forge 1.4.4 external from eclipse with newest eclipse-forge plugin 1.3.0.Beta2-v20140507-1551-B609. > - pickup file > - start plugin > - Exception because of missing JavaResource not injected > {code} > @Inject > @Current > private JavaResource resource; > {code} > same with DirectoryResource. > Exception: > {noformat} > java.lang.RuntimeException: The internal resource variable was not injected > at com.mschwartz.forge.scaffold.ScaffoldPlugin.init(ScaffoldPlugin.java:418) > at com.mschwartz.forge.scaffold.ScaffoldPlugin.entitycheck(ScaffoldPlugin.java:229) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.forge.shell.command.Execution.perform(Execution.java:160) > at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109) > at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47) > at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:796) > at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:819) > at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:609) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48) > at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125) > at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.doShell(ShellImpl$Proxy$_$$_WeldClientProxy.java) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305) > at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54) > at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163) > at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299) > at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188) > at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59) > at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198) > at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282) > at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265) > at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234) > at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635) > at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622) > at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616) > at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:186) > at java.lang.Thread.run(Thread.java:745) > {noformat} > rebuilding the plugin does not help. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (FORGE-1797) JavaResource not injected

by Michael Schwartz (JIRA)

[ https://issues.jboss.org/browse/FORGE-1797?page=com.atlassian.jira.plugin... ] Michael Schwartz commented on FORGE-1797: ----------------------------------------- Found the problem. Instead of using the {code:xml} <dependency> <groupId>javax</groupId> <artifactId>javaee-api</artifactId> <version>6.0</version> </dependency> {code} in the pom-file I need to use the forge-equivalent: {code:xml} <dependency> <groupId>org.jboss.forge</groupId> <artifactId>forge-javaee-api</artifactId> <version>${forge.api.version}</version> <scope>provided</scope> </dependency> {code} > JavaResource not injected > ------------------------- > > Key: FORGE-1797 > URL: https://issues.jboss.org/browse/FORGE-1797 > Project: Forge > Issue Type: Bug > Components: Addon Development > Affects Versions: 1.4.4.Final > Reporter: Michael Schwartz > Fix For: 1.x Future > > > Start forge 1.4.4 external from eclipse with newest eclipse-forge plugin 1.3.0.Beta2-v20140507-1551-B609. > - pickup file > - start plugin > - Exception because of missing JavaResource not injected > {code} > @Inject > @Current > private JavaResource resource; > {code} > same with DirectoryResource. > Exception: > {noformat} > java.lang.RuntimeException: The internal resource variable was not injected > at com.mschwartz.forge.scaffold.ScaffoldPlugin.init(ScaffoldPlugin.java:418) > at com.mschwartz.forge.scaffold.ScaffoldPlugin.entitycheck(ScaffoldPlugin.java:229) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.forge.shell.command.Execution.perform(Execution.java:160) > at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109) > at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47) > at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:796) > at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:819) > at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:609) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48) > at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125) > at org.jboss.forge.shell.ShellImpl$Proxy$_$$_WeldClientProxy.doShell(ShellImpl$Proxy$_$$_WeldClientProxy.java) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305) > at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54) > at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163) > at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299) > at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188) > at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59) > at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198) > at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282) > at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265) > at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234) > at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635) > at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622) > at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616) > at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:186) > at java.lang.Thread.run(Thread.java:745) > {noformat} > rebuilding the plugin does not help. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matej Briskar (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matej Briskar edited comment on ROASTER-13 at 5/14/14 9:37 AM: --------------------------------------------------------------- The return value check is done in the getMutator() method but not in the isMutator() method.. There probably is a reason, why isMutator() is checking if the method is generally a mutator but is not checking, if it is the mutator of the current property, on which the method was called. Therefore there are 2 options to resolve this issue: 1) Follow the approach and add the same check to getAccessor() method for the returning type. 2) Change both, isAccessor() and isMutator() to contain this check of the return type/parameter type. Following the 1) approach, it then doesn't make sense why the isMutator() method is defined in the PropertyImpl then, or does it? was (Author: mbriskar): The return value check is done in the getMutator() method but not in the isMutator() method.. There probably is a reason, why isMutator() is checking if the method is generally a mutator but is not checking, if it is the mutator of the current field, where the method was called. Therefore there are 2 options to resolve this issue: 1) Follow the approach and add the same check to getAccessor() method for the returning type. 2) Change both, isAccessor() and isMutator() to contain this check of the return type/parameter type. Following the 1) approach, it then doesn't make sense why the isMutator() method is defined in the PropertyImpl then, or does it? > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matej Briskar (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matej Briskar edited comment on ROASTER-13 at 5/14/14 9:37 AM: --------------------------------------------------------------- The return value check is done in the getMutator() method but not in the isMutator() method.. There probably is a reason, why isMutator() is checking if the method is generally a mutator but is not checking, if it is the mutator of the current field, where the method was called. Therefore there are 2 options to resolve this issue: 1) Follow the approach and add the same check to getAccessor() method for the returning type. 2) Change both, isAccessor() and isMutator() to contain this check of the return type/parameter type. Following the 1) approach, it then doesn't make sense why the isMutator() method is defined in the PropertyImpl then, or does it? was (Author: mbriskar): The return value check is done in the getMutator() method but not in isMutator() method.. There probably is a reason, why isMutator() is checking if the method is generally a mutator but is not checking, if it is the mutator of the current field, where the method was called. Therefore there are 2 options to resolve this issue: 1) Follow the approach and add the same check to getAccessor() method for the returning type. 2) Change both, isAccessor() and isMutator() to contain this check of the return type/parameter type. Following the 1) approach, it then doesn't make sense why the isMutator() method is defined in the PropertyImpl then, or does it? > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (ROASTER-13) PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods

by Matej Briskar (JIRA)

[ https://issues.jboss.org/browse/ROASTER-13?page=com.atlassian.jira.plugin... ] Matej Briskar commented on ROASTER-13: -------------------------------------- The return value check is done in the getMutator() method but not in isMutator() method.. There probably is a reason, why isMutator() is checking if the method is generally a mutator but is not checking, if it is the mutator of the current field, where the method was called. Therefore there are 2 options to resolve this issue: 1) Follow the approach and add the same check to getAccessor() method for the returning type. 2) Change both, isAccessor() and isMutator() to contain this check of the return type/parameter type. Following the 1) approach, it then doesn't make sense why the isMutator() method is defined in the PropertyImpl then, or does it? > PropertyImpl is not checking return type/parameter type in isAccessor() isMutator() methods > ------------------------------------------------------------------------------------------- > > Key: ROASTER-13 > URL: https://issues.jboss.org/browse/ROASTER-13 > Project: Roaster > Issue Type: Bug > Reporter: Matej Briskar > Assignee: Matej Briskar > -- This message was sent by Atlassian JIRA (v6.2.3#6260)

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues May 2014