[JBoss JIRA] (FORGE-2483) SLF4J jars are missing in database-tools
by George Gastaldi (JIRA)
George Gastaldi created FORGE-2483:
--------------------------------------
Summary: SLF4J jars are missing in database-tools
Key: FORGE-2483
URL: https://issues.jboss.org/browse/FORGE-2483
Project: Forge
Issue Type: Bug
Components: Database Tools
Affects Versions: 2.19.1.Final
Reporter: George Gastaldi
Assignee: George Gastaldi
Priority: Blocker
Fix For: 2.19.2.Final
Hibernate tools 4.3.1.Final depend directly on SLF4j APIs. The addon should also have the SLF4J API + JDK14 JARs bundled
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (ROASTER-26) Can't add comment in the method body
by Jeremie Bresson (JIRA)
[ https://issues.jboss.org/browse/ROASTER-26?page=com.atlassian.jira.plugin... ]
Jeremie Bresson commented on ROASTER-26:
----------------------------------------
If you do:
{code:java}
String stub = "public class Stub {\n //a comment\n public String method() {\n //a comment \n return \"Hello World!\"; \n } }";
JavaClassSource javaClassSource = Roaster.parse(JavaClassSource.class, stub);
System.out.println(javaClassSource.toString());
{code}
The comments are present...
My investigations show that the comment are not directly part of the AST. You can get them in the CompilationUnit:
{code:java}
unit.getCommentList();
{code}
And for each node:
{code:java}
unit.firstLeadingCommentIndex(ASTNode);
unit.lastTrailingCommentIndex(ASTNode);
{code}
In the setBody() use-case (code snippet in the issue), the comment are lost when the AST is copied (in org.jboss.forge.roaster.model.impl.MethodImpl.setBody(String)):
{code:java}
block = (Block) ASTNode.copySubtree(method.getAST(), block);
method.setBody(block);
{code}
I am not sure how this should be handled.
> Can't add comment in the method body
> ------------------------------------
>
> Key: ROASTER-26
> URL: https://issues.jboss.org/browse/ROASTER-26
> Project: Roaster
> Issue Type: Bug
> Components: JDT
> Affects Versions: 2.7.0.Final
> Reporter: Nicolas Challut
> Fix For: 2.x Future
>
>
> If you try to add a comment in a method body, the comment won't be print. Comment are detected like a miswritten code
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (FURNACE-78) Enable Jandex lookups
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FURNACE-78?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FURNACE-78.
----------------------------------
Resolution: Done
I've debugged and the JandexDiscoveryStrategy class is automatically called when the jandex jar is present in the classpath
> Enable Jandex lookups
> ---------------------
>
> Key: FURNACE-78
> URL: https://issues.jboss.org/browse/FURNACE-78
> Project: Forge: Furnace
> Issue Type: Enhancement
> Components: Container - CDI
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Fix For: 2.21.1.Final
>
>
> Weld can be configured to use Jandex index files for as a class discovery strategy.
> The jandex JAR needs to be present in the classpath for that to happen
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (FORGE-2481) Generate Jandex index files during packaging
by George Gastaldi (JIRA)
George Gastaldi created FORGE-2481:
--------------------------------------
Summary: Generate Jandex index files during packaging
Key: FORGE-2481
URL: https://issues.jboss.org/browse/FORGE-2481
Project: Forge
Issue Type: Task
Components: Forge Build
Affects Versions: 2.19.1.Final
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 2.19.2.Final
This should speed up performance of loading and discovery of classes in a JAR File.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (FURNACE-78) Enable Jandex lookups
by George Gastaldi (JIRA)
George Gastaldi created FURNACE-78:
--------------------------------------
Summary: Enable Jandex lookups
Key: FURNACE-78
URL: https://issues.jboss.org/browse/FURNACE-78
Project: Forge: Furnace
Issue Type: Enhancement
Components: Container - CDI
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 2.21.1.Final
Weld can be configured to use Jandex index files for as a class discovery strategy.
The jandex JAR needs to be present in the classpath for that to happen
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (ROASTER-54) Formatter doesn't apply on Javadoc
by Jeremie Bresson (JIRA)
[ https://issues.jboss.org/browse/ROASTER-54?page=com.atlassian.jira.plugin... ]
Jeremie Bresson commented on ROASTER-54:
----------------------------------------
I have proposed a pull request:
https://github.com/forge/roaster/pull/43
2 examples (implemented in the {{testFormatWithJavaDocOptions()}} unit-test):
With default options:
{code:java}
/**
* Class documentation text
*
* @author George Gastaldi
*/
public class SomeClass {
}
{code}
With these options:
* org.eclipse.jdt.core.formatter.comment.line_length=25
* org.eclipse.jdt.core.formatter.comment.new_lines_at_javadoc_boundaries=false
{code:java}
/** Class documentation
* text
*
* @author George
* Gastaldi */
public class SomeClass {
}
{code}
> Formatter doesn't apply on Javadoc
> ----------------------------------
>
> Key: ROASTER-54
> URL: https://issues.jboss.org/browse/ROASTER-54
> Project: Roaster
> Issue Type: Bug
> Components: Formatter
> Affects Versions: 2.11.1.Final
> Reporter: Nicolas Challut
> Fix For: 2.x Future
>
>
> Apparently, the formatter doesn't apply the format preferences on JavaDoc.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months