[JBoss JIRA] (FORGE-1033) Review the path spec for shell file and directory paths on Linux and Windows
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1033?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1033:
-------------------------------------------
Definitely a feature that will help prevent annoyances, though, and something we need to consider for impacts in Forge 2.
> Review the path spec for shell file and directory paths on Linux and Windows
> ----------------------------------------------------------------------------
>
> Key: FORGE-1033
> URL: https://issues.jboss.org/browse/FORGE-1033
> Project: Forge
> Issue Type: Task
> Components: UI - Shell
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Fix For: 2.x Future
>
>
> Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
> This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
> Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc. Autocompletion of inputs should ideally work in both of these cases.
> Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1033) Review the path spec for shell file and directory paths on Linux and Windows
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1033?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1033:
-------------------------------------------
I think that using "/" on all OS's would probably be plausible, but if we can get it to work for windows paths too, that would be ideal. Not sure how critical this is.
> Review the path spec for shell file and directory paths on Linux and Windows
> ----------------------------------------------------------------------------
>
> Key: FORGE-1033
> URL: https://issues.jboss.org/browse/FORGE-1033
> Project: Forge
> Issue Type: Task
> Components: UI - Shell
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Fix For: 2.x Future
>
>
> Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
> This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
> Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc. Autocompletion of inputs should ideally work in both of these cases.
> Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1031) Synchronize repository.yaml model with Forge's plugin installation model
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1031?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1031:
-------------------------------------------
I agree with this. I think that using the coordinates detected in the POM file, would probably be a more suitable alternative when installation occurs from a Git repository. This would keep the naming better in line with maven installation if/when that becomes viable again for Forge 1.
> Synchronize repository.yaml model with Forge's plugin installation model
> ------------------------------------------------------------------------
>
> Key: FORGE-1031
> URL: https://issues.jboss.org/browse/FORGE-1031
> Project: Forge
> Issue Type: Enhancement
> Components: Documentation
> Affects Versions: 1.3.3.Final
> Reporter: Lennart Jörelid
> Priority: Minor
> Fix For: 1.x Future
>
>
> The repository.yaml file holds a Maven GAV to each Forge Plugin.
> However, Forge's resolution only retrieves the latest/HEAD revision of a particular Git Branch, ignoring the Maven GAV given in the repository.yaml.
> Thus, one *must* release SNAPSHOT plugin versions in order to be able to bugfix Forge plugins. This is quite contrary to a normal Maven release, where SNAPSHOT versions are not permitted (for example by the release plugin).
> So ...
> # Forge only uses HEAD of a branch to find a plugin source code revision
> # Repository.yaml indicates that a particular Maven GAV for a project should be used for the plugin
> # During resolution, Forge ignores the Maven GAV in repository.yaml
> # Maven releases are normally not permitted to contain SNAPSHOTs, but the two facts above *requires* Forge plugins to be Maven SNAPSHOTs.
> It seems that two different (and not particularly coherent) models are used to define Forge's resolution here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1011) Forge Plugin Classloaders should find plugin depedencies (including Transitives)
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-1011?page=com.atlassian.jira.plugin... ]
Lincoln Baxter III commented on FORGE-1011:
-------------------------------------------
I think this solution *might* be adequate. As you mentioned on the forums, I would want to see how existing plugins behave when this change is made. It's possible it should be added as a forge.xml configuration if problems arise.
> Forge Plugin Classloaders should find plugin depedencies (including Transitives)
> ---------------------------------------------------------------------------------
>
> Key: FORGE-1011
> URL: https://issues.jboss.org/browse/FORGE-1011
> Project: Forge
> Issue Type: Bug
> Components: Builtin Plugins, Plugin API
> Affects Versions: 1.3.2.Final, 1.3.3.Final
> Reporter: Lennart Jörelid
>
> Can a sufficient solution imply that the NativeLibraryResourceLoader which handles the dependencies of the Forge Plugin have its pathFilter set to ACCEPT instead of REJECT? (Please refer to screenshot in the FORGE-980 issue).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1033) Review the path spec for shell file and directory paths on Linux and Windows
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1033?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1033:
-----------------------------------
Description:
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc. Autocompletion of inputs should ideally work in both of these cases.
Discuss.
was:
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc.
Discuss.
> Review the path spec for shell file and directory paths on Linux and Windows
> ----------------------------------------------------------------------------
>
> Key: FORGE-1033
> URL: https://issues.jboss.org/browse/FORGE-1033
> Project: Forge
> Issue Type: Task
> Components: UI - Shell
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Fix For: 2.x Future
>
>
> Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
> This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
> Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc. Autocompletion of inputs should ideally work in both of these cases.
> Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1033) Review the path spec for shell file and directory paths on Linux and Windows
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1033?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1033:
-----------------------------------
Description:
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc.
Discuss.
was:
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Additionally, escape sequences need to be determined, and whether paths need to be quoted to handle whitespaces etc.
Discuss.
> Review the path spec for shell file and directory paths on Linux and Windows
> ----------------------------------------------------------------------------
>
> Key: FORGE-1033
> URL: https://issues.jboss.org/browse/FORGE-1033
> Project: Forge
> Issue Type: Task
> Components: UI - Shell
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Fix For: 2.x Future
>
>
> Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
> This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
> Additionally, escape sequences need to be determined (for escaping whitespaces and other characters that can be interpreted differently by the shell), and whether paths need to be quoted to handle whitespaces etc.
> Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1033) Review the path spec for shell file and directory paths on Linux and Windows
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1033?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1033:
-----------------------------------
Description:
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Additionally, escape sequences need to be determined, and whether paths need to be quoted to handle whitespaces etc.
Discuss.
was:
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Discuss.
> Review the path spec for shell file and directory paths on Linux and Windows
> ----------------------------------------------------------------------------
>
> Key: FORGE-1033
> URL: https://issues.jboss.org/browse/FORGE-1033
> Project: Forge
> Issue Type: Task
> Components: UI - Shell
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Fix For: 2.x Future
>
>
> Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
> This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
> Additionally, escape sequences need to be determined, and whether paths need to be quoted to handle whitespaces etc.
> Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-93) AbstractResource.getFullyQualifiedName() returns wrong file path on Windows
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-93?page=com.atlassian.jira.plugin.s... ]
Vineet Reynolds closed FORGE-93.
--------------------------------
Assignee: Vineet Reynolds (was: Koen Aers)
Fix Version/s: 1.3.4.Final
(was: 1.x Future)
Resolution: Done
Pushed upstream https://github.com/forge/core/commit/93456f3bde6083c39579124214d12c66d510...
> AbstractResource.getFullyQualifiedName() returns wrong file path on Windows
> ---------------------------------------------------------------------------
>
> Key: FORGE-93
> URL: https://issues.jboss.org/browse/FORGE-93
> Project: Forge
> Issue Type: Bug
> Components: Resources API
> Affects Versions: 1.0.6.Final
> Reporter: Liu Jianhong
> Assignee: Vineet Reynolds
> Priority: Minor
> Fix For: 1.3.4.Final
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1,cd to C:\Users
> 2,Get path use AbstractResource.getFullyQualifiedName() and it returns /Users
> 3,Execute "cd /Users" produces error of "[cd] no such resources:Users"
> So,the following test failed:
> org.junit.ComparisonFailure: expected:</Users[/Administrator]> but was:</Users[]>
> at org.junit.Assert.assertEquals(Assert.java:123)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at org.jboss.forge.shell.test.plugins.builtin.ChangeDirectoryPluginTest.testAbsolutePath(ChangeDirectoryPluginTest.java:137)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> at org.jboss.arquillian.junit.Arquillian$6$1.invoke(Arquillian.java:251)
> at org.jboss.arquillian.protocol.local.LocalMethodExecutor.invoke(LocalMethodExecutor.java:40)
> at org.jboss.arquillian.impl.handler.ContainerTestExecuter.callback(ContainerTestExecuter.java:50)
> at org.jboss.arquillian.impl.handler.ContainerTestExecuter.callback(ContainerTestExecuter.java:40)
> at org.jboss.arquillian.impl.event.MapEventManager.fire(MapEventManager.java:63)
> at org.jboss.arquillian.impl.context.AbstractEventContext.fire(AbstractEventContext.java:115)
> at org.jboss.arquillian.impl.EventTestRunnerAdaptor.test(EventTestRunnerAdaptor.java:157)
> at org.jboss.arquillian.junit.Arquillian$6.evaluate(Arquillian.java:244)
> at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> at org.jboss.arquillian.junit.Arquillian$4.evaluate(Arquillian.java:207)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
> at org.jboss.arquillian.junit.Arquillian$5$1.evaluate(Arquillian.java:225)
> at org.jboss.arquillian.junit.Arquillian$MultiStatementExecutor.execute(Arquillian.java:297)
> at org.jboss.arquillian.junit.Arquillian$5.evaluate(Arquillian.java:221)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> at org.jboss.arquillian.junit.Arquillian$2.evaluate(Arquillian.java:163)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
> at org.jboss.arquillian.junit.Arquillian$3$1.evaluate(Arquillian.java:186)
> at org.jboss.arquillian.junit.Arquillian$MultiStatementExecutor.execute(Arquillian.java:297)
> at org.jboss.arquillian.junit.Arquillian$3.evaluate(Arquillian.java:182)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> at org.jboss.arquillian.junit.Arquillian.run(Arquillian.java:127)
> at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
> at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1033) Review the path spec for shell file and directory paths on Linux and Windows
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-1033:
--------------------------------------
Summary: Review the path spec for shell file and directory paths on Linux and Windows
Key: FORGE-1033
URL: https://issues.jboss.org/browse/FORGE-1033
Project: Forge
Issue Type: Task
Components: UI - Shell
Affects Versions: 1.3.3.Final
Reporter: Vineet Reynolds
Coming from the fix for FORGE-93, it is desirable to document the path specification for files and directories in both Linux (and Mac OS X), and Windows. In Linux, {{'/'}} is the only allowed separator, whereas in Windows, both {{'\'}} and {{'/'}} are allowed.
This obviously has an impact on the FSH script compatibility across these OSes. On the other hand, constraining the directory separator to {{'/'}} for Windows, to achieve commonality would probably work against usability as well as result in unusable paths in Windows.
Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months