[JBoss JIRA] (FORGE-1027) Update the Forge Java Parser
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-1027:
--------------------------------------
Summary: Update the Forge Java Parser
Key: FORGE-1027
URL: https://issues.jboss.org/browse/FORGE-1027
Project: Forge
Issue Type: Component Upgrade
Components: Forge Build
Affects Versions: 2.0.0.Alpha6, 1.3.3.Final
Reporter: Vineet Reynolds
An upgrade to the Java Parser is required, to ensure that the fix for FORGE-1026 is picked up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1002) Faces scaffold should treat properties lacking suitable converters differently
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1002?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1002:
-----------------------------------
Description:
This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2].
The {{Staff}} JPA entity generated using the Forge Hibernate Tools plugin, contains a {{byte[]}} property in the form of a {{picture}}. The property is rendered as a {{h:inputText}} widget in the create/edit screens and as a {{h:outputText}} widget in the view screen. This results in errors like the following being reported during operations in such screens: {{Conversion Error setting value '' for 'null Converter'.}}
Since a default converter cannot be applied, mostly due to the possibility of changing semantics of such properties across applications, it would be better to
* either omit such properties for functional scaffolds,
* or generate converters for every such type.
* or use more appropriate widgets (like a file upload widget) that can operate on such data types.
Also see the TicketMonster model, where a {{long[][]}} property is present in the {{SectionAllocation}} entity.
was:
This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2].
The {{Staff}} JPA entity generated using the Forge Hibernate Tools plugin, contains a {{byte[]}} property in the form of a {{picture}}. The property is rendered as a {{h:inputText}} widget in the create/edit screens and as a {{h:outputText}} widget in the view screen. This results in errors like the following being reported during operations in such screens: {{Conversion Error setting value '' for 'null Converter'.}}
Since a default converter cannot be applied, mostly due to the possibility of changing semantics of such properties across applications, it would be better to
* either omit such properties for functional scaffolds,
* or generate converters for every such type.
Also see the TicketMonster model, where a {{long[][]}} property is present in the {{SectionAllocation}} entity.
> Faces scaffold should treat properties lacking suitable converters differently
> ------------------------------------------------------------------------------
>
> Key: FORGE-1002
> URL: https://issues.jboss.org/browse/FORGE-1002
> Project: Forge
> Issue Type: Feature Request
> Components: Scaffold
> Affects Versions: 1.3.2.Final
> Reporter: Vineet Reynolds
>
> This is from the [Sakila-H2 model|https://github.com/maxandersen/sakila-h2].
> The {{Staff}} JPA entity generated using the Forge Hibernate Tools plugin, contains a {{byte[]}} property in the form of a {{picture}}. The property is rendered as a {{h:inputText}} widget in the create/edit screens and as a {{h:outputText}} widget in the view screen. This results in errors like the following being reported during operations in such screens: {{Conversion Error setting value '' for 'null Converter'.}}
> Since a default converter cannot be applied, mostly due to the possibility of changing semantics of such properties across applications, it would be better to
> * either omit such properties for functional scaffolds,
> * or generate converters for every such type.
> * or use more appropriate widgets (like a file upload widget) that can operate on such data types.
> Also see the TicketMonster model, where a {{long[][]}} property is present in the {{SectionAllocation}} entity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1026) JavaParser fails to identify types of ArrayType in method return types
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1026?page=com.atlassian.jira.plugin... ]
Vineet Reynolds updated FORGE-1026:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/java-parser/pull/6
The fix ensures that ArrayTypes are not converted into plain SimpleTypes when the method return type is parsed.
It should be noted for the future that is done via an ugly hack, and we should probably revisit the design of this section of the parser.
> JavaParser fails to identify types of ArrayType in method return types
> ----------------------------------------------------------------------
>
> Key: FORGE-1026
> URL: https://issues.jboss.org/browse/FORGE-1026
> Project: Forge
> Issue Type: Bug
> Components: Parsers / File Manipulation
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
>
> {{org.jboss.forge.parser.java.Method.getQualifiedReturnType()}} converts array types into simple types resulting in loss of information about the return type.
> This is due to Arrays being stripped away when {{org.jboss.forge.parser.java.impl.AbstractJavaSource.resolveType(String)}} is invoked. The type returned by {{AbstractJavaSource}} omits any information about the ArrayType in the provided argument, and this is not accounted for when returning the qualified type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1026) JavaParser fails to identify types of ArrayType in method return types
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-1026?page=com.atlassian.jira.plugin... ]
Vineet Reynolds reassigned FORGE-1026:
--------------------------------------
Assignee: Vineet Reynolds
> JavaParser fails to identify types of ArrayType in method return types
> ----------------------------------------------------------------------
>
> Key: FORGE-1026
> URL: https://issues.jboss.org/browse/FORGE-1026
> Project: Forge
> Issue Type: Bug
> Components: Parsers / File Manipulation
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
>
> {{org.jboss.forge.parser.java.Method.getQualifiedReturnType()}} converts array types into simple types resulting in loss of information about the return type.
> This is due to Arrays being stripped away when {{org.jboss.forge.parser.java.impl.AbstractJavaSource.resolveType(String)}} is invoked. The type returned by {{AbstractJavaSource}} omits any information about the ArrayType in the provided argument, and this is not accounted for when returning the qualified type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1026) JavaParser fails to identify types of ArrayType in method return types
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-1026:
--------------------------------------
Summary: JavaParser fails to identify types of ArrayType in method return types
Key: FORGE-1026
URL: https://issues.jboss.org/browse/FORGE-1026
Project: Forge
Issue Type: Bug
Components: Parsers / File Manipulation
Affects Versions: 1.3.3.Final
Reporter: Vineet Reynolds
{{org.jboss.forge.parser.java.Method.getQualifiedReturnType()}} converts array types into simple types resulting in loss of information about the return type.
This is due to Arrays being stripped away when {{org.jboss.forge.parser.java.impl.AbstractJavaSource.resolveType(String)}} is invoked. The type returned by {{AbstractJavaSource}} omits any information about the ArrayType in the provided argument, and this is not accounted for when returning the qualified type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-989) Support rollback of installed addons
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-989?page=com.atlassian.jira.plugin.... ]
George Gastaldi updated FORGE-989:
----------------------------------
Fix Version/s: 2.x Future
(was: 2.0.0.Alpha7)
> Support rollback of installed addons
> -------------------------------------
>
> Key: FORGE-989
> URL: https://issues.jboss.org/browse/FORGE-989
> Project: Forge
> Issue Type: Feature Request
> Components: Addon Manager
> Affects Versions: 2.0.0.Alpha6
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Priority: Critical
> Fix For: 2.x Future
>
>
> After an installation is performed, it should be possible to revert the repository to a previous state.
> It should be possible to log every install/remove request for each addon and group them by transaction savepoints.
> Eg:
> - Install Addon A which depends on B,C,D ( C and D already installed)
> Log:
> Transaction #1
> Addon A: INSTALLED
> Addon B: INSTALLED
> - Install Addon E which depends on A
> Log:
> Transaction #2
> Addon E: INSTALLED
> Rollback of each transaction should have the following behavior:
> - Rollback of Transaction #2 should remove Addon E.
> - Rollback of Transaction #1 should remove A, B.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-988) Refactor AddonManager to support addon version conflicts
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-988?page=com.atlassian.jira.plugin.... ]
Work on FORGE-988 stopped by George Gastaldi.
> Refactor AddonManager to support addon version conflicts
> --------------------------------------------------------
>
> Key: FORGE-988
> URL: https://issues.jboss.org/browse/FORGE-988
> Project: Forge
> Issue Type: Enhancement
> Components: Addon Manager
> Affects Versions: 2.0.0.Alpha6
> Reporter: George Gastaldi
> Assignee: George Gastaldi
> Priority: Critical
> Fix For: 2.0.0.Alpha7
>
>
> Given that Addons A(1.0), B (1.0), C(1.0) are installed in an AddonRepository, and C(1.0) depends on B(1.0), when an addon D(1.0) to be installed requires B(1.1), there should be a way to warn against incompatibilities and let the user decide what to do. Same when D(1.0) depends on B(2.0)
> Basically an addon version is composed of Major.Minor.Micro
> In relation to the installed addon version and the requested addon version the following rules should be followed:
> - When Major version is different, the addons are assumed be completely incompatible (even if in practice that is not true). Fail installation
> - When Minor version is different, compatibility may be assured only if the requested version is less or equal to the required version. Prompt for installation of necessary version.
> - When Micro version is different, the addon is totally compatible, thus no compatibility check is required. No problem to install
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months