[JBoss JIRA] (FORGE-974) Faces scaffolding does not correctly update collection members involved in bi-directional relationships when saving an edited entity
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-974?page=com.atlassian.jira.plugin.... ]
Vineet Reynolds updated FORGE-974:
----------------------------------
Priority: Critical (was: Major)
> Faces scaffolding does not correctly update collection members involved in bi-directional relationships when saving an edited entity
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-974
> URL: https://issues.jboss.org/browse/FORGE-974
> Project: Forge
> Issue Type: Bug
> Components: Scaffold
> Affects Versions: 1.3.1.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
> Priority: Critical
>
> The generated scaffold does not contain any logic to update collection properties of a JPA entity. This results in incorrect behavior when the collection is part of a bi-directional relationship in JPA.
> This is because no logic exists to remove both sides of the relationship when an entity instance is removed from the collection. The result of this absence in logic is that removal of entities from collection properties do not succeed. Upon save, the collection returns to it's previous state.
> Addition of members to the collection property are however performed correctly. Since the Faces scaffold does not allow updates to properties of the the individual members in the collection, no other issue is observed, except for the inability to update the collection state correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1017) A valid package name should be computed as default when prompting for a replacement in a JAVA_PACKAGE prompt
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-1017?page=com.atlassian.jira.plugin... ]
George Gastaldi updated FORGE-1017:
-----------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: 1.3.4.Final
Resolution: Done
Merged, thanks
> A valid package name should be computed as default when prompting for a replacement in a JAVA_PACKAGE prompt
> ------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-1017
> URL: https://issues.jboss.org/browse/FORGE-1017
> Project: Forge
> Issue Type: Enhancement
> Affects Versions: 1.3.3.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
> Fix For: 1.3.4.Final
>
>
> When an invalid package name is supplied as a value for an option whose {{PromptType}} is {{PromptType.JAVA_PACKAGE}}, then Forge prompt again for a valid value. No default is computed, and thus this is not friendly to scripts or to environments like the JBDS 7 Forge wizards where the shell is not accessible directly.
> An enhancement is thus sought to compute a valid default value for such cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-687) PromptType.JAVA_PACKAGE should support default package
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-687?page=com.atlassian.jira.plugin.... ]
George Gastaldi updated FORGE-687:
----------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: 1.3.4.Final
(was: 1.x Future)
Resolution: Done
Merged, thanks !
> PromptType.JAVA_PACKAGE should support default package
> ------------------------------------------------------
>
> Key: FORGE-687
> URL: https://issues.jboss.org/browse/FORGE-687
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell
> Affects Versions: 1.0.5.Final
> Reporter: Andre Dietisheim
> Assignee: Vineet Reynolds
> Fix For: 1.3.4.Final
>
>
> If you want to prompt the user to provide some valid java package you'd specify PromptType.JAVA_PACKAGE. Unfortunately this prompt type considers the empty string as invalid package even though I'd argue that this is the default package.
> If I ask the user for the package, scaffolded resources would get created to, I'd do:
> {code}
> prompt.promptCommon(target package: ", PromptType.JAVA_PACKAGE, project.getFacet(JavaSourceFacet.class).getBasePackageResource().toString())
> {code}
> If I have no valid packageResource (ex. forge would return an invalid base package) I'd want to suggest the user to put his sources into the default package (for a maven project: src/main/java). I'd then feed a "" as default to the prompt:
> {code}
> prompt.promptCommon(target package: ", PromptType.JAVA_PACKAGE, "")
> {code}
> Unfortunately the PromptType.JAVA_PACKAGE would not validate the empty string. It would tell me that this is not a valid package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months