[JBoss JIRA] (FORGE-803) Promote usage of ShrinkWrap Resolver instead of using Aether directly
by Lincoln Baxter III (JIRA)
[ https://issues.jboss.org/browse/FORGE-803?page=com.atlassian.jira.plugin.... ]
Lincoln Baxter III commented on FORGE-803:
------------------------------------------
What I think makes more sense is to create a ShrinkWrap addon for Forge 2. This would expose the relevant resolution services for those who need to use it in their Addons.
If people want to use ShrinkWrap resolver in tests, that would obviously depend on if it conflicts with our own Arquillian deployment mechanism, or of we can isolate it effectively enough to do so.
Currently there is not much need whatsoever for a feature like this, since tests are run against the Addon which is fully resolved by the forge container manager itself, so... not much point really in my opinion since all of the work is already done by Maven and the POM.
I suppose I could see an instance where someone would want to create a test deployment that used some resolved libraries, but again, I don't see that being a very common scenario since the tests more than mostly tend to rely directly on the actual addon under test.
> Promote usage of ShrinkWrap Resolver instead of using Aether directly
> ---------------------------------------------------------------------
>
> Key: FORGE-803
> URL: https://issues.jboss.org/browse/FORGE-803
> Project: Forge
> Issue Type: Enhancement
> Components: Build Tools - Maven
> Affects Versions: 2.0.0.Alpha1
> Reporter: George Gastaldi
>
> The MavenDependencyResolver should use ShrinkWrap Resolver APIs instead of using the Aether APIs directly.
> This is believed to bring some performance enhancements also, due to internal improvements in the latest version of SWR.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-1021) Support color schemes in the Forge Shell
by Vineet Reynolds (JIRA)
Vineet Reynolds created FORGE-1021:
--------------------------------------
Summary: Support color schemes in the Forge Shell
Key: FORGE-1021
URL: https://issues.jboss.org/browse/FORGE-1021
Project: Forge
Issue Type: Feature Request
Components: UI - Shell
Reporter: Vineet Reynolds
Priority: Minor
Fix For: 2.x Future
Based on FORGE-44, it would be good to have Shell color schemes so that the colors are consistent across OSes and operating environments. ANSI color codes are after all different across different OSes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-803) Promote usage of ShrinkWrap Resolver instead of using Aether directly
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-803?page=com.atlassian.jira.plugin.... ]
George Gastaldi commented on FORGE-803:
---------------------------------------
Andrew,
We closed this issue because ShrinkWrap Resolver is not being really used at the moment in Forge 2 and given it's an implementation detail, it may be reopened when all the maven dependency resolver features Forge 2 needs are implemented in ShrinkWrap Resolver.
> Promote usage of ShrinkWrap Resolver instead of using Aether directly
> ---------------------------------------------------------------------
>
> Key: FORGE-803
> URL: https://issues.jboss.org/browse/FORGE-803
> Project: Forge
> Issue Type: Enhancement
> Components: Build Tools - Maven
> Affects Versions: 2.0.0.Alpha1
> Reporter: George Gastaldi
>
> The MavenDependencyResolver should use ShrinkWrap Resolver APIs instead of using the Aether APIs directly.
> This is believed to bring some performance enhancements also, due to internal improvements in the latest version of SWR.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-44) Usage: dark blue on black background?
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-44?page=com.atlassian.jira.plugin.s... ]
Vineet Reynolds updated FORGE-44:
---------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: 1.3.4.Final
(was: 1.x Future)
Resolution: Done
Pushed upstream : https://github.com/forge/core/commit/792eedb263262dbc4a648ef2b0017313c316...
> Usage: dark blue on black background?
> -------------------------------------
>
> Key: FORGE-44
> URL: https://issues.jboss.org/browse/FORGE-44
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell, Windows
> Affects Versions: 1.0.0.Beta2
> Environment: Windows 7
> Reporter: Martin Dames
> Assignee: Vineet Reynolds
> Priority: Minor
> Labels: background, black, blue, cmd,, color,, dark,, shell,, windows,
> Fix For: 1.3.4.Final
>
>
> Hi,
> im trying Seam Forge 1.0.0Beta2 on my windows machine and it really makes no fun. I can rarely see the "holding" text and its driving me crazy... I tried to change the cmd shell background and text colors.. but besides this is not a task a normal user should do... this does not work.
> So, please change your colors a little bit more eye friendly! :)
> I would add a screenshot if I could....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-44) Usage: dark blue on black background?
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-44?page=com.atlassian.jira.plugin.s... ]
Vineet Reynolds updated FORGE-44:
---------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/forge/core/pull/335
Fixed by setting the intensity to bold if a non-embedded Windows Forge environment is detected.
> Usage: dark blue on black background?
> -------------------------------------
>
> Key: FORGE-44
> URL: https://issues.jboss.org/browse/FORGE-44
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell, Windows
> Affects Versions: 1.0.0.Beta2
> Environment: Windows 7
> Reporter: Martin Dames
> Assignee: Vineet Reynolds
> Priority: Minor
> Labels: background, black, blue, cmd,, color,, dark,, shell,, windows,
> Fix For: 1.x Future
>
>
> Hi,
> im trying Seam Forge 1.0.0Beta2 on my windows machine and it really makes no fun. I can rarely see the "holding" text and its driving me crazy... I tried to change the cmd shell background and text colors.. but besides this is not a task a normal user should do... this does not work.
> So, please change your colors a little bit more eye friendly! :)
> I would add a screenshot if I could....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-581) Scaffold source generation fails if project groupId not a valid package name
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-581?page=com.atlassian.jira.plugin.... ]
Vineet Reynolds closed FORGE-581.
---------------------------------
Fix Version/s: 1.1.2.Final
(was: 1.x Future)
Resolution: Done
Cannot reproduce, since it was most likely fixed in 1.1.2.Final by FORGE-686.
> Scaffold source generation fails if project groupId not a valid package name
> ----------------------------------------------------------------------------
>
> Key: FORGE-581
> URL: https://issues.jboss.org/browse/FORGE-581
> Project: Forge
> Issue Type: Bug
> Components: Builtin Plugins
> Affects Versions: 1.0.4.Final
> Reporter: Thomas Frühbeck
> Labels: HackNight
> Fix For: 1.1.2.Final
>
>
> MavenJavaSourceFacet too optimistic about naming of the artifact groupId.
> The automatically generated package name is syntactically unchecked:
> @Override
> public String getBasePackage()
> {
> return project.getFacet(MavenCoreFacet.class).getMavenProject().getGroupId();
> }
> .
> .
> [regress-pkg] regress-pkg $ scaffold from-entity at.tfr.regress.model.*
> ***INFO*** Using currently installed scaffold [faces]
> ***ERROR*** [scaffold from-entity] Error generating default scaffolding: null
> ???
> [regress-pkg] regress-pkg $ set VERBOSE true
> [regress-pkg] regress-pkg $ scaffold from-entity at.tfr.regress.model.*
> ***INFO*** Using currently installed scaffold [faces]
> ***ERROR*** [scaffold from-entity] Error generating default scaffolding: null
> org.jboss.forge.shell.exceptions.CommandExecutionException: Error generating default scaffolding: null
> at org.jboss.forge.shell.command.Execution.perform(Execution.java:154)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:125)
> at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:63)
> <SNIP>
> at java.lang.Thread.run(Thread.java:722)
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.jboss.forge.shell.command.Execution.perform(Execution.java:150)
> ... 31 more
> Caused by: java.lang.RuntimeException: Error generating default scaffolding: null
> at org.jboss.forge.scaffold.faces.FacesScaffold.generateFromEntity(FacesScaffold.java:341)
> at org.jboss.forge.scaffold.plugins.ScaffoldPlugin.generateFromEntity(ScaffoldPlugin.java:187)
> ... 36 more
> Caused by: java.lang.IllegalArgumentException
> at org.eclipse.jdt.core.dom.SimpleName.setIdentifier(SimpleName.java:190)
> at org.eclipse.jdt.core.dom.AST.newSimpleName(AST.java:1269)
> at org.eclipse.jdt.core.dom.AST.newName(AST.java:1389)
> at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:491)
> at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:65)
> at org.jboss.forge.scaffold.faces.FacesScaffold.generateFromEntity(FacesScaffold.java:275)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-44) Usage: dark blue on black background?
by Vineet Reynolds (JIRA)
[ https://issues.jboss.org/browse/FORGE-44?page=com.atlassian.jira.plugin.s... ]
Vineet Reynolds reassigned FORGE-44:
------------------------------------
Assignee: Vineet Reynolds
> Usage: dark blue on black background?
> -------------------------------------
>
> Key: FORGE-44
> URL: https://issues.jboss.org/browse/FORGE-44
> Project: Forge
> Issue Type: Bug
> Components: UI - Shell, Windows
> Affects Versions: 1.0.0.Beta2
> Environment: Windows 7
> Reporter: Martin Dames
> Assignee: Vineet Reynolds
> Priority: Minor
> Labels: background, black, blue, cmd,, color,, dark,, shell,, windows,
> Fix For: 1.x Future
>
>
> Hi,
> im trying Seam Forge 1.0.0Beta2 on my windows machine and it really makes no fun. I can rarely see the "holding" text and its driving me crazy... I tried to change the cmd shell background and text colors.. but besides this is not a task a normal user should do... this does not work.
> So, please change your colors a little bit more eye friendly! :)
> I would add a screenshot if I could....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-914) Rework the handling of 1:M relationships by the Faces/RichFaces scaffold
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/FORGE-914?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on FORGE-914:
-----------------------------------------------
Vineet Reynolds <vpereira(a)redhat.com> made a comment on [bug 977956|https://bugzilla.redhat.com/show_bug.cgi?id=977956]
Migrated to JIRA
> Rework the handling of 1:M relationships by the Faces/RichFaces scaffold
> ------------------------------------------------------------------------
>
> Key: FORGE-914
> URL: https://issues.jboss.org/browse/FORGE-914
> Project: Forge
> Issue Type: Bug
> Components: Scaffold
> Affects Versions: 1.0.5.Final, 1.3.0.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
> Priority: Critical
> Fix For: 1.x Future
>
>
> The generated Faces scaffold for 1:M relationships does not handle certain usability aspects.
> For example, a new row is automatically added by default when displaying a 1:M relationship upon create. However, unless the add button is clicked, the contents of the row are not added to the underlying managed bean. If the add button is not clicked, the contents of the row are not treated as a new item to be added. This is very confusing.
> Also, if bean validation is performed on the entities (in the rows of the 1:M relationship), and if it fails, then the contents need to be corrected, even though they may not be persisted in the database. Again, this is confusing behavior.
> Additionally, deletion of entities from the collection (1-side of the association) seems to be broken (FORGE-974).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months
[JBoss JIRA] (FORGE-974) Faces scaffolding does not correctly update collection members involved in bi-directional relationships when saving an edited entity
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/FORGE-974?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on FORGE-974:
-----------------------------------------------
Vineet Reynolds <vpereira(a)redhat.com> made a comment on [bug 978076|https://bugzilla.redhat.com/show_bug.cgi?id=978076]
Migrated to JIRA
> Faces scaffolding does not correctly update collection members involved in bi-directional relationships when saving an edited entity
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FORGE-974
> URL: https://issues.jboss.org/browse/FORGE-974
> Project: Forge
> Issue Type: Bug
> Components: Scaffold
> Affects Versions: 1.3.1.Final
> Reporter: Vineet Reynolds
> Assignee: Vineet Reynolds
> Priority: Critical
>
> The generated scaffold does not contain any logic to update collection properties of a JPA entity. This results in incorrect behavior when the collection is part of a bi-directional relationship in JPA.
> This is because no logic exists to remove both sides of the relationship when an entity instance is removed from the collection. The result of this absence in logic is that removal of entities from collection properties do not succeed. Upon save, the collection returns to it's previous state.
> Addition of members to the collection property are however performed correctly. Since the Faces scaffold does not allow updates to properties of the the individual members in the collection, no other issue is observed, except for the inability to update the collection state correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 8 months