July 2015 - forge-issues - Jboss List Archives

[JBoss JIRA] (FURNACE-63) PostStartup bug, or should be documented better

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FURNACE-63?page=com.atlassian.jira.plugin... ] George Gastaldi closed FURNACE-63. ---------------------------------- Fix Version/s: 2.20.2.Final (was: 2.x Future) Resolution: Done > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FURNACE-63 > URL: https://issues.jboss.org/browse/FURNACE-63 > Project: Forge: Furnace > Issue Type: Bug > Components: Runtime > Affects Versions: 2.20.1.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > Fix For: 2.20.2.Final > > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FURNACE-63) PostStartup bug, or should be documented better

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FURNACE-63?page=com.atlassian.jira.plugin... ] George Gastaldi commented on FURNACE-63: ---------------------------------------- Hm, that last sentence does not make sense in PostStartup because it´s suited for addons that depend on the furnace-cdi container only. > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FURNACE-63 > URL: https://issues.jboss.org/browse/FURNACE-63 > Project: Forge: Furnace > Issue Type: Bug > Components: Runtime > Affects Versions: 2.20.1.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > Fix For: 2.x Future > > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FURNACE-63) PostStartup bug, or should be documented better

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FURNACE-63?page=com.atlassian.jira.plugin... ] George Gastaldi updated FURNACE-63: ----------------------------------- Fix Version/s: 2.x Future > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FURNACE-63 > URL: https://issues.jboss.org/browse/FURNACE-63 > Project: Forge: Furnace > Issue Type: Bug > Components: Runtime > Affects Versions: 2.20.1.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > Fix For: 2.x Future > > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FURNACE-63) PostStartup bug, or should be documented better

by Jess Sightler (JIRA)

[ https://issues.jboss.org/browse/FURNACE-63?page=com.atlassian.jira.plugin... ] Jess Sightler commented on FURNACE-63: -------------------------------------- [~gastaldi] That looks good to me. > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FURNACE-63 > URL: https://issues.jboss.org/browse/FURNACE-63 > Project: Forge: Furnace > Issue Type: Bug > Components: Runtime > Affects Versions: 2.20.1.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > Fix For: 2.x Future > > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FURNACE-63) PostStartup bug, or should be documented better

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FURNACE-63?page=com.atlassian.jira.plugin... ] George Gastaldi moved FORGE-2408 to FURNACE-63: ----------------------------------------------- Project: Forge: Furnace (was: Forge) Key: FURNACE-63 (was: FORGE-2408) Affects Version/s: 2.20.1.Final (was: 2.16.2.Final) Component/s: Runtime (was: Furnace CDI) (was: Dependencies) > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FURNACE-63 > URL: https://issues.jboss.org/browse/FURNACE-63 > Project: Forge: Furnace > Issue Type: Bug > Components: Runtime > Affects Versions: 2.20.1.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ] George Gastaldi commented on FORGE-2408: ---------------------------------------- Yes, I agree that this sentence is ambiguous. How about: {code} This event is fired by the container to signal that a specific addon has started. To listen for startup of the addon where the observer is contained, observe this event with the {@link Local} qualifier {code} > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FORGE-2408 > URL: https://issues.jboss.org/browse/FORGE-2408 > Project: Forge > Issue Type: Bug > Components: Dependencies, Furnace CDI > Affects Versions: 2.20.1.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better

by Jess Sightler (JIRA)

[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ] Jess Sightler commented on FORGE-2408: -------------------------------------- I think this line from the javadoc for PostStartup should be revised: "Fired by the container to signal that the current addon should begin its work." It's ambiguous, IMO. What is the "current" addon? > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FORGE-2408 > URL: https://issues.jboss.org/browse/FORGE-2408 > Project: Forge > Issue Type: Bug > Components: Dependencies, Furnace CDI > Affects Versions: 2.16.2.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ] George Gastaldi commented on FORGE-2408: ---------------------------------------- Hi [~ozizka]. This is not a bug. If you want to listen for startup of your own addon, you should use the @Local qualifier. > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FORGE-2408 > URL: https://issues.jboss.org/browse/FORGE-2408 > Project: Forge > Issue Type: Bug > Components: Dependencies, Furnace CDI > Affects Versions: 2.16.2.Final > Reporter: Ondrej Zizka > Assignee: George Gastaldi > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better

by Ondrej Zizka (JIRA)

[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ] Ondrej Zizka edited comment on FORGE-2408 at 7/27/15 7:33 PM: -------------------------------------------------------------- I think it's a bug. There's no reason to call it many times. The addon is loaded just once. And if is not technically possible to have it fired and caught only for one addon, then it could use a qualifier defined in that addon, like, @Observes @MyAddonsQualifier PostStartup event was (Author: ozizka): I think it's a bug. There's no reason to call it many times. The addon is loaded just once. And if is not technically possible to have it fired and catched only for one addon, then it could use a qualifier defined in that addon, like, @Observes @MyAddonsQualifier PostStartup event > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FORGE-2408 > URL: https://issues.jboss.org/browse/FORGE-2408 > Project: Forge > Issue Type: Bug > Components: Dependencies, Furnace CDI > Affects Versions: 2.16.2.Final > Reporter: Ondrej Zizka > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better

by Ondrej Zizka (JIRA)

[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ] Ondrej Zizka reassigned FORGE-2408: ----------------------------------- Assignee: Ondrej Zizka > PostStartup bug, or should be documented better > ----------------------------------------------- > > Key: FORGE-2408 > URL: https://issues.jboss.org/browse/FORGE-2408 > Project: Forge > Issue Type: Bug > Components: Dependencies, Furnace CDI > Affects Versions: 2.16.2.Final > Reporter: Ondrej Zizka > Assignee: Ondrej Zizka > > STR: > Check out the 1a89b1c commit from > https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3... > And run the WindupUpdateRulesetTest. > That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered". > I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup? > Or if not, then please specify better when this is called and what is the state of the addons. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

10 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

forge-issues July 2015