[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ]
Ondrej Zizka reassigned FORGE-2408:
-----------------------------------
Assignee: George Gastaldi (was: Ondrej Zizka)
> PostStartup bug, or should be documented better
> -----------------------------------------------
>
> Key: FORGE-2408
> URL: https://issues.jboss.org/browse/FORGE-2408
> Project: Forge
> Issue Type: Bug
> Components: Dependencies, Furnace CDI
> Affects Versions: 2.16.2.Final
> Reporter: Ondrej Zizka
> Assignee: George Gastaldi
>
> STR:
> Check out the 1a89b1c commit from
> https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3...
> And run the WindupUpdateRulesetTest.
> That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered".
> I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup?
> Or if not, then please specify better when this is called and what is the state of the addons.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months
[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ]
Ondrej Zizka edited comment on FORGE-2408 at 7/27/15 7:32 PM:
--------------------------------------------------------------
I think it's a bug. There's no reason to call it many times. The addon is loaded just once.
And if is not technically possible to have it fired and catched only for one addon, then it could use a qualifier defined in that addon, like, @Observes @MyAddonsQualifier PostStartup event
was (Author: ozizka):
I think it's a bug. There's no reason to call it many times. The addon is loaded just once.
And if it should check for other addons then it should use qualifiers or something, or other event.
> PostStartup bug, or should be documented better
> -----------------------------------------------
>
> Key: FORGE-2408
> URL: https://issues.jboss.org/browse/FORGE-2408
> Project: Forge
> Issue Type: Bug
> Components: Dependencies, Furnace CDI
> Affects Versions: 2.16.2.Final
> Reporter: Ondrej Zizka
>
> STR:
> Check out the 1a89b1c commit from
> https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3...
> And run the WindupUpdateRulesetTest.
> That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered".
> I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup?
> Or if not, then please specify better when this is called and what is the state of the addons.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months
[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ]
Ondrej Zizka commented on FORGE-2408:
-------------------------------------
I think it's a bug. There's no reason to call it many times. The addon is loaded just once.
And if it should check for other addons then it should use qualifiers or something, or other event.
> PostStartup bug, or should be documented better
> -----------------------------------------------
>
> Key: FORGE-2408
> URL: https://issues.jboss.org/browse/FORGE-2408
> Project: Forge
> Issue Type: Bug
> Components: Dependencies, Furnace CDI
> Affects Versions: 2.16.2.Final
> Reporter: Ondrej Zizka
>
> STR:
> Check out the 1a89b1c commit from
> https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3...
> And run the WindupUpdateRulesetTest.
> That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered".
> I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup?
> Or if not, then please specify better when this is called and what is the state of the addons.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months
[JBoss JIRA] (FORGE-2408) PostStartup bug, or should be documented better
by Ondrej Zizka (JIRA)
[ https://issues.jboss.org/browse/FORGE-2408?page=com.atlassian.jira.plugin... ]
Ondrej Zizka updated FORGE-2408:
--------------------------------
Summary: PostStartup bug, or should be documented better (was: PostStartup should be documented better)
> PostStartup bug, or should be documented better
> -----------------------------------------------
>
> Key: FORGE-2408
> URL: https://issues.jboss.org/browse/FORGE-2408
> Project: Forge
> Issue Type: Bug
> Components: Dependencies, Furnace CDI
> Affects Versions: 2.16.2.Final
> Reporter: Ondrej Zizka
>
> STR:
> Check out the 1a89b1c commit from
> https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3...
> And run the WindupUpdateRulesetTest.
> That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered".
> I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup?
> Or if not, then please specify better when this is called and what is the state of the addons.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months
[JBoss JIRA] (FORGE-2408) PostStartup should be documented better
by Ondrej Zizka (JIRA)
Ondrej Zizka created FORGE-2408:
-----------------------------------
Summary: PostStartup should be documented better
Key: FORGE-2408
URL: https://issues.jboss.org/browse/FORGE-2408
Project: Forge
Issue Type: Bug
Components: Dependencies, Furnace CDI
Affects Versions: 2.16.2.Final
Reporter: Ondrej Zizka
STR:
Check out the 1a89b1c commit from
https://github.com/OndraZizka/windup/commit/1a89b1cac3f76e519571fd08c0cf3...
And run the WindupUpdateRulesetTest.
That will fail in RulesetUpdateChecker, because the PostStartup is fired for all (?) addons, even those which do not depend on windup-exec, and therefore the @Inject fails with "IllegalStateException: Addon service [...RulesetUpdater] is not registered".
I am not quite sure if that's how it should behave. Shouldn't it be called for the "current addon" as stated in the javadoc of PostStartup?
Or if not, then please specify better when this is called and what is the state of the addons.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months
[JBoss JIRA] (FORGE-2071) Command java-new-package-info to create a new package-info.java class
by George Gastaldi (JIRA)
[ https://issues.jboss.org/browse/FORGE-2071?page=com.atlassian.jira.plugin... ]
George Gastaldi closed FORGE-2071.
----------------------------------
Fix Version/s: (was: 2.x Future)
Resolution: Won't Fix
FORGE-2407 already creates it
> Command java-new-package-info to create a new package-info.java class
> ---------------------------------------------------------------------
>
> Key: FORGE-2071
> URL: https://issues.jboss.org/browse/FORGE-2071
> Project: Forge
> Issue Type: Sub-task
> Components: Parsers / File Manipulation
> Affects Versions: 2.12.0.Final
> Reporter: Antonio Goncalves
>
> It would be good to have a command to create a {{package-info.java}} class. The command would just have a mandatory {{targetPackage}} attribute (no named). So something like that :
> {code}
> java-new-package-info --targetPackage foo.bar
> {code}
> Will create a the class under {{foo.bar.package-info.java}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months
[JBoss JIRA] (FORGE-2407) Command java-new-package to create new java packages
by George Gastaldi (JIRA)
George Gastaldi created FORGE-2407:
--------------------------------------
Summary: Command java-new-package to create new java packages
Key: FORGE-2407
URL: https://issues.jboss.org/browse/FORGE-2407
Project: Forge
Issue Type: Feature Request
Components: Parsers / File Manipulation
Affects Versions: 2.17.0.Final
Reporter: George Gastaldi
Assignee: George Gastaldi
Fix For: 2.17.1.Final
Although {{mkdir}} creates a package, it would be nice to have a command like:
{code}
java-new-package --named com.mynewpackage --createPackageInfo
{code}
Will create a new package with a {{package-info.java}} inside.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 8 months