[forge-issues] [JBoss JIRA] (FORGE-2067) The java-new-field generates getters/setters even if --generateGetter and --generateSetter are set to false
[
https://issues.jboss.org/browse/FORGE-2067?page=com.atlassian.jira.plugin...
]
Antonio Goncalves commented on FORGE-2067:
------------------------------------------
In {{org.jboss.forge.addon.parser.java.ui.JavaFieldCommandImpl}} you have the following :
{code}
@Inject
@WithAttributes(label = "Generate Getter", description = "Generate
accessor method", defaultValue = "true")
private UIInput<Boolean> generateGetter;
@Inject
@WithAttributes(label = "Generate Setter", description = "Generate
mutator method", defaultValue = "true")
private UIInput<Boolean> generateSetter;
{code}
So the default value is {{true}}, which makes sense (by default you want getters/setters
on your field). If we want the command to be intuitive (i.e. behaves like the other CLI
commands), then we need something like that
{code}
java-new-field --named field4 --generateGetter false
{code}
The java-new-field generates getters/setters even if --generateGetter
and --generateSetter are set to false
-----------------------------------------------------------------------------------------------------------
Key: FORGE-2067
URL: https://issues.jboss.org/browse/FORGE-2067
Project: Forge
Issue Type: Bug
Components: UI - Shell
Affects Versions: 2.12.0.Final
Reporter: Antonio Goncalves
Assignee: Ståle Pedersen
Fix For: 2.x Future
No matter if you set {{generateGetter}} or {{generateSetter}} to true or false, get/set
are always generated. The following commands generate get/set (which is normal) :
{code}
java-new-class --named DatabaseProducer ;
java-new-field --named em --type javax.persistence.EntityManager ;
{code}
But the following command should not generate get/set :
{code}
java-new-class --named DatabaseProducer ;
java-new-field --named em --type javax.persistence.EntityManager --generateGetter false
--generateSetter false ;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)