[ https://issues.jboss.org/browse/FORGE-398?page=com.atlassian.jira.plugin.... ] Richard Kennard updated FORGE-398: ---------------------------------- Description: This is one of those 'we could do it a different way, but it would make the generated code cleaner if...' requests :) At present the PersistencePlugin generates: @OneToOne private Profile profile; public Profile getProfile() { return this.profile; } public void setProfile(final Profile profile) { this.profile = profile; } I would instead like it to generate: @OneToOne(cascade = CascadeType.ALL) private Profile profile; public Profile getProfile() { return this.profile; } public void setProfile(final Profile profile) { this.profile = profile; } was: This is one of those 'we could do it a different way, but it would make the generated code cleaner if...' requests :) At present the PersistencePlugin generates: private @OneToMany(mappedBy = "customer") Set<SubmittedOrder> orders = new HashSet<SubmittedOrder>(); public Set getOrders() { return this.orders; } public void setOrders(final Set orders) { this.orders = orders; } @OneToOne private Profile profile; public Profile getProfile() { return this.profile; } public void setProfile(final Profile profile) { this.profile = profile; } I would instead like it to generate: private @OneToMany(cascade = CascadeType.ALL) Set<SubmittedOrder> orders = new HashSet<SubmittedOrder>(); public Set getOrders() { return this.orders; } public void setOrders(final Set orders) { this.orders = orders; } @OneToOne(cascade = CascadeType.ALL) private Profile profile; public Profile getProfile() { return this.profile; } public void setProfile(final Profile profile) { this.profile = profile; } So I am asking for: 1. Add CascadeType.ALL to @OneToMany and @OneToOne 2. Remove the 'mappedBy' from @OneToMany. I think this is a mistake, because it is saying this is an inverse relationship? I don't think it should be considered inverse. If 'mappedBy' is there, Cascade will have no effect -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-398?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III commented on FORGE-398: ------------------------------------------ Update. Only needed on on owning side of @OneToOne relationships, but do we need this in other places as well? Why does @ManyToMany not need this on both sides of the relationship? How do we know which side to put it on? Both sides maybe? It's possible that the UI scaffolding may need to update the entity manually for its own needs, instead of doing this in the EntityPlugin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-398?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III commented on FORGE-398: ------------------------------------------ We can address this in the Scaffold itself, which I think is more appropriate: {code} private void createInitializers(final JavaClass entity) { for (Field<JavaClass> field : entity.getFields()) { if (field.hasAnnotation(OneToOne.class)) { Annotation<JavaClass> oneToOne = field.getAnnotation(OneToOne.class); if (oneToOne.getStringValue("mappedBy") == null) { oneToOne.setEnumValue("cascade", CascadeType.ALL); } String methodName = "new" + field.getTypeInspector().getName(); if (!entity.hasMethodSignature(methodName)) { entity.addMethod().setName(methodName).setReturnTypeVoid().setPublic() .setBody("this." + field.getName() + " = new " + field.getType() + "();"); } } }{code} Working on this now. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-398?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III closed FORGE-398. ------------------------------------ Assignee: Lincoln Baxter III Fix Version/s: 1.0.0.Beta4 Resolution: Done Implemented in FacesScaffold since we should not assume that all entities will have this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-398?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III commented on FORGE-398: ------------------------------------------ Hey Richard, You want Cascade added on the @One side of the relationship, yes? ~Lincoln -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/FORGE-398?page=com.atlassian.jira.plugin.... ] Lincoln Baxter III closed FORGE-398. ------------------------------------ Fix Version/s: 1.0.0.CR1 Resolution: Done Done. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira