[JBoss JIRA] (GTNPORTAL-2852) Clean up and improve the usage of Resource Bundle files
by Trong Tran (JIRA)
Trong Tran created GTNPORTAL-2852:
-------------------------------------
Summary: Clean up and improve the usage of Resource Bundle files
Key: GTNPORTAL-2852
URL: https://issues.jboss.org/browse/GTNPORTAL-2852
Project: GateIn Portal
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Internationalization and Localization
Affects Versions: 3.5.0.Final
Reporter: Trong Tran
Fix For: 3.6.0.Final
Basically, there are two things :
1. Remove ant configuration in the root POM which copies all *_en.properties to the base ones (webui_en.properties to webui.properties for instance). The copy is not efficient and not a clean way to maintain resource bundle files. Then we just need to keep the base properties file only, the default English language properties should be loaded fallback by the base one normally.
2. Move resource bundle files from src/main/webapp/WEB-INF/classes to src/main/resources. It is more compliant to Maven standard structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (GTNPORTAL-2770) Bug JS: happens when js file in module contains tab charecter at header
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2770?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-2770:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 3.6.0.Final
Resolution: Done
> Bug JS: happens when js file in module contains tab charecter at header
> -----------------------------------------------------------------------
>
> Key: GTNPORTAL-2770
> URL: https://issues.jboss.org/browse/GTNPORTAL-2770
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Pham Duy Dong
> Assignee: Vu Viet Phuong
> Priority: Minor
> Fix For: 3.6.0.Final
>
>
> - Declare a js (ex: abc.js) file in gatein-resources.xml
> {code:xml}
> ...
> <module>
> <name>moduleName</name>
> <script>
> <path>/javascript/webui/abc.js</path>
> </script>
> </module>
> ...
> {code}
> - Require it in groovy template file
> - In a javascript file (ex: abc.js):
> If comment at top file contains tab character(\t) at begining line, js bug happens
> After remove tab, bug js also not happens anymore
> -- js file with tab at header
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
> -- js file after remove tab
> {code:title=abc.js|borderStyle=solid}
> /**
> * Some comments...
> */
> (function(gj) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (GTNPORTAL-2790) Potential NPE with Tomcat 7 in developing mode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2790?page=com.atlassian.jira.pl... ]
Trong Tran resolved GTNPORTAL-2790.
-----------------------------------
Fix Version/s: 3.6.0.Final
Resolution: Done
> Potential NPE with Tomcat 7 in developing mode
> ----------------------------------------------
>
> Key: GTNPORTAL-2790
> URL: https://issues.jboss.org/browse/GTNPORTAL-2790
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Hai Nguyen
> Assignee: Hai Nguyen
> Fix For: 3.6.0.Final
>
> Attachments: portal.xml
>
>
> In tomcat 7, the wars does not locate at "appBase" which is not unpacked.
> https://issues.apache.org/bugzilla/show_bug.cgi?id=51294
> But in ServletResourceResolver.isModified, we used ServletContext.getRealPath to get absolute path's file resource which will return NULL. Due to the WAR was not upacked.
> We should use URLConnection.getLastModified instead of use getRealPath and File api
> Step to reproduce:
> - Set upackWARs="false" in Host in conf/server.xml
> - Start bin/gatein-dev.sh run
> And go to home page, the NPE occurs:
> java.lang.NullPointerException
> at java.io.File.<init>(File.java:222)
> at org.exoplatform.resolver.ServletResourceResolver.isModified(ServletResourceResolver.java:77)
> at org.exoplatform.webui.core.lifecycle.Lifecycle.renderTemplate(Lifecycle.java:106)
> at org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processRender(UIPortalApplicationLifecycle.java:124)
> ...............
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months