[JBoss JIRA] (GTNPORTAL-2859) Remove PortalClusteredSSOSupportValve from Tomcat7 packaging
by Marek Posolda (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2859?page=com.atlassian.jira.pl... ]
Marek Posolda commented on GTNPORTAL-2859:
------------------------------------------
Fix is in branch https://github.com/mposolda/gatein-portal/tree/sso-valve . Will send PR once it will be confirmed that it fixes the issue with Spring web application.
> Remove PortalClusteredSSOSupportValve from Tomcat7 packaging
> ------------------------------------------------------------
>
> Key: GTNPORTAL-2859
> URL: https://issues.jboss.org/browse/GTNPORTAL-2859
> Project: GateIn Portal
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Final
> Reporter: Marek Posolda
> Assignee: Marek Posolda
> Fix For: 3.6.0.Final
>
>
> There is issue with PortalClusteredSSOSupportValve on Tomcat7. When the class is loaded, you will see the exception:
> {code}
> java.lang.VerifyError: class org.exoplatform.web.login.PortalClusteredSSOSupportValve overrides final method start.()V
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:791)
> at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:423)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1665)
> {code}
> It's caused by API inconsistency between JBoss AS7 and Tomcat7. Normally PortalClusteredSSOSupportValve is not loaded, but it could be loaded when deploying some spring applications on Tomcat7.
> Resolution will be to remove this class from Tomcat packaging and have it only in JBoss AS7 packaging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (GTNPORTAL-2859) Remove PortalClusteredSSOSupportValve from Tomcat7 packaging
by Marek Posolda (JIRA)
Marek Posolda created GTNPORTAL-2859:
----------------------------------------
Summary: Remove PortalClusteredSSOSupportValve from Tomcat7 packaging
Key: GTNPORTAL-2859
URL: https://issues.jboss.org/browse/GTNPORTAL-2859
Project: GateIn Portal
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Affects Versions: 3.5.0.Final
Reporter: Marek Posolda
Assignee: Marek Posolda
Fix For: 3.6.0.Final
There is issue with PortalClusteredSSOSupportValve on Tomcat7. When the class is loaded, you will see the exception:
{code}
java.lang.VerifyError: class org.exoplatform.web.login.PortalClusteredSSOSupportValve overrides final method start.()V
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:791)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:423)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1665)
{code}
It's caused by API inconsistency between JBoss AS7 and Tomcat7. Normally PortalClusteredSSOSupportValve is not loaded, but it could be loaded when deploying some spring applications on Tomcat7.
Resolution will be to remove this class from Tomcat packaging and have it only in JBoss AS7 packaging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (GTNPORTAL-2852) Clean up and improve bundle loading process
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2852?page=com.atlassian.jira.pl... ]
Trong Tran resolved GTNPORTAL-2852.
-----------------------------------
Assignee: Trong Tran
Resolution: Done
> Clean up and improve bundle loading process
> -------------------------------------------
>
> Key: GTNPORTAL-2852
> URL: https://issues.jboss.org/browse/GTNPORTAL-2852
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Internationalization and Localization
> Affects Versions: 3.5.0.Final
> Reporter: Trong Tran
> Assignee: Trong Tran
> Fix For: 3.6.0.Final
>
>
> Basically, there are two things :
> 1. Remove ant configuration in the root POM which copies all *_en.properties to the base ones (webui_en.properties to webui.properties for instance). The copy is not efficient and not a clean way to maintain resource bundle files. What we need is just to keep the base properties file only, the default English language properties should be loaded fallback by the base one normally.
> 2. Move resource bundle files from src/main/webapp/WEB-INF/classes to src/main/resources. It is more compliant to Maven standard structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (GTNPORTAL-2852) Clean up and improve bundle loading process
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2852?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-2852:
----------------------------------
Summary: Clean up and improve bundle loading process (was: Clean up and improve the usage of Resource Bundle files)
> Clean up and improve bundle loading process
> -------------------------------------------
>
> Key: GTNPORTAL-2852
> URL: https://issues.jboss.org/browse/GTNPORTAL-2852
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Internationalization and Localization
> Affects Versions: 3.5.0.Final
> Reporter: Trong Tran
> Fix For: 3.6.0.Final
>
>
> Basically, there are two things :
> 1. Remove ant configuration in the root POM which copies all *_en.properties to the base ones (webui_en.properties to webui.properties for instance). The copy is not efficient and not a clean way to maintain resource bundle files. What we need is just to keep the base properties file only, the default English language properties should be loaded fallback by the base one normally.
> 2. Move resource bundle files from src/main/webapp/WEB-INF/classes to src/main/resources. It is more compliant to Maven standard structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (GTNPORTAL-2852) Clean up and improve the usage of Resource Bundle files
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2852?page=com.atlassian.jira.pl... ]
Trong Tran commented on GTNPORTAL-2852:
---------------------------------------
we also find that default locale of JVM is being used in the portlet bundle loading process. It should consistently use the default one of Portal.
> Clean up and improve the usage of Resource Bundle files
> -------------------------------------------------------
>
> Key: GTNPORTAL-2852
> URL: https://issues.jboss.org/browse/GTNPORTAL-2852
> Project: GateIn Portal
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Internationalization and Localization
> Affects Versions: 3.5.0.Final
> Reporter: Trong Tran
> Fix For: 3.6.0.Final
>
>
> Basically, there are two things :
> 1. Remove ant configuration in the root POM which copies all *_en.properties to the base ones (webui_en.properties to webui.properties for instance). The copy is not efficient and not a clean way to maintain resource bundle files. What we need is just to keep the base properties file only, the default English language properties should be loaded fallback by the base one normally.
> 2. Move resource bundle files from src/main/webapp/WEB-INF/classes to src/main/resources. It is more compliant to Maven standard structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months