[JBoss JIRA] (GTNPORTAL-2899) The membership type "*" is not interpreted
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2899?page=com.atlassian.jira.pl... ]
Work on GTNPORTAL-2899 started by Trong Tran.
> The membership type "*" is not interpreted
> -------------------------------------------
>
> Key: GTNPORTAL-2899
> URL: https://issues.jboss.org/browse/GTNPORTAL-2899
> Project: GateIn Portal
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.3.Final
> Environment: eXo Platform 4.0.0-Beta2
> Reporter: Hela Zekri
> Assignee: Trong Tran
> Priority: Blocker
> Labels: portal-s71, worked
> Fix For: 3.7.0.Final
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> {color:red}
> In eXo Platform, we have the membership type "*". If user has this membership type in a group, it means that he has all membership types in this group.
> {color}
> *Please try this scenario :*
> Add a user that has the membership type "manager" in "/platform/administrators" group and the membership type "*" in "/platform/users" group.
> When this user clicks "add page" in "Page Management", he has the possibility to choose the owner type "group" or "portal". If he chooses "group", the expected output is that he gets as "Owner Id", a selectbox that contains all groups in which he has the membership type "manager".
> (!) The membership type "manager" is set in "portal-configuration.xml" as value-param to UserACL component :
> {code:xml}
> <value-param>
> <name>navigation.creator.membership.type</name>
> <description>specific membership type have full permission with group navigation</description>
> <value>manager</value>
> </value-param>
> {code}
> In this case, user should get as "Owner Id" a selectbox that contains "/platform/administrators" and "/platform/users" groups(The membership type "*" includes "manager" membership type).
> But the current behavior is that the selectbox of "Owner Id" contains only the group "/platform/administator". This is due to the fact that the relationship "*" is considered as a String and not interpreted.
> *There are two possible solutions to this problem :*
> 1- Set the possibility to put many values for "navigation.creator.membership.type" value-param. So that we could do for example :
> {code:xml}
> <value-param>
> <name>navigation.creator.membership.type</name>
> <description>specific membership type have full permission with group navigation</description>
> <value>*,manager</value>
> </value-param>
> {code}
> 2- In "_findRoles_" method in "_org.picketlink.idm.impl.api.session.managers.RoleManagerImpl_" class :
> In the code bellow, each relationship of a user is compared to roleType ("manager"). If it is equal, it will be added to the list that will be returned. So even "*" is compared to "manager", it is not equal, so it won't be added.
> {code}
> for (IdentityObjectRelationship relationship : relationships)
> {
> if (roleType != null)
> {
> if (roleType.getName().equals(relationship.getName()))
> {
> roles.add(new SimpleRole(new SimpleRoleType(relationship.getName()), createUser(relationship.getToIdentityObject()), createGroup(relationship.getFromIdentityObject())));
> }
> }
> else
> {
> roles.add(new SimpleRole(new SimpleRoleType(relationship.getName()), createUser(relationship.getToIdentityObject()), createGroup(relationship.getFromIdentityObject())));
> }
> }
> {code}
> We created [https://issues.jboss.org/browse/PLIDM-40] in which we propose a patch that adds a test on "*" value.
> In the patch, we changed :
> {code}
> if (roleType.getName().equals(relationship.getName()))
> {code}
> to :
> {code}
> if ((roleType.getName().equals(relationship.getName())) || relationship.getName().equals("*"))
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months
[JBoss JIRA] (GTNPORTAL-3044) Inconsistency in html elements of shared layout/user bar portlets
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3044?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-3044:
----------------------------------
Sprint: Sprint 77, Sprint 78, Sprint 79 (was: Sprint 77, Sprint 78, Sprint 79, Sprint 81)
> Inconsistency in html elements of shared layout/user bar portlets
> -----------------------------------------------------------------
>
> Key: GTNPORTAL-3044
> URL: https://issues.jboss.org/browse/GTNPORTAL-3044
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.6.0.Beta02
> Environment: jboss-jpp-6.1.0.ER1-prod-17052013.zip
> Reporter: Vlastislav Ramik
> Assignee: Tuyen Nguyen The
> Labels: JPP61-Test-dev
> Fix For: 3.7.0.Final
>
> Original Estimate: 6 hours
> Time Spent: 1 day
> Remaining Estimate: 0 minutes
>
> Shared layout/user bar portlets (ie the bar that appears at the top of the page when you are a logged-in user) has following inconsistency:
> Portal Actions (that with the redhat icon): {noformat}<li title="Portal Actions" style="width: 62px" class="UITab portlet-menu-item">{noformat} The is also empty link as a child of the <li> but it has zero length.
> Site: {noformat}<a title="Sites" class="SitesIcon TBIcon" href="javascript:;">Site</a>{noformat}
> Group: {noformat}<span title="Group" class="GroupIcon TBIcon">Group</span>{noformat}
> Dashboard: If the user does not have any dashboard pages there is a link. If the user has a dashboard page there is a span. This is correct in my opinion.
> Site/Group/Dashboard Editor: {noformat}<a title="Site/Group/Dashboard Editor" href="#" class="EditorIcon TBIcon">Site/Group/Dashboard Editor</a>{noformat}
> All this leads to different looking cursors when you hovering the portlet.
> Portal Actions: arrow cursor
> Site: link cursor and text is highlighted
> Group:
> - arrow cursor when you are hovering that "people" icon
> - text cursor when you are hovering Group text
> Dashboard:
> - in case of none dashboard pages - it behaves the same as Site
> - in case on any dashboard pages - it behaves the same as Group
> Site/Group/Dashboard Editor: link cursor and text is highlighted
> The solution can be using css cursor (e.g. cursor: pointer; ) but cleaner solution would be probably unify it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months
[JBoss JIRA] (GTNPORTAL-2899) The membership type "*" is not interpreted
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2899?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-2899:
----------------------------------
Original Estimate: 4 hours
Remaining Estimate: 4 hours
> The membership type "*" is not interpreted
> -------------------------------------------
>
> Key: GTNPORTAL-2899
> URL: https://issues.jboss.org/browse/GTNPORTAL-2899
> Project: GateIn Portal
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.3.Final
> Environment: eXo Platform 4.0.0-Beta2
> Reporter: Hela Zekri
> Assignee: Trong Tran
> Priority: Blocker
> Labels: portal-s71, worked
> Fix For: 3.7.0.Final
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> {color:red}
> In eXo Platform, we have the membership type "*". If user has this membership type in a group, it means that he has all membership types in this group.
> {color}
> *Please try this scenario :*
> Add a user that has the membership type "manager" in "/platform/administrators" group and the membership type "*" in "/platform/users" group.
> When this user clicks "add page" in "Page Management", he has the possibility to choose the owner type "group" or "portal". If he chooses "group", the expected output is that he gets as "Owner Id", a selectbox that contains all groups in which he has the membership type "manager".
> (!) The membership type "manager" is set in "portal-configuration.xml" as value-param to UserACL component :
> {code:xml}
> <value-param>
> <name>navigation.creator.membership.type</name>
> <description>specific membership type have full permission with group navigation</description>
> <value>manager</value>
> </value-param>
> {code}
> In this case, user should get as "Owner Id" a selectbox that contains "/platform/administrators" and "/platform/users" groups(The membership type "*" includes "manager" membership type).
> But the current behavior is that the selectbox of "Owner Id" contains only the group "/platform/administator". This is due to the fact that the relationship "*" is considered as a String and not interpreted.
> *There are two possible solutions to this problem :*
> 1- Set the possibility to put many values for "navigation.creator.membership.type" value-param. So that we could do for example :
> {code:xml}
> <value-param>
> <name>navigation.creator.membership.type</name>
> <description>specific membership type have full permission with group navigation</description>
> <value>*,manager</value>
> </value-param>
> {code}
> 2- In "_findRoles_" method in "_org.picketlink.idm.impl.api.session.managers.RoleManagerImpl_" class :
> In the code bellow, each relationship of a user is compared to roleType ("manager"). If it is equal, it will be added to the list that will be returned. So even "*" is compared to "manager", it is not equal, so it won't be added.
> {code}
> for (IdentityObjectRelationship relationship : relationships)
> {
> if (roleType != null)
> {
> if (roleType.getName().equals(relationship.getName()))
> {
> roles.add(new SimpleRole(new SimpleRoleType(relationship.getName()), createUser(relationship.getToIdentityObject()), createGroup(relationship.getFromIdentityObject())));
> }
> }
> else
> {
> roles.add(new SimpleRole(new SimpleRoleType(relationship.getName()), createUser(relationship.getToIdentityObject()), createGroup(relationship.getFromIdentityObject())));
> }
> }
> {code}
> We created [https://issues.jboss.org/browse/PLIDM-40] in which we propose a patch that adds a test on "*" value.
> In the patch, we changed :
> {code}
> if (roleType.getName().equals(relationship.getName()))
> {code}
> to :
> {code}
> if ((roleType.getName().equals(relationship.getName())) || relationship.getName().equals("*"))
> {code}
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months
[JBoss JIRA] (GTNPORTAL-3273) It restores all pre-defined configuration when re-creating a site config with the same name
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3273?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-3273:
----------------------------------
Sprint: (was: Sprint 81)
> It restores all pre-defined configuration when re-creating a site config with the same name
> -------------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3273
> URL: https://issues.jboss.org/browse/GTNPORTAL-3273
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.6.Final, 3.6.1.Final
> Reporter: Trong Tran
> Fix For: 3.7.0.Final
>
>
> Steps to reproduce:
> - Login with root
> - Edit the home page layout to add the Organization Porltet
> - In Organization portlet, go to delete the pre-defined group /organization/management/executive-board. You will notice that it also deletes all data (navigation nodes, pages) belonging to that group
> - Then re-create a group with the same name under /organization/management/.
> ===> Now you will see that all pre-defined data is restored as the first initializing time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months
[JBoss JIRA] (GTNPORTAL-3245) Add comfriming when user remove permissions on edit page & site
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3245?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-3245:
----------------------------------
Remaining Estimate: 2 hours (was: 0 minutes)
> Add comfriming when user remove permissions on edit page & site
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-3245
> URL: https://issues.jboss.org/browse/GTNPORTAL-3245
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.6.1.Final
> Reporter: Hai Nguyen
> Assignee: Hai Nguyen
> Priority: Minor
> Labels: backlogs
> Original Estimate: 4 hours
> Time Spent: 1 day, 7 hours
> Remaining Estimate: 2 hours
>
> - Login portal
> - Go to user and group management
> - Choose Group management tab
> - Add new group ( ex: AAA)
> - Go to Pages
> - Add new page for group above
> - Search this page and click edit
> - Click view page properties
> - Change access and edit permission to ( organization/*)
> - Click Finish button on Editor composer
> => Unknown error and throw exception in console
> {noformat}
> 2013-08-08 15:20:18,549 | ERROR | Error during the processAction phase [portal:UIPortalApplication<http-nio-0.0.0.0-8080-exec-10>]
> java.lang.NullPointerException: null
> at org.exoplatform.portal.webui.portal.UIPortalComposer$FinishPageEditionActionListener.execute(UIPortalComposer.java:680) ~[exo.portal.webui.portal-3.5.6-PLF.jar:3.5.6-PLF]
>
> {noformat}
>
> Reproduce on edit site is the same
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-2751:
----------------------------------
Sprint: Sprint 77, Sprint 78, Sprint 79 (was: Sprint 77, Sprint 78, Sprint 79, Sprint 81)
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Trong Tran
> Original Estimate: 4 hours
> Time Spent: 1 day, 2 hours
> Remaining Estimate: 1 hour
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Hai Nguyen (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl... ]
Hai Nguyen updated GTNPORTAL-2751:
----------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/gatein/gatein-portal/pull/673
Fix solution:
- <priority> has been optional and default by -1
- If a priority less than 1, it will be set to -1
- If a priority has valued -1, then Navigation priority will be displayed "undefined" on UI
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Trong Tran
> Original Estimate: 4 hours
> Time Spent: 1 day, 2 hours
> Remaining Estimate: 1 hour
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 6 months