[JBoss JIRA] (GTNPORTAL-3245) Add comfriming when user remove permissions on edit page & site
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3245?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-3245:
----------------------------------
Status: Pull Request Sent (was: Open)
> Add comfriming when user remove permissions on edit page & site
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-3245
> URL: https://issues.jboss.org/browse/GTNPORTAL-3245
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.6.1.Final
> Reporter: Hai Nguyen
> Assignee: Hai Nguyen
> Priority: Minor
> Labels: backlogs
> Original Estimate: 4 hours
> Time Spent: 1 day, 7 hours
> Remaining Estimate: 0 minutes
>
> - Login portal
> - Go to user and group management
> - Choose Group management tab
> - Add new group ( ex: AAA)
> - Go to Pages
> - Add new page for group above
> - Search this page and click edit
> - Click view page properties
> - Change access and edit permission to ( organization/*)
> - Click Finish button on Editor composer
> => Unknown error and throw exception in console
> {noformat}
> 2013-08-08 15:20:18,549 | ERROR | Error during the processAction phase [portal:UIPortalApplication<http-nio-0.0.0.0-8080-exec-10>]
> java.lang.NullPointerException: null
> at org.exoplatform.portal.webui.portal.UIPortalComposer$FinishPageEditionActionListener.execute(UIPortalComposer.java:680) ~[exo.portal.webui.portal-3.5.6-PLF.jar:3.5.6-PLF]
>
> {noformat}
>
> Reproduce on edit site is the same
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months
[JBoss JIRA] (GTNPORTAL-2729) PageService.findPages does not take into account the page name.
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2729?focusedWorklogId=12430000&... ]
Trong Tran logged work on GTNPORTAL-2729:
-----------------------------------------
Author: Trong Tran
Created on: 15/Oct/13 4:21 AM
Start Date: 15/Oct/13 4:21 AM
Worklog Time Spent: 4 hours
Issue Time Tracking
-------------------
Time Spent: 1 day, 2 hours (was: 6 hours)
Worklog Id: (was: 12430000)
> PageService.findPages does not take into account the page name.
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-2729
> URL: https://issues.jboss.org/browse/GTNPORTAL-2729
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Beta02
> Reporter: Nick Scavelli
> Assignee: Tuyen Nguyen The
> Original Estimate: 3 hours
> Time Spent: 1 day, 2 hours
> Remaining Estimate: 0 minutes
>
> Looks like pageName is not used for finding pages; however, the API accepts pageName as a parameter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?focusedWorklogId=12429999&... ]
Trong Tran logged work on GTNPORTAL-2751:
-----------------------------------------
Author: Trong Tran
Created on: 15/Oct/13 12:48 AM
Start Date: 11/Oct/13 12:48 AM
Worklog Time Spent: 5 hours
Issue Time Tracking
-------------------
Remaining Estimate: 1 hour (was: 6 hours)
Time Spent: 1 day, 2 hours (was: 5 hours)
Worklog Id: (was: 12429999)
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Trong Tran
> Original Estimate: 4 hours
> Time Spent: 1 day, 2 hours
> Remaining Estimate: 1 hour
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months
[JBoss JIRA] (GTNPORTAL-3243) Exceptions are swallowed in PicketLinkIDMOrganizationServiceImpl flush and endRequest
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3243?page=com.atlassian.jira.pl... ]
RH Bugzilla Integration commented on GTNPORTAL-3243:
----------------------------------------------------
Dominik Pospisil <dpospisi(a)redhat.com> made a comment on [bug 998885|https://bugzilla.redhat.com/show_bug.cgi?id=998885]
Patch verified in the scope of BZ 999406.
Patch presence verified by decompilation.
> Exceptions are swallowed in PicketLinkIDMOrganizationServiceImpl flush and endRequest
> -------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3243
> URL: https://issues.jboss.org/browse/GTNPORTAL-3243
> Project: GateIn Portal
> Issue Type: Bug
> Components: Identity integration
> Affects Versions: 3.6.0.Final
> Reporter: Martin Weiler
> Assignee: Marek Posolda
> Fix For: 3.6.3.Final
>
>
> IDM operations are invoked from a WS facade in our environment, and not from the GUI. Therefore, we have overridden PicketLinkIDMOrganizationServiceImpl.recoverFromIDMError to just let any errors bubble up and let the upper layer handle it, instead of rolling back + restarting the transaction.
> But here's the place the exception handling is not working as expected. The issue is in PicketLinkIDMOrganizationServiceImpl.flush():
> {code}
> public void flush() {
> try {
> if (configuration.isUseJTA()) {
> if (traceLoggingEnabled) {
> log.trace("Flushing UserTransaction in method flush");
> }
> // Complete restart of JTA transaction don't have good performance. So we will only sync identitySession (same
> // as for non-jta environment)
> // finishJTATransaction();
> // beginJTATransaction();
> if (jtaTransactionLifecycleService.getUserTransaction().getStatus() == Status.STATUS_ACTIVE) {
> idmService_.getIdentitySession().save();
> }
> } else {
> try {
> if (idmService_.getIdentitySession().getTransaction().isActive()) {
> 166: idmService_.getIdentitySession().save();
> }
> } catch (Exception e) {
> log.error(e.getMessage(), e);
> 170: recoverFromIDMError(e);
> }
> }
> 174: } catch (Exception e) {
> 175: log.error(e.getMessage(), e);
> }
> }
> {code}
> Let's assume there is an exception at session.save() in line 166. This exception is then handled by the recoverFromIDMError method in line 170. In our environment, this method is overridden and throws an Exception.
> But the initial goal of overriding this method, which was to have this exception propagated to the caller, is not reached here, as there is an outer try..catch block in the PicketLinkIDMOrganizationServiceImpl.flush() method which just logs the error.
> The outer try..catch block should be removed in flush() and endRequest().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months
[JBoss JIRA] (GTNPORTAL-3243) Exceptions are swallowed in PicketLinkIDMOrganizationServiceImpl flush and endRequest
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-3243?page=com.atlassian.jira.pl... ]
RH Bugzilla Integration commented on GTNPORTAL-3243:
----------------------------------------------------
Dominik Pospisil <dpospisi(a)redhat.com> changed the Status of [bug 998885|https://bugzilla.redhat.com/show_bug.cgi?id=998885] from ON_QA to VERIFIED
> Exceptions are swallowed in PicketLinkIDMOrganizationServiceImpl flush and endRequest
> -------------------------------------------------------------------------------------
>
> Key: GTNPORTAL-3243
> URL: https://issues.jboss.org/browse/GTNPORTAL-3243
> Project: GateIn Portal
> Issue Type: Bug
> Components: Identity integration
> Affects Versions: 3.6.0.Final
> Reporter: Martin Weiler
> Assignee: Marek Posolda
> Fix For: 3.6.3.Final
>
>
> IDM operations are invoked from a WS facade in our environment, and not from the GUI. Therefore, we have overridden PicketLinkIDMOrganizationServiceImpl.recoverFromIDMError to just let any errors bubble up and let the upper layer handle it, instead of rolling back + restarting the transaction.
> But here's the place the exception handling is not working as expected. The issue is in PicketLinkIDMOrganizationServiceImpl.flush():
> {code}
> public void flush() {
> try {
> if (configuration.isUseJTA()) {
> if (traceLoggingEnabled) {
> log.trace("Flushing UserTransaction in method flush");
> }
> // Complete restart of JTA transaction don't have good performance. So we will only sync identitySession (same
> // as for non-jta environment)
> // finishJTATransaction();
> // beginJTATransaction();
> if (jtaTransactionLifecycleService.getUserTransaction().getStatus() == Status.STATUS_ACTIVE) {
> idmService_.getIdentitySession().save();
> }
> } else {
> try {
> if (idmService_.getIdentitySession().getTransaction().isActive()) {
> 166: idmService_.getIdentitySession().save();
> }
> } catch (Exception e) {
> log.error(e.getMessage(), e);
> 170: recoverFromIDMError(e);
> }
> }
> 174: } catch (Exception e) {
> 175: log.error(e.getMessage(), e);
> }
> }
> {code}
> Let's assume there is an exception at session.save() in line 166. This exception is then handled by the recoverFromIDMError method in line 170. In our environment, this method is overridden and throws an Exception.
> But the initial goal of overriding this method, which was to have this exception propagated to the caller, is not reached here, as there is an outer try..catch block in the PicketLinkIDMOrganizationServiceImpl.flush() method which just logs the error.
> The outer try..catch block should be removed in flush() and endRequest().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months
[JBoss JIRA] (GTNPORTAL-2751) <priority> in navigation.xml files ignored for merge importMode
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2751?page=com.atlassian.jira.pl... ]
Trong Tran updated GTNPORTAL-2751:
----------------------------------
Issue Type: Bug (was: Task)
> <priority> in navigation.xml files ignored for merge importMode
> ----------------------------------------------------------------
>
> Key: GTNPORTAL-2751
> URL: https://issues.jboss.org/browse/GTNPORTAL-2751
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Palaga
> Assignee: Trong Tran
> Original Estimate: 4 hours
> Time Spent: 5 hours
> Remaining Estimate: 6 hours
>
> Steps to reproduce:
> Clone the Portal Extension Quickstart and deploy it changing the {{<priority>}} value in {{war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml}}.
> NOT OK: The changes have no effect, because priority is ignored in {{org.exoplatform.portal.mop.importer.NavigationImporter.perform()}} with {{importMode}} {{merge}}.
> h3. Solution Proposal A
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Explicitly state in the documentation [1] that {{<priority>}} is considered only if not already set (first wins).
> h3. Solution Proposal B
> * Make {{<priority>}} optional in {{gatein_objects}} XSD and {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}}
> * Change the behavior of {{NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)}} to the effect that {{<priority>}} is handled in the same way as navigation nodes: it is used or ignored according to the chosen {{importMode}}. Esp. for {{importMode}} {{merge}} the last read {{<priority>}} should win.
> * Document it in [1]
> For both A and B the most or all occutences of {{<priority>}} should be removed from Portal Extension Quickstart.
> [1] [https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Confi...]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months
[JBoss JIRA] (GTNPORTAL-2729) PageService.findPages does not take into account the page name.
by Trong Tran (JIRA)
[ https://issues.jboss.org/browse/GTNPORTAL-2729?focusedWorklogId=12429976&... ]
Trong Tran logged work on GTNPORTAL-2729:
-----------------------------------------
Author: Trong Tran
Created on: 11/Oct/13 12:07 AM
Start Date: 10/Oct/13 12:07 AM
Worklog Time Spent: 1 hour
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 1 hour)
Time Spent: 6 hours (was: 5 hours)
Worklog Id: (was: 12429976)
> PageService.findPages does not take into account the page name.
> ---------------------------------------------------------------
>
> Key: GTNPORTAL-2729
> URL: https://issues.jboss.org/browse/GTNPORTAL-2729
> Project: GateIn Portal
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 3.5.0.Beta02
> Reporter: Nick Scavelli
> Assignee: Tuyen Nguyen The
> Original Estimate: 3 hours
> Time Spent: 6 hours
> Remaining Estimate: 0 minutes
>
> Looks like pageName is not used for finding pages; however, the API accepts pageName as a parameter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 6 months