[gatein-issues] [JBoss JIRA] (GTNPORTAL-2972) EPP+SP: Problem with LoginRedirectFilter reading POST parameters

EPP+SP: Problem with LoginRedirectFilter reading POST parameters ---------------------------------------------------------------- Key: GTNPORTAL-2972 URL: https://issues.jboss.org/browse/GTNPORTAL-2972 Project: GateIn Portal Issue Type: Enhancement Security Level: Public(Everyone can see) Reporter: Marek Posolda Assignee: Marek Posolda Fix For: 3.x Reported by Martin Weiler: a customer is using LoginRedirectFilter on EPP+SP. We found out that this filter is breaking the Content Inline editing functionality of SP, as it reads out the request parameters, which results in the POST parameters getting null. The customer is suggesting the following fix: // Return true if logout request is in progress - private boolean isLogoutRequest(HttpServletRequest req) - { - String portalComponentId = req.getParameter("portal:componentId"); - String portalAction = req.getParameter("portal:action"); - if (("UIPortal".equals(portalComponentId)) && ("Logout".equals(portalAction))) - { - return true; - } - else - { - return false; - } + private boolean isLogoutRequest(HttpServletRequest req) { + if("GET".equals(req.getMethod())) { + String portalComponentId = req.getParameter("portal:componentId"); + String portalAction = req.getParameter("portal:action"); + + if (("UIPortal".equals(portalComponentId)) && ("Logout".equals(portalAction))) + return true; + else + return false; + } + else + return false; } If you think it is ok, could you go ahead and commit it?