[hawkular/hawkular-alerts] 501764: More tidying of recent displayString logic (#415)
by Jay Shaughnessy
Branch: refs/heads/next
Home: https://github.com/hawkular/hawkular-alerts
Commit: 5017642a7298285d7fa765d5a5c26d0503a48051
https://github.com/hawkular/hawkular-alerts/commit/5017642a7298285d7fa765...
Author: Jay Shaughnessy <jshaughn(a)users.noreply.github.com>
Date: 2017-07-28 (Fri, 28 Jul 2017)
Changed paths:
M api/src/main/java/org/hawkular/alerts/api/json/JacksonDeserializer.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/Condition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/EventCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/EventConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/RateCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/RateConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/StringCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/StringConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java
Log Message:
-----------
More tidying of recent displayString logic (#415)
- remove annoying, slow and likely unnecessary updateDisplayString()
calls from all of the Condition impls.
- Relevant Condition fields are likely not updated after
construction, so don't worry about it, just make updateDisplayString()
public and jdoc that you need to call it if you do for some bizarre
reason explicitly set a field after construction. The exception is
JSON deserialization. In that case we now update the displayString
one time before returning the deserialized Condition (same for
ConditionEval)
- Also, make more consistent by usingthe same logic/method names for
both Condition and ConditionEval.
6 years, 8 months
[hawkular/hawkular-alerts] 86f413: Add displayString support to Condition so that RES...
by Jay Shaughnessy
Branch: refs/heads/next
Home: https://github.com/hawkular/hawkular-alerts
Commit: 86f4134b78c6801f9dbfe29b9bac6df3a06a8716
https://github.com/hawkular/hawkular-alerts/commit/86f4134b78c6801f9dbfe2...
Author: Jay Shaughnessy <jshaughn(a)users.noreply.github.com>
Date: 2017-07-28 (Fri, 28 Jul 2017)
Changed paths:
M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/Condition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/EventCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/EventConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/RateCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/RateConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/StringCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/StringConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java
M api/src/test/java/org/hawkular/alerts/api/JsonTest.java
M engine/src/main/resources/org/hawkular/alerts/engine/rules/ConditionMatch.drl
M ui/src/main/ui/src/alerts/alerts.html
M ui/src/main/ui/src/dashboard/dashboard.html
M ui/src/main/ui/src/triggers/triggers.html
Log Message:
-----------
Add displayString support to Condition so that REST (#414)
clients (like the UI) can easily access a canonical display
string describing the Condition. This is somewhat analogous
to the recent work to provide the same thing for ConditionEval
and the canonical display strings are similar for consistency.
Note, also for consistency, the poorly named ConditionEval.getLog()
is now ConditionEval.displayString(), to match Condition.displayString().
6 years, 8 months
[hawkular/hawkular-alerts] 3f79f5: Generate and store the string log on the Condition...
by Jay Shaughnessy
Branch: refs/heads/next
Home: https://github.com/hawkular/hawkular-alerts
Commit: 3f79f584d38be1c36f793a52999e211e9bb94937
https://github.com/hawkular/hawkular-alerts/commit/3f79f584d38be1c36f793a...
Author: Jay Shaughnessy <jshaughn(a)users.noreply.github.com>
Date: 2017-07-27 (Thu, 27 Jul 2017)
Changed paths:
M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/EventCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/EventConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/RateCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/RateConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/StringCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/StringConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeCondition.java
M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeConditionEval.java
M api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java
M ui/src/main/ui/src/alerts/alerts.html
M ui/src/main/ui/src/dashboard/dashboard.html
Log Message:
-----------
Generate and store the string log on the ConditionEval so that (#412)
it is available downstream to REST clients (like the UI). Note
that the log is generated in a lazy way so as not to burden
ConditionEval construction (in the engine), because we
construct many ConditionEvals but most are never persisted.
Also, use the new eval.log in the UI alerts and dash html
6 years, 8 months
[hawkular/hawkular-metrics] d0db2f: Add missing shutdown() requests to avoid multiple ...
by Stefan Negrea
Branch: refs/heads/master
Home: https://github.com/hawkular/hawkular-metrics
Commit: d0db2f3f7d36f299f750c0036347fbdeb2e6ac65
https://github.com/hawkular/hawkular-metrics/commit/d0db2f3f7d36f299f750c...
Author: Michael Burman <yak(a)iki.fi>
Date: 2017-07-24 (Mon, 24 Jul 2017)
Changed paths:
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/jobs/CompressDataJobITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/jobs/DeleteExpiredMetricsJobITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/jobs/DeleteTenantITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/DataAccessITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/TestDataAccessFactory.java
Log Message:
-----------
Add missing shutdown() requests to avoid multiple SchemaChangeListeners
Commit: 55c1d9a03fb1241c34e55d29d2ca6e40224444e3
https://github.com/hawkular/hawkular-metrics/commit/55c1d9a03fb1241c34e55...
Author: Stefan Negrea <stefannegrea(a)users.noreply.github.com>
Date: 2017-07-27 (Thu, 27 Jul 2017)
Changed paths:
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/jobs/CompressDataJobITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/jobs/DeleteExpiredMetricsJobITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/jobs/DeleteTenantITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/DataAccessITest.java
M core/metrics-core-service/src/test/java/org/hawkular/metrics/core/service/TestDataAccessFactory.java
Log Message:
-----------
Merge pull request #855 from burmanm/test_fixes
Add missing DataAccess.shutdown() requests
Compare: https://github.com/hawkular/hawkular-metrics/compare/1bb8126fbab3...55c1d...
6 years, 8 months