[Hawkular-commits] [hawkular/hawkular-metrics] 2ee45a: [HWKMETRICS-695] Fix NPE and several other issues

Branch: refs/heads/master Home: https://github.com/hawkular/hawkular-metrics Commit: 2ee45aa0d66f3fff5d8df6d29ef79f75e02121e6 https://github.com/hawkular/hawkular-metrics/commit/2ee45aa0d66f3fff5d8df... Author: John Sanda <jsanda(a)redhat.com&gt; Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetaData.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RecordMetricsFilter.java M api/metrics-api-util/src/main/java/org/hawkular/metrics/api/jaxrs/config/ConfigurationKey.java M containers/hawkular-openshift-security-filter/src/main/java/org/hawkular/openshift/auth/TokenAuthenticator.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/DropWizardReporter.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricRegistry.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricsRegistryListener.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularObjectNameFactory.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/MetaData.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java Log Message: ----------- [HWKMETRICS-695] Fix NPE and several other issues HawkularObjectNameFactory previously assumed every metric would have meta data. TokenAuthenticator was registering metrics without meta data. I have updated TokenAuthenticator so that it creates meta data. I have also updated HawkularObjectNameFactory to handle the case where there is no meta data. There is another important change around the meta data. If a metric does not have meta data, then its tags and data points will not get persisted. A warning will get logged by HawkularMetricsRegistryListener about the lack of meta data. I have refactored the way in which internal metrics are registered. Previously everything was done eagerly at start up. Now only meta data is registered eagerly. Registering meta data will not cause anything to be persisted in Cassandra. Metrics are registered lazily upon access. Commit: bf4c2eb0bafe1670a164c276f189053df2cdd9db https://github.com/hawkular/hawkular-metrics/commit/bf4c2eb0bafe1670a164c... Author: John Sanda <jsanda(a)redhat.com&gt; Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/DropWizardReporter.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularObjectNameFactory.java Log Message: ----------- [HWKMETRICS-695] checkstyle Commit: 7fe8d21a32cb11cfa792ec0307bd65cc1ad71f0b https://github.com/hawkular/hawkular-metrics/commit/7fe8d21a32cb11cfa792e... Author: John Sanda <jsanda(a)redhat.com&gt; Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RecordMetricsFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/AdminHandler.java Log Message: ----------- [HWKMETRICS-695] register REST metrics dynamically Commit: f2df4615c8503d6f626dbc38579400bb877de01d https://github.com/hawkular/hawkular-metrics/commit/f2df4615c8503d6f626db... Author: John Sanda <jsanda(a)redhat.com&gt; Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java Log Message: ----------- [HWKMETIRCS-695] checkstyle Commit: a38a0a83ef66915b8fb8930be3e6926b2cf4c010 https://github.com/hawkular/hawkular-metrics/commit/a38a0a83ef66915b8fb89... Author: Stefan Negrea <stefannegrea(a)users.noreply.github.com&gt; Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/MetricsServiceLifecycle.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetaData.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RESTMetrics.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/dropwizard/RecordMetricsFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/AdminHandler.java M api/metrics-api-util/src/main/java/org/hawkular/metrics/api/jaxrs/config/ConfigurationKey.java M containers/hawkular-openshift-security-filter/src/main/java/org/hawkular/openshift/auth/TokenAuthenticator.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/DropWizardReporter.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricRegistry.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularMetricsRegistryListener.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/HawkularObjectNameFactory.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/dropwizard/MetaData.java M core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java Log Message: ----------- Merge pull request #850 from jsanda/hwkmetrics-695 [HWKMETRICS-695] Fix NPE and several other issues Compare: https://github.com/hawkular/hawkular-metrics/compare/82508c17ecf0...a38a0...