3:04 a.m.
Branch: refs/heads/master
Home: https://github.com/hawkular/hawkular-alerts
Commit: a630a08d51a34f3d41729579488d66e23c723673
https://github.com/hawkular/hawkular-alerts/commit/a630a08d51a34f3d417295...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2017-05-01 (Mon, 01 May 2017)
Changed paths:
M
hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy
M
hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/TriggersITest.groovy
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ActionPluginHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ActionsHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/AlertsHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/CommonUtil.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/CrossTenantHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/EventsHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ExportHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ImportHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ResponseUtil.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/TriggersHandler.java
Log Message:
-----------
HWKALERTS-257 increase use of 400 resturn codes for illegal/bad args
Simplify catch blocks by introducing a new utility to handle responses
on exceptions. As part of the changes do some code cleanup in the handlers:
- remove unnecessary log.isDebugEnabled clauses
- prefer log.debugf over log.debug
- remove unnecessary else-clauses after returns
- reorder response code annotations to be ascending numerically
HWKALERTS-256 fix some guards in handlers
- use isEmpty() in a few more places
- consolidate code with new CommonUtil.checkTags()
Commit: 4536f7c40f3684c5b048044271a841bc3e001662
https://github.com/hawkular/hawkular-alerts/commit/4536f7c40f3684c5b04804...
Author: Lucas Ponce <ponce.ballesteros(a)gmail.com>
Date: 2017-05-03 (Wed, 03 May 2017)
Changed paths:
M
hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy
M
hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/TriggersITest.groovy
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ActionPluginHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ActionsHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/AlertsHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/CommonUtil.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/CrossTenantHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/EventsHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ExportHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ImportHandler.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/ResponseUtil.java
M
hawkular-alerts-rest/hawkular-alerts-rest-api/src/main/java/org/hawkular/alerts/rest/TriggersHandler.java
Log Message:
-----------
Merge pull request #323 from jshaughn/hwkalerts-257
HWKALERTS-257 increase use of 400 return codes for illegal/bad args
Compare: https://github.com/hawkular/hawkular-alerts/compare/60e34ed50773...4536f7...