[Hawkular-commits] [hawkular/hawkular-metrics] d6309f: [HWKMETRICS-554] Fix several issues with CORS

Branch: refs/heads/master Home: https://github.com/hawkular/hawkular-metrics Commit: d6309f44e63bcce43fa1c60a36997ecac62e0d04 https://github.com/hawkular/hawkular-metrics/commit/d6309f44e63bcce43fa1c... Author: Joel Takvorian <jtakvori(a)redhat.com&gt; Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/filter/CorsRequestFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/filter/CorsResponseFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/AvailabilityHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/CounterHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/GaugeHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/MetricsServiceHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/StringHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/observer/NamedDataPointObserver.java Log Message: ----------- [HWKMETRICS-554] Fix several issues with CORS - payload was sent even on error 400 on invalid origin. This was because CORS validation occured at response filtering => move validation to request filter - CORS related headers not sent for some endpoints. Related to how NamedDataPointObserver was handling the async response, i think the output stream was closed and subsequent response filter adding headers were ineffective; now use AsyncResponse::resume to complete the response. Commit: 2f229206ac8ca8eeb9a32a3af6786c4f82011c69 https://github.com/hawkular/hawkular-metrics/commit/2f229206ac8ca8eeb9a32... Author: Joel Takvorian <jtakvori(a)redhat.com&gt; Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M api/metrics-api-jaxrs/pom.xml M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/filter/CorsRequestFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/filter/CorsResponseFilter.java R api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/util/Headers.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/util/OriginValidation.java M integration-tests/rest-tests-jaxrs/src/test/groovy/org/hawkular/metrics/rest/CORSITest.groovy M pom.xml Log Message: ----------- [HWKMETRICS-554] Use CORS filtering utility from hawkular-commons Add CORS tests Commit: 1e720345b087704575650ab66b96f12a609bb57a https://github.com/hawkular/hawkular-metrics/commit/1e720345b087704575650... Author: Joel Takvorian <jtakvori(a)redhat.com&gt; Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M pom.xml Log Message: ----------- Use srcdeps for commons Commit: 8eaeb1a3175216623bbd6f2539684e44fecb28f1 https://github.com/hawkular/hawkular-metrics/commit/8eaeb1a3175216623bbd6... Author: Joel Takvorian <jtakvori(a)redhat.com&gt; Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M pom.xml Log Message: ----------- Use hawkular-commons 0.9.1 final Commit: a77e80f69b41a8075baf8661575ac3e9b710e7cf https://github.com/hawkular/hawkular-metrics/commit/a77e80f69b41a8075baf8... Author: Stefan Negrea <stefannegrea(a)users.noreply.github.com&gt; Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M api/metrics-api-jaxrs/pom.xml M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/filter/CorsRequestFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/filter/CorsResponseFilter.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/AvailabilityHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/CounterHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/GaugeHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/MetricsServiceHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/StringHandler.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/handler/observer/NamedDataPointObserver.java R api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/util/Headers.java M api/metrics-api-jaxrs/src/main/java/org/hawkular/metrics/api/jaxrs/util/OriginValidation.java M integration-tests/rest-tests-jaxrs/src/test/groovy/org/hawkular/metrics/rest/CORSITest.groovy M pom.xml Log Message: ----------- Merge pull request #707 from jotak/cors-requests [HWKMETRICS-554] Fix several issues with CORS Compare: https://github.com/hawkular/hawkular-metrics/compare/b4fb18278589...a77e8...