[jbpm-commits] JBoss JBPM SVN: r6166 - in jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job: executor and 1 other directory.

Author: alex.guizar(a)jboss.com Date: 2010-02-05 17:25:28 -0500 (Fri, 05 Feb 2010) New Revision: 6166 Modified: jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/ExecuteNodeJob.java jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/executor/JobExecutorThread.java Log: JBPM-2787: extra logging while saving job exception Modified: jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/ExecuteNodeJob.java =================================================================== --- jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/ExecuteNodeJob.java 2010-02-05 17:59:02 UTC (rev 6165) +++ jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/ExecuteNodeJob.java 2010-02-05 22:25:28 UTC (rev 6166) @@ -10,7 +10,7 @@ public class ExecuteNodeJob extends Job { private static final long serialVersionUID = 1L; - + Node node; public ExecuteNodeJob() { @@ -19,20 +19,21 @@ public ExecuteNodeJob(Token token) { super(token); } - - public boolean execute(JbpmContext jbpmContext) throws Exception { - log.debug("job["+id+"] executes "+node); + public boolean execute(JbpmContext jbpmContext) throws Exception { + log.debug(this + " executes " + node); + token.unlock(this.toString()); ExecutionContext executionContext = new ExecutionContext(token); node.execute(executionContext); return true; } - + public Node getNode() { return node; } + public void setNode(Node node) { this.node = node; } Modified: jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/executor/JobExecutorThread.java =================================================================== --- jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/executor/JobExecutorThread.java 2010-02-05 17:59:02 UTC (rev 6165) +++ jbpm3/branches/jbpm-3.2-soa/modules/core/src/main/java/org/jbpm/job/executor/JobExecutorThread.java 2010-02-05 22:25:28 UTC (rev 6166) @@ -18,6 +18,7 @@ import org.jbpm.job.Job; import org.jbpm.persistence.db.DbPersistenceService; import org.jbpm.persistence.db.StaleObjectLogConfigurer; +import org.jbpm.util.ClassUtil; public class JobExecutorThread extends Thread { @@ -96,12 +97,12 @@ } } catch (InterruptedException ie) { - log.debug(getName() + " got interrupted: " + e.getMessage()); + log.debug(getName() + " got interrupted"); } } } catch (InterruptedException e) { - log.debug(getName() + " got interrupted: " + e.getMessage()); + log.debug(getName() + " got interrupted"); } } log.info(getName() + " leaves cyberspace"); @@ -222,6 +223,8 @@ private void saveJobException(Job job, Exception exception) { JbpmContext jbpmContext = jbpmConfiguration.createJbpmContext(); try { + log.debug("saving " + ClassUtil.getSimpleName(exception.getClass()) + + " thrown by " + job); JobSession jobSession = jbpmContext.getJobSession(); // not reattaching existing job as it may contain updates job = jobSession.loadJob(job.getId()); @@ -229,7 +232,9 @@ StringWriter out = new StringWriter(); exception.printStackTrace(new PrintWriter(out)); job.setException(out.toString()); - job.setRetries(job.getRetries() - 1); + int retries = job.getRetries() - 1; + job.setRetries(retries); + log.debug(job + " has " + retries + " retries remaining"); } catch (RuntimeException e) { jbpmContext.setRollbackOnly();