[jbpm-commits] JBoss JBPM SVN: r6278 - jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl.

Author: alex.guizar(a)jboss.com Date: 2010-04-23 20:18:37 -0400 (Fri, 23 Apr 2010) New Revision: 6278 Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailServer.java Log: JBPM-2426: move away from default mail session as it is "potentially available to all code executing in the same vm"; cache new session in mail server instead Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java =================================================================== --- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java 2010-04-23 19:27:29 UTC (rev 6277) +++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailProducerImpl.java 2010-04-24 00:18:37 UTC (rev 6278) @@ -144,7 +144,7 @@ } private String[] tokenizeActors(String recipients, Execution execution) { - String[] actors = evaluateExpression(recipients).split("[,;|\\s]+"); + String[] actors = evaluateExpression(recipients).split("[,;\\s]+"); if (actors.length == 0) throw new JbpmException("recipient list is empty: " + recipients); return actors; } Modified: jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailServer.java =================================================================== --- jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailServer.java 2010-04-23 19:27:29 UTC (rev 6277) +++ jbpm4/trunk/modules/pvm/src/main/java/org/jbpm/pvm/internal/email/impl/MailServer.java 2010-04-24 00:18:37 UTC (rev 6278) @@ -15,6 +15,7 @@ private AddressFilter addressFilter; private Properties sessionProperties; private Authenticator authenticator; + private Session mailSession; public AddressFilter getAddressFilter() { return addressFilter; @@ -41,6 +42,9 @@ } public Session getMailSession() { - return Session.getDefaultInstance(sessionProperties, authenticator); + if (mailSession == null) { + mailSession = Session.getInstance(sessionProperties, authenticator); + } + return mailSession; } }