]
Britt Miner closed JBPM-1183.
-----------------------------
Resolution: Rejected
I screwed up this issue, so I'm putting it to rest and opening up a new one to replace
it.
Node/State don't provide any support for Conditions on
Transitions
------------------------------------------------------------------
Key: JBPM-1183
URL:
http://jira.jboss.com/jira/browse/JBPM-1183
Project: JBoss jBPM
Issue Type: Bug
Components: Core Engine
Affects Versions: jBPM jPDL 3.2.2
Reporter: Britt Miner
Assigned To: Tom Baeyens
Node and State don't provide any preliminary check for conditions provided on
transitions. No check is performed until the transition is signaled, at which point the
process will barf if the condition evaluates to false. Regardless if a person
"should" be using transition conditions in Node or State, the schema allows it,
the documentation doesn't forbid it, and the current behavior of a Transition element
in the jpdl is inconsistent. The fix to make everything consistent is fairly simple--only
org.jbpm.graph.def.Node needs to be altered:
Add the following method:
// BRITT--
public Transition calculateLeavingTransition(ExecutionContext executionContext) {
Transition transition = null;
boolean hasTransitioned = false;
Iterator iter = leavingTransitions.iterator();
while (iter.hasNext()) {
Transition candidate = (Transition) iter.next();
String conditionExpression = candidate.getCondition();
if (conditionExpression != null) {
Object result = JbpmExpressionEvaluator.evaluate(conditionExpression,
executionContext);
if (Boolean.TRUE.equals(result)) {
transition = candidate;
}
} else {
transition = candidate;
}
}
if (!hasTransitioned) {
this.getDefaultLeavingTransition().removeConditionEnforcement();
log.warn("All transition conditions have evaluated to 'false'.
Taking the default transition.");
transition = this.getDefaultLeavingTransition();
}
return transition;
}
// --BRITT
...and modify "leave(ExecutionContext executionContext)":
// BRITT --replace the following line with the code below
// to check conditions before selecting the transition to take...
//leave(executionContext, getDefaultLeavingTransition()); //original line
leave(executionContext, calculateLeavingTransition(executionContext));
// --BRITT
For consistency, ProcessState should also have one line modified at the very end of
it's "leave(ExecutionContext, Transition)" method:
// BRITT-- rather than specify which transition, let the super class decide...
//super.leave(executionContext, getDefaultLeavingTransition());
super.leave(executionContext, calculateLeavingTransition(executionContext));
// --BRITT
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: