[jbpm-issues] [JBoss JIRA] Resolved: (JBPM-2001) DbLoggingService -> Protected Session Rather than Package Private
[
https://jira.jboss.org/browse/JBPM-2001?page=com.atlassian.jira.plugin.sy...
]
Alejandro Guizar resolved JBPM-2001.
------------------------------------
Labels: jbpm3 logging service (was: )
Assignee: Alejandro Guizar
Fix Version/s: (was: jBPM 3.2.x)
Resolution: Won't Fix
Exposing internal state gives maintainers (that is, me) less flexibility to deal with
ever-coming issues. For instance, JBPM-2983 led me to trade the DbLoggingService session
field for the whole persistenceService.
If jBPM3 had a separate API this would be less of an issue but, in the current state of
things, I prefer to hide as much as possible. In the particular case of DbLoggingService,
there is not much behavior to inherit anyway, it is probably best to implement
LoggingService directly.
DbLoggingService -> Protected Session Rather than Package Private
-----------------------------------------------------------------
Key: JBPM-2001
URL: https://jira.jboss.org/browse/JBPM-2001
Project: jBPM
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Runtime Engine
Affects Versions: jBPM 3.2.x
Reporter: Brad Davis
Assignee: Alejandro Guizar
Priority: Minor
Labels: jbpm3, logging, service
DBLoggingService should have a protected Hibernate session to allow extension. See patch
below.
### Eclipse Workspace Patch 1.0
#P jbpm
Index: modules/core/src/main/java/org/jbpm/logging/db/DbLoggingService.java
===================================================================
--- modules/core/src/main/java/org/jbpm/logging/db/DbLoggingService.java (revision 3699)
+++ modules/core/src/main/java/org/jbpm/logging/db/DbLoggingService.java (working copy)
@@ -31,7 +31,7 @@
private static final long serialVersionUID = 1L;
- Session session = null;
+ protected Session session = null;
public DbLoggingService() {
JbpmContext currentJbpmContext = JbpmContext.getCurrentJbpmContext();
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira