[overlord-commits] Overlord SVN: r877 - report-server/trunk/core/src/main/java/org/jboss/bpm/report.
Author: heiko.braun(a)jboss.com
Date: 2009-11-02 10:36:41 -0500 (Mon, 02 Nov 2009)
New Revision: 877
Modified:
report-server/trunk/core/src/main/java/org/jboss/bpm/report/ReportFacade.java
Log:
Properly close reader in ReportFacade
Modified: report-server/trunk/core/src/main/java/org/jboss/bpm/report/ReportFacade.java
===================================================================
---
report-server/trunk/core/src/main/java/org/jboss/bpm/report/ReportFacade.java 2009-11-02
15:35:49 UTC (rev 876)
+++
report-server/trunk/core/src/main/java/org/jboss/bpm/report/ReportFacade.java 2009-11-02
15:36:41 UTC (rev 877)
@@ -228,10 +228,11 @@
static public Map<String, String>
convertRequestParametersToMap(HttpServletRequest request){
HashMap<String, String> parameterMap = new HashMap<String, String>();
+ BufferedReader br = null;
try
{
- BufferedReader br = request.getReader();
+ br = request.getReader();
String line;
while ((line = br.readLine()) != null)
{
@@ -246,13 +247,22 @@
}
}
}
-
- br.close();
}
catch (IOException e)
{
- log.error("", e);
+ log.error("Failed to parse report parameters", e);
}
+ finally{
+ if(br!=null)
+ try
+ {
+ br.close();
+ }
+ catch (IOException e)
+ {
+ //
+ }
+ }
return parameterMap;
}