Author: thomas.heute(a)jboss.com
Date: 2008-02-04 06:26:00 -0500 (Mon, 04 Feb 2008)
New Revision: 9739
Added:
modules/portlet/tags/JBP_PORTLET_1_0_2/test/src/main/org/jboss/portal/portlet/test/PortletUtilsTestCase.java
Modified:
modules/portlet/tags/JBP_PORTLET_1_0_2/portlet/src/main/org/jboss/portal/portlet/impl/jsr168/PortletUtils.java
modules/portlet/tags/JBP_PORTLET_1_0_2/test/build.xml
Log:
JBPORTAL-1875: RenderResponse.getNamespace() generates a not correct value
Modified:
modules/portlet/tags/JBP_PORTLET_1_0_2/portlet/src/main/org/jboss/portal/portlet/impl/jsr168/PortletUtils.java
===================================================================
---
modules/portlet/tags/JBP_PORTLET_1_0_2/portlet/src/main/org/jboss/portal/portlet/impl/jsr168/PortletUtils.java 2008-02-04
11:20:20 UTC (rev 9738)
+++
modules/portlet/tags/JBP_PORTLET_1_0_2/portlet/src/main/org/jboss/portal/portlet/impl/jsr168/PortletUtils.java 2008-02-04
11:26:00 UTC (rev 9739)
@@ -192,7 +192,8 @@
for (int i = 0; i < windowId.length(); i++)
{
char c = windowId.charAt(i);
- if (Character.isLetterOrDigit(c))
+ int charVal = c;
+ if ((charVal >= 65 && charVal <= 90) || (charVal >= 97
&& charVal <= 122) || (charVal >=48 && charVal <= 57) || (charVal
== 95) || charVal == 36)
{
tmp.append(c);
}
Modified: modules/portlet/tags/JBP_PORTLET_1_0_2/test/build.xml
===================================================================
--- modules/portlet/tags/JBP_PORTLET_1_0_2/test/build.xml 2008-02-04 11:20:20 UTC (rev
9738)
+++ modules/portlet/tags/JBP_PORTLET_1_0_2/test/build.xml 2008-02-04 11:26:00 UTC (rev
9739)
@@ -717,6 +717,7 @@
<target name="tests.local" depends="init">
<execute-tests>
<x-test>
+ <test todir="${test.reports}"
name="org.jboss.portal.portlet.test.PortletUtilsTestCase"/>
<test todir="${test.reports}"
name="org.jboss.portal.portlet.test.url.EncoderTestCase"/>
<test todir="${test.reports}"
name="org.jboss.portal.portlet.test.url.DecoderTestCase"/>
<test todir="${test.reports}"
name="org.jboss.portal.portlet.test.StringCodecTestCase"/>
Added:
modules/portlet/tags/JBP_PORTLET_1_0_2/test/src/main/org/jboss/portal/portlet/test/PortletUtilsTestCase.java
===================================================================
---
modules/portlet/tags/JBP_PORTLET_1_0_2/test/src/main/org/jboss/portal/portlet/test/PortletUtilsTestCase.java
(rev 0)
+++
modules/portlet/tags/JBP_PORTLET_1_0_2/test/src/main/org/jboss/portal/portlet/test/PortletUtilsTestCase.java 2008-02-04
11:26:00 UTC (rev 9739)
@@ -0,0 +1,21 @@
+package org.jboss.portal.portlet.test;
+
+import org.jboss.portal.portlet.impl.jsr168.PortletUtils;
+
+import junit.framework.TestCase;
+
+public class PortletUtilsTestCase extends TestCase {
+
+ public void testgenerateNamespaceFrom()
+ {
+ String name = "_09azAZ$";
+ assertEquals(PortletUtils.PREFIX + name + PortletUtils.SUFFIX,
PortletUtils.generateNamespaceFrom(name));
+
+ name = "_";
+ assertEquals(PortletUtils.PREFIX + "_" + PortletUtils.SUFFIX,
PortletUtils.generateNamespaceFrom(name));
+
+ name = "_é";
+ assertEquals(PortletUtils.PREFIX + "__e9" + PortletUtils.SUFFIX,
PortletUtils.generateNamespaceFrom(name));
+ }
+
+}
Show replies by date