Author: chris.laprun(a)jboss.com Date: 2009-02-18 10:47:58 -0500 (Wed, 18 Feb 2009) New Revision: 12829 Modified: modules/common/trunk/common/src/main/java/org/jboss/portal/common/util/ParameterValidation.java modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/util/ParameterValidationTestCase.java Log: - ParameterValidation.isNullOrEmpty now trims tested String if not null. Modified: modules/common/trunk/common/src/main/java/org/jboss/portal/common/util/ParameterValidation.java =================================================================== --- modules/common/trunk/common/src/main/java/org/jboss/portal/common/util/ParameterValidation.java 2009-02-17 10:46:18 UTC (rev 12828) +++ modules/common/trunk/common/src/main/java/org/jboss/portal/common/util/ParameterValidation.java 2009-02-18 15:47:58 UTC (rev 12829) @@ -134,7 +134,7 @@ /** @since 2.6 */ public static boolean isNullOrEmpty(String valueToCheck) { - return valueToCheck == null || valueToCheck.length() == 0; + return valueToCheck == null || valueToCheck.trim().length() == 0; } public static void throwIllegalArgExceptionIfNull(Object objectToTest, String name) Modified: modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/util/ParameterValidationTestCase.java =================================================================== --- modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/util/ParameterValidationTestCase.java 2009-02-17 10:46:18 UTC (rev 12828) +++ modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/util/ParameterValidationTestCase.java 2009-02-18 15:47:58 UTC (rev 12829) @@ -41,6 +41,14 @@ appender = ""; } + public void testIsNullOrEmpty() + { + assertTrue(ParameterValidation.isNullOrEmpty(null)); + assertTrue(ParameterValidation.isNullOrEmpty("")); + assertTrue(ParameterValidation.isNullOrEmpty(" \t\n")); + assertFalse(ParameterValidation.isNullOrEmpty(" test ")); + } + public void testSanitizeFromPatternNullPattern() { try