Author: emuckenhuber Date: 2007-12-05 17:04:05 -0500 (Wed, 05 Dec 2007) New Revision: 9302 Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/AssignRoleAction.java branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditProfileAction.java branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditRoleAction.java branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/LostPasswordAction.java branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/RoleManagementBean.java branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/UserAdministrationBean.java Log: JBPORTAL-1837: FastURLDecoder does not like to .encode null Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/AssignRoleAction.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/AssignRoleAction.java 2007-12-05 21:25:31 UTC (rev 9301) +++ branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/AssignRoleAction.java 2007-12-05 22:04:05 UTC (rev 9302) @@ -106,7 +106,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.currentUser = decoder.encode((String) params.get("currentUser")); + this.currentUser = params.get("currentUser") != null ? decoder.encode((String) params.get("currentUser")) : null; if (this.currentUser != null) { this.uiUser = new IdentityUIUser(this.currentUser); Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditProfileAction.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditProfileAction.java 2007-12-05 21:25:31 UTC (rev 9301) +++ branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditProfileAction.java 2007-12-05 22:04:05 UTC (rev 9302) @@ -214,7 +214,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.currentUser = decoder.encode((String) params.get("currentUser")); + this.currentUser = params.get("currentUser") != null ? decoder.encode((String) params.get("currentUser")) : null; this.windowState = null; if (this.currentUser == null) { @@ -295,7 +295,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.currentUser = decoder.encode((String) params.get("currentUser")); + this.currentUser = params.get("currentUser") != null ? decoder.encode((String) params.get("currentUser")) : null; return "adminChangePassword"; } Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditRoleAction.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditRoleAction.java 2007-12-05 21:25:31 UTC (rev 9301) +++ branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/EditRoleAction.java 2007-12-05 22:04:05 UTC (rev 9302) @@ -75,7 +75,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.currentRole = decoder.encode((String) params.get("currentRole")); + this.currentRole = params.get("currentRole") != null ? decoder.encode((String) params.get("currentRole")) : null; try { this.uiRole = identityRoleBean.getUIRole(this.currentRole); Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/LostPasswordAction.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/LostPasswordAction.java 2007-12-05 21:25:31 UTC (rev 9301) +++ branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/actions/LostPasswordAction.java 2007-12-05 22:04:05 UTC (rev 9302) @@ -189,7 +189,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.username = decoder.encode((String) params.get("currentUser")); + this.username = params.get("currentUser") != null ? decoder.encode((String) params.get("currentUser")) : null; return "resetPassword"; } Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/RoleManagementBean.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/RoleManagementBean.java 2007-12-05 21:25:31 UTC (rev 9301) +++ branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/RoleManagementBean.java 2007-12-05 22:04:05 UTC (rev 9302) @@ -154,7 +154,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - String role = decoder.encode((String) params.get("currentRole")); + String role = params.get("currentRole") != null ? decoder.encode((String) params.get("currentRole")) : null; this.currentRole = role != null ? role : this.currentRole; try { @@ -211,7 +211,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.currentRole = decoder.encode((String) params.get("currentRole")); + this.currentRole = params.get("currentRole") != null ? decoder.encode((String) params.get("currentRole")) : null; if (this.currentRole != null) { try Modified: branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/UserAdministrationBean.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/UserAdministrationBean.java 2007-12-05 21:25:31 UTC (rev 9301) +++ branches/JBoss_Portal_Branch_2_6/core-identity/src/main/org/jboss/portal/core/identity/ui/admin/UserAdministrationBean.java 2007-12-05 22:04:05 UTC (rev 9302) @@ -261,7 +261,7 @@ ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); String action = (String) params.get("enableAction"); - this.currentUser = decoder.encode((String) params.get("currentUser")); + this.currentUser = params.get("currentUser") != null ? decoder.encode((String) params.get("currentUser")) : null; // TODO - do something better than .equals("admin") if (this.currentUser != null && action != null && ! this.currentUser.equals("admin")) @@ -348,7 +348,7 @@ FacesContext ctx = FacesContext.getCurrentInstance(); ExternalContext ectx = ctx.getExternalContext(); Map params = ectx.getRequestParameterMap(); - this.currentUser = decoder.encode((String) params.get("currentUser")); + this.currentUser = params.get("currentUser") != null ? decoder.encode((String) params.get("currentUser")) : null; if (this.currentUser != null) { this.uiUser = new IdentityUIUser(this.currentUser);