Author: julien(a)jboss.com Date: 2008-01-09 10:09:53 -0500 (Wed, 09 Jan 2008) New Revision: 9463 Modified: modules/common/trunk/common/src/main/java/org/jboss/portal/common/value/StringValue.java modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/ValueTestCase.java Log: added List<String> constructor in StringValue Modified: modules/common/trunk/common/src/main/java/org/jboss/portal/common/value/StringValue.java =================================================================== --- modules/common/trunk/common/src/main/java/org/jboss/portal/common/value/StringValue.java 2008-01-09 01:17:25 UTC (rev 9462) +++ modules/common/trunk/common/src/main/java/org/jboss/portal/common/value/StringValue.java 2008-01-09 15:09:53 UTC (rev 9463) @@ -22,7 +22,9 @@ ******************************************************************************/ package org.jboss.portal.common.value; +import java.util.List; + /** * @author <a href="mailto:julien@jboss.org">Julien Viet</a> * @version $Revision: 5451 $ @@ -55,6 +57,15 @@ this.values = values; } + public StringValue(List<String> values) throws IllegalArgumentException + { + if (values == null) + { + throw new IllegalArgumentException(); + } + this.values = values.toArray(new String[values.size()]); + } + public boolean isInstanceOf(Class clazz) { return clazz != null && clazz.isAssignableFrom(String.class); Modified: modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/ValueTestCase.java =================================================================== --- modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/ValueTestCase.java 2008-01-09 01:17:25 UTC (rev 9462) +++ modules/common/trunk/common/src/test/java/org/jboss/portal/test/common/ValueTestCase.java 2008-01-09 15:09:53 UTC (rev 9463) @@ -27,7 +27,11 @@ import org.jboss.portal.common.value.Value; import org.jboss.portal.common.value.IntegerValue; import org.jboss.portal.common.value.StringValue; +import org.jboss.portal.common.junit.ExtendedAssert; +import org.jboss.portal.common.util.Tools; +import java.util.ArrayList; + /** * @author <a href="mailto:julien@jboss.org">Julien Viet</a> * @version $Revision: 5451 $ @@ -192,6 +196,16 @@ assertEquals(d, f); } + public void testStringValueConstructor() + { + ExtendedAssert.assertEquals(new String[0], new StringValue(new ArrayList<String>()).asStringArray()); + ExtendedAssert.assertEquals(new String[]{null}, new StringValue(Tools.toList((String)null)).asStringArray()); + ExtendedAssert.assertEquals(new String[]{"foo"}, new StringValue(Tools.toList("foo")).asStringArray()); + ExtendedAssert.assertEquals(new String[]{"foo","bar"}, new StringValue(Tools.toList("foo","bar")).asStringArray()); + ExtendedAssert.assertEquals(new String[]{"foo",null}, new StringValue(Tools.toList("foo",null)).asStringArray()); + ExtendedAssert.assertEquals(new String[]{null,"bar"}, new StringValue(Tools.toList(null,"bar")).asStringArray()); + } + public void testEqualsOnStringValues() { assertEquals(new StringValue(), new StringValue());