Author: julien(a)jboss.com Date: 2008-07-24 01:54:23 -0400 (Thu, 24 Jul 2008) New Revision: 11568 Modified: branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/impl/coordination/CoordinationService.java Log: optimize unnecessary object creation Modified: branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/impl/coordination/CoordinationService.java =================================================================== --- branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/impl/coordination/CoordinationService.java 2008-07-24 05:51:21 UTC (rev 11567) +++ branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/impl/coordination/CoordinationService.java 2008-07-24 05:54:23 UTC (rev 11568) @@ -707,10 +707,10 @@ for (String string : qnames) { QName qname = QName.valueOf(string); - info.getQNames().add(qname); + info.names.add(qname); } } - aliases.add(info.getImmutableInfo()); + aliases.add(info); } } @@ -1048,22 +1048,24 @@ private class AliasInfoPOJO implements AliasBindingInfo { + /** . */ private final String name; + + /** . */ private final Page page; - private final Set<QName> qnames; - private AliasInfoPOJO(String name, Page page, Set<QName> qnames) - { - this.name = name; - this.page = page; - this.qnames = qnames; - } + /** . */ + private final Set<QName> names; + /** . */ + private final Set<QName> immutableNames; + private AliasInfoPOJO(String name, Page page) { this.name = name; this.page = page; - this.qnames = new HashSet<QName>(); + this.names = new HashSet<QName>(); + this.immutableNames = Collections.unmodifiableSet(names); } public String getName() @@ -1073,14 +1075,7 @@ public Set<QName> getQNames() { - return qnames; + return immutableNames; } - - AliasBindingInfo getImmutableInfo() - { - return new AliasInfoPOJO(name, page, Collections.unmodifiableSet(qnames)); - } - } - }