Author: chris.laprun(a)jboss.com Date: 2009-02-28 10:58:01 -0500 (Sat, 28 Feb 2009) New Revision: 12909 Modified: branches/JBoss_Portal_Branch_2_6/theme/src/bin/portal-ajax-war/dyna/style.css branches/JBoss_Portal_Branch_2_6/theme/src/main/org/jboss/portal/theme/impl/render/dynamic/DynaDecorationRenderer.java Log: - JBPORTAL-2226: dnd-handle div now has height so that we can drag from the whole title bar (needs testing on IE) - Properly close divs in DynaDecorationRenderer. Modified: branches/JBoss_Portal_Branch_2_6/theme/src/bin/portal-ajax-war/dyna/style.css =================================================================== --- branches/JBoss_Portal_Branch_2_6/theme/src/bin/portal-ajax-war/dyna/style.css 2009-02-28 15:47:31 UTC (rev 12908) +++ branches/JBoss_Portal_Branch_2_6/theme/src/bin/portal-ajax-war/dyna/style.css 2009-02-28 15:58:01 UTC (rev 12909) @@ -1,17 +1,24 @@ /* We need the min-height in order to have a region that is never empty and can receive draggables min-height doees not work on IE6 and the 2 other lines are there to make it work in that situation. - 32 pixels is the height of the region when it is empty. */ + 32 pixels is the height of the region when it is empty. */ .dnd-region { - min-height:32px; - height:auto !important; - height:32px; + min-height: 32px; + height: auto !important; + height: 32px; } +/* +Add height to handle div so that we can drag from the whole bar instead of just the title. Should work in IE as well, +though it hasn't been tested. +*/ .dnd-handle { cursor: move; + position: relative; + min-height: 1.2em; + height: auto !important; + height: 1.2em; } - .dnd-droppable { border: red 1px dashed; background-color: Transparent; Modified: branches/JBoss_Portal_Branch_2_6/theme/src/main/org/jboss/portal/theme/impl/render/dynamic/DynaDecorationRenderer.java =================================================================== --- branches/JBoss_Portal_Branch_2_6/theme/src/main/org/jboss/portal/theme/impl/render/dynamic/DynaDecorationRenderer.java 2009-02-28 15:47:31 UTC (rev 12908) +++ branches/JBoss_Portal_Branch_2_6/theme/src/main/org/jboss/portal/theme/impl/render/dynamic/DynaDecorationRenderer.java 2009-02-28 15:58:01 UTC (rev 12909) @@ -1,6 +1,6 @@ /****************************************************************************** * JBoss, a division of Red Hat * - * Copyright 2006, Red Hat Middleware, LLC, and individual * + * Copyright 2009, Red Hat Middleware, LLC, and individual * * contributors as indicated by the @authors tag. See the * * copyright.txt in the distribution for a full listing of * * individual contributors. * @@ -20,6 +20,7 @@ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA * * 02110-1301 USA, or see the FSF site: http://www.fsf.org. * ******************************************************************************/ + package org.jboss.portal.theme.impl.render.dynamic; import org.jboss.portal.theme.render.AbstractObjectRenderer; @@ -68,19 +69,22 @@ markup.print("<div class=\"dnd-handle\">"); markup.print("<div class=\"dyna-decoration\">\n"); - // delegate.render(rendererContext, drc); - //end element in DivDecorationRenderer - /*markup.print("</div>\n"); - markup.print("</div>\n");*/ + // Close dnd-decoration + markup.print("</div>"); + // Close dnd-handle + markup.print("</div>"); + } else { markup.print("<div class=\"dyna-decoration\">\n"); + delegate.render(rendererContext, drc); - //end element in DivDecorationRenderer - //markup.print("</div>\n"); + + // Close dyna-decoration + markup.print("</div>"); } } else