Author: thomas.heute(a)jboss.com Date: 2008-07-23 03:14:59 -0400 (Wed, 23 Jul 2008) New Revision: 11550 Modified: tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/test/wsrp/v1/producer/V1ProducerBaseTest.java tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/wsrp/producer/ServiceDescriptionHandler.java Log: - Found an issue with V1ProducerBaseTest.configureRegistrationSettings which was not configuring registration settings properly. This resulted in incorrect tests and not properly handling the case where registration was required to access the full service description. Modified: tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/test/wsrp/v1/producer/V1ProducerBaseTest.java =================================================================== --- tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/test/wsrp/v1/producer/V1ProducerBaseTest.java 2008-07-22 23:59:40 UTC (rev 11549) +++ tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/test/wsrp/v1/producer/V1ProducerBaseTest.java 2008-07-23 07:14:59 UTC (rev 11550) @@ -168,7 +168,7 @@ { // define expected registration infos producer.getProducerRegistrationRequirements().setRegistrationRequired(requiresRegistration); - producer.getProducerRegistrationRequirements().setRegistrationRequiredForFullDescription(provideUnregisteredFullDescription); + producer.getProducerRegistrationRequirements().setRegistrationRequiredForFullDescription(!provideUnregisteredFullDescription); if (requiresRegistration) { Modified: tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/wsrp/producer/ServiceDescriptionHandler.java =================================================================== --- tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/wsrp/producer/ServiceDescriptionHandler.java 2008-07-22 23:59:40 UTC (rev 11549) +++ tags/JBoss_Portal_2_6_6/wsrp/src/main/org/jboss/portal/wsrp/producer/ServiceDescriptionHandler.java 2008-07-23 07:14:59 UTC (rev 11550) @@ -97,7 +97,7 @@ { log.debug("Unregistered consumer while registration is required. Sending registration information."); - if (requirements.isRegistrationRequiredForFullDescription()) + if (!requirements.isRegistrationRequiredForFullDescription()) { log.debug("Sending offered portlets description despite not being registered, per Producer configuration."); offeredPortlets = getPortletDescriptions(gs.getDesiredLocales(), null);