[JBoss JIRA] (RFPL-3506) File an upstream issue for the Mojarra uiRepeat#setIndex issue
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RFPL-3506?page=com.atlassian.jira.plugin.... ]
Michal Petrov commented on RFPL-3506:
-------------------------------------
Sorry, this has taken me longer than it should. But I think I managed to track the issue down to the JSF side of things.
> File an upstream issue for the Mojarra uiRepeat#setIndex issue
> --------------------------------------------------------------
>
> Key: RFPL-3506
> URL: https://issues.jboss.org/browse/RFPL-3506
> Project: RichFaces Planning
> Issue Type: Task
> Components: third-party
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.5.0.CR1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152].
> The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is:
> {code}
> ----------------------------
> Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
> ===================================================================
> --- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (revision 12814)
> +++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (working copy)
> @@ -787,7 +787,9 @@
> // Just need to check whether there are any ids under this
> // subtree. Make sure row index is cleared out since
> // getSubtreeIdsToVisit() needs our row-less client id.
> - setIndex(context.getFacesContext(), -1);
> + if (requiresRowIteration(context)) {
> + setIndex(context.getFacesContext(), -1);
> + }
> Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
> assert(idsToVisit != null);
> {code}
> and it's meant to address:
> {quote}
> {{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area
> {quote}
> A number of RF components are broken with this bug, they are labelled with the {{uiRepeat:setIndex}} tag:
> https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%2...
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3504) Review and correct RichFaces and CDK docs builds
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RFPL-3504?page=com.atlassian.jira.plugin.... ]
Brian Leathem commented on RFPL-3504:
-------------------------------------
The linked-to doc mostly discusses the naming conventions used by the CDK. I think it's fine to publish it as it is, maybe file a new RFPL to track reviewing it for accuracy in the future.
> Review and correct RichFaces and CDK docs builds
> ------------------------------------------------
>
> Key: RFPL-3504
> URL: https://issues.jboss.org/browse/RFPL-3504
> Project: RichFaces Planning
> Issue Type: Task
> Components: doc
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.5.0.CR1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> RichFaces docs are currently published to:
> http://docs.jboss.org/richfaces/
> The _maven-richfaces-resource-plugin_ site docs should be generated automatically with the RichFaces _dist_ buld.
> The CDK docs should also be published, including the javadoc and the maven plugin site docs. They should also be included in the cdk dist build.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3508) Framework tests: non-Warp push tests are not passing on phantomJS
by Jiří Štefek (JIRA)
Jiří Štefek created RFPL-3508:
---------------------------------
Summary: Framework tests: non-Warp push tests are not passing on phantomJS
Key: RFPL-3508
URL: https://issues.jboss.org/browse/RFPL-3508
Project: RichFaces Planning
Issue Type: Bug
Components: QE
Reporter: Jiří Štefek
Tests:
* ITAutoRegisteredPushServletWithoutWarp
* ITPushFilterWithoutWarp
* ITPushServletMappingWithoutWarp
are not working on PhantomJS browser.
When you mark these test as {{@WarpTest}}, the Warp will complain, because it was not used/initialized, but the test will pass.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3504) Review and correct RichFaces and CDK docs builds
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RFPL-3504?page=com.atlassian.jira.plugin.... ]
Brian Leathem commented on RFPL-3504:
-------------------------------------
The CDK docs in question are generated from the source and so should be current. We can simply strip any styling/customisation of the generated doc pages rather than replace with RF/JBoss equivalents.
> Review and correct RichFaces and CDK docs builds
> ------------------------------------------------
>
> Key: RFPL-3504
> URL: https://issues.jboss.org/browse/RFPL-3504
> Project: RichFaces Planning
> Issue Type: Task
> Components: doc
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.5.0.CR1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> RichFaces docs are currently published to:
> http://docs.jboss.org/richfaces/
> The _maven-richfaces-resource-plugin_ site docs should be generated automatically with the RichFaces _dist_ buld.
> The CDK docs should also be published, including the javadoc and the maven plugin site docs. They should also be included in the cdk dist build.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months