[JBoss JIRA] (RFPL-3504) Review and correct RichFaces and CDK docs builds
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RFPL-3504?page=com.atlassian.jira.plugin.... ]
Michal Petrov commented on RFPL-3504:
-------------------------------------
I've only changed the ${projectName} variable since that was needed for the release. I'll work on updating the POMs.
I am not sure about the CDK docs, they were last updated 4 years ago (hence the Exadel logo) so they could be significantly out of date.
> Review and correct RichFaces and CDK docs builds
> ------------------------------------------------
>
> Key: RFPL-3504
> URL: https://issues.jboss.org/browse/RFPL-3504
> Project: RichFaces Planning
> Issue Type: Task
> Components: doc
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.5.0.CR1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> RichFaces docs are currently published to:
> http://docs.jboss.org/richfaces/
> The _maven-richfaces-resource-plugin_ site docs should be generated automatically with the RichFaces _dist_ buld.
> The CDK docs should also be published, including the javadoc and the maven plugin site docs. They should also be included in the cdk dist build.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3498) Test RichFaces with JBDS 8
by Martin Tomasek (JIRA)
[ https://issues.jboss.org/browse/RFPL-3498?page=com.atlassian.jira.plugin.... ]
Martin Tomasek resolved RFPL-3498.
----------------------------------
Resolution: Done
ad step4:
Project hase been created and deployed successfully.
> Test RichFaces with JBDS 8
> --------------------------
>
> Key: RFPL-3498
> URL: https://issues.jboss.org/browse/RFPL-3498
> Project: RichFaces Planning
> Issue Type: Sub-task
> Components: QE
> Reporter: Pavol Pitonak
> Assignee: Martin Tomasek
> Fix For: 4.5.0.Beta2
>
>
> # create a new Ant project and deploy it to WildFly 8.1 and Tomcat 7
> # create a new Maven project and deploy it to WildFly 8.1 and Tomcat 7
> # try to import existing Maven project
> # create new project from JBoss Central
> add 4.
> According to the RFPL-2204 it should be verified that the project can be generated only from Maven Central, steps to do that:
> In addition to this, a manual verification of the archetype in JBoss tools is required. Steps to test a SANPSHOT of the archetype in JBoss tools are as follows:
> (03:05:35 PM) Snjeza: you can create project example user site pointing to whatever project example descriptor you want
> (03:06:09 PM) bleathem: Snjeza: how do you do that?
> (03:09:12 PM) Snjeza: bleathem: Call Window>Preferences>JBoss Tools>Project Examples and click the Add button. Project example xml file can be in your local file system
> (03:09:53 PM) bleathem: Snjeza: and how do I make a project example xml file? Can I just copy one from somehwere else?
> (03:15:10 PM) Snjeza: bleathem: you can copy the following http://download.jboss.org/jbosstools/examples/project-examples-shared-3.3... and change the version of your richfaces archetype
> (03:33:58 PM) Snjeza: bleathem: You have to check the Show experimental sites checkbox if you want user sites to be shown
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3506) File an upstream issue for the Mojarra uiRepeat#setIndex issue
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RFPL-3506?page=com.atlassian.jira.plugin.... ]
Brian Leathem reassigned RFPL-3506:
-----------------------------------
Assignee: Michal Petrov
Let's go ahead and file this issue ASAP. We can follow up the issue report with a reproducer if the Mojarra team doesn't see anything inherently obvious.
> File an upstream issue for the Mojarra uiRepeat#setIndex issue
> --------------------------------------------------------------
>
> Key: RFPL-3506
> URL: https://issues.jboss.org/browse/RFPL-3506
> Project: RichFaces Planning
> Issue Type: Task
> Components: third-party
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.5.0.CR1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152].
> The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is:
> {code}
> ----------------------------
> Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
> ===================================================================
> --- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (revision 12814)
> +++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (working copy)
> @@ -787,7 +787,9 @@
> // Just need to check whether there are any ids under this
> // subtree. Make sure row index is cleared out since
> // getSubtreeIdsToVisit() needs our row-less client id.
> - setIndex(context.getFacesContext(), -1);
> + if (requiresRowIteration(context)) {
> + setIndex(context.getFacesContext(), -1);
> + }
> Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
> assert(idsToVisit != null);
> {code}
> and it's meant to address:
> {quote}
> {{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area
> {quote}
> A number of RF components are broken with this bug, they are labelled with the {{uiRepeat:setIndex}} tag:
> https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%2...
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3506) File an upstream issue for the Mojarra uiRepeat#setIndex issue
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RFPL-3506?page=com.atlassian.jira.plugin.... ]
Brian Leathem commented on RFPL-3506:
-------------------------------------
We will need a reproducer when filing this issue. Using a stripped down RF component and renderer for one of the affected components should suffice.
> File an upstream issue for the Mojarra uiRepeat#setIndex issue
> --------------------------------------------------------------
>
> Key: RFPL-3506
> URL: https://issues.jboss.org/browse/RFPL-3506
> Project: RichFaces Planning
> Issue Type: Task
> Components: third-party
> Reporter: Brian Leathem
> Fix For: 4.5.0.CR1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152].
> The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is:
> {code}
> ----------------------------
> Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
> ===================================================================
> --- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (revision 12814)
> +++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (working copy)
> @@ -787,7 +787,9 @@
> // Just need to check whether there are any ids under this
> // subtree. Make sure row index is cleared out since
> // getSubtreeIdsToVisit() needs our row-less client id.
> - setIndex(context.getFacesContext(), -1);
> + if (requiresRowIteration(context)) {
> + setIndex(context.getFacesContext(), -1);
> + }
> Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
> assert(idsToVisit != null);
> {code}
> and it's meant to address:
> {quote}
> {{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area
> {quote}
> A number of RF components are broken with this bug, they are labelled with the {{uiRepeat:setIndex}} tag:
> https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%2...
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months
[JBoss JIRA] (RFPL-3506) File an upstream issue for the Mojarra uiRepeat#setIndex issue
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RFPL-3506?page=com.atlassian.jira.plugin.... ]
Brian Leathem updated RFPL-3506:
--------------------------------
Description:
I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152].
The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is:
{code}
----------------------------
Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
===================================================================
--- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (revision 12814)
+++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (working copy)
@@ -787,7 +787,9 @@
// Just need to check whether there are any ids under this
// subtree. Make sure row index is cleared out since
// getSubtreeIdsToVisit() needs our row-less client id.
- setIndex(context.getFacesContext(), -1);
+ if (requiresRowIteration(context)) {
+ setIndex(context.getFacesContext(), -1);
+ }
Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
assert(idsToVisit != null);
{code}
and it's meant to address:
{quote}
{{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area
{quote}
A number of RF components are broken with this bug, they are labelled with the {{uiRepeat:setIndex}} tag:
https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%2...
was:
RF issues with the {{uiRepeat:setIndex}} tag:
https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%2...
> File an upstream issue for the Mojarra uiRepeat#setIndex issue
> --------------------------------------------------------------
>
> Key: RFPL-3506
> URL: https://issues.jboss.org/browse/RFPL-3506
> Project: RichFaces Planning
> Issue Type: Task
> Reporter: Brian Leathem
>
> I reverted the change introduced by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152].
> The relevant change in [JAVASERVERFACES-3152|https://java.net/jira/browse/JAVASERVERFACES-3152] is:
> {code}
> ----------------------------
> Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
> ===================================================================
> --- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (revision 12814)
> +++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java (working copy)
> @@ -787,7 +787,9 @@
> // Just need to check whether there are any ids under this
> // subtree. Make sure row index is cleared out since
> // getSubtreeIdsToVisit() needs our row-less client id.
> - setIndex(context.getFacesContext(), -1);
> + if (requiresRowIteration(context)) {
> + setIndex(context.getFacesContext(), -1);
> + }
> Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
> assert(idsToVisit != null);
> {code}
> and it's meant to address:
> {quote}
> {{<ui:repeat>}}'s value attribute gets evaluated during each and every ajax call, even when {{<ui:repeat>}} is outside the render area
> {quote}
> A number of RF components are broken with this bug, they are labelled with the {{uiRepeat:setIndex}} tag:
> https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%2...
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 7 months