[JBoss JIRA] (TEIIDDES-1857) Create and implement a cross-platform file name validator
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-1857?page=com.atlassian.jira.plu... ]
Rob Stryker commented on TEIIDDES-1857:
---------------------------------------
I've reverted the commit, and should have done better homework before merging it in. I would like to note that if the API is solid, ASTools could probably use this as well. We have a use-case of running jbds on windows, and deploying to a linux machine with linux paths.
I believe a new PR will be needed (since technically the previous has been merged in), so sorry for ruining your PR branch :(
> Create and implement a cross-platform file name validator
> ---------------------------------------------------------
>
> Key: TEIIDDES-1857
> URL: https://issues.jboss.org/browse/TEIIDDES-1857
> Project: Teiid Designer
> Issue Type: Enhancement
> Components: Validation
> Affects Versions: 8.2
> Reporter: Barry LaFond
> Assignee: Paul Richardson
> Fix For: 8.2.x-prod-eds6.0
>
>
> Currently, Teiid Designer allows creating models with pretty much and character in it besides ".".
> Unfortunatelly, a LOT of special characters are not valid on some OS's like Windows, so opening a project containing invalid Windows file names in Eclipse will probably cause issues.
> Need to create a utility class/framework that can perform name validation across OS's.
> Teiid has reserved model names: _TEMP_, SYS, or SYSADMIN
> For Windows chars and reserved words: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.8...
> For more comprehensive list and links: http://en.wikipedia.org/wiki/Filename
> Other potential features:
> * setNoSpaces(boolean)
> * ignoredSystems(WINDOWS, OSX) (i.e. turn off one or more OS types)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (TEIIDDES-1857) Create and implement a cross-platform file name validator
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-1857?page=com.atlassian.jira.plu... ]
Max Rydahl Andersen commented on TEIIDDES-1857:
-----------------------------------------------
I like the idea of a general validator but we should be careful to not make this too complicated for something that is after all a corner case.
i.e. don't add ui component that validates with tons of checkboxes for each os type since the os type is just one part of this; also mixed case files can be a concern depending if the file system allows it or not (which is not dependent on the OS).
Better would in my mind be that users gets *warned* about common issues for other OS's than the one running: i.e. using special characters like # is possible on osx/mac but is okey on linux.
Then just have the UI state something like "Warning: Sh$T #p.vmd is possible on this OS, but is not a portable file name on <OS that has issues> because # is not allowed."
> Create and implement a cross-platform file name validator
> ---------------------------------------------------------
>
> Key: TEIIDDES-1857
> URL: https://issues.jboss.org/browse/TEIIDDES-1857
> Project: Teiid Designer
> Issue Type: Enhancement
> Components: Validation
> Affects Versions: 8.2
> Reporter: Barry LaFond
> Assignee: Paul Richardson
> Fix For: 8.2.x-prod-eds6.0
>
>
> Currently, Teiid Designer allows creating models with pretty much and character in it besides ".".
> Unfortunatelly, a LOT of special characters are not valid on some OS's like Windows, so opening a project containing invalid Windows file names in Eclipse will probably cause issues.
> Need to create a utility class/framework that can perform name validation across OS's.
> Teiid has reserved model names: _TEMP_, SYS, or SYSADMIN
> For Windows chars and reserved words: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.8...
> For more comprehensive list and links: http://en.wikipedia.org/wiki/Filename
> Other potential features:
> * setNoSpaces(boolean)
> * ignoredSystems(WINDOWS, OSX) (i.e. turn off one or more OS types)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (TEIIDDES-1730) Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-1730?page=com.atlassian.jira.plu... ]
Barry LaFond resolved TEIIDDES-1730.
------------------------------------
Resolution: Done
Done
> Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
> -------------------------------------------------------------------------------------
>
> Key: TEIIDDES-1730
> URL: https://issues.jboss.org/browse/TEIIDDES-1730
> Project: Teiid Designer
> Issue Type: Feature Request
> Components: Teiid Integration, Usability
> Affects Versions: 7.8
> Reporter: Van Halbert
> Assignee: Barry LaFond
> Fix For: 8.2.x-prod-eds6.0
>
> Attachments: create-vdb-data-source-dialog.png, data-source-exists-warning.png, vdb-not-deployed-warning-dialog.png
>
>
> From a usability issue, it would good if the default Teiid URL defined in the datasource that is created on the server is for the local connection. IMO, majority of the time when a Teiid datasource is defined in the server if for a local connection to be used by web applications or integration with other components (i.e, ESB) that will access Teiid via JNDI.
> Make sense to create a new CreateTeiidVdbDataSource Modeling action to handle this and make it show up in Model Explorer for VDB selection as well as in the Teiid Server tree for selected VDB.
> Key to this will be to circumvent the standard Create Data Source wizard knowing that this is a TEIID type data source for a specific VDB and that we'll need to remove the Host/Port info from the properties list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (TEIIDDES-1730) Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-1730?page=com.atlassian.jira.plu... ]
Van Halbert commented on TEIIDDES-1730:
---------------------------------------
Seeding it with the VDB name is good, cause it is what they selected to create the datasource for.
> Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
> -------------------------------------------------------------------------------------
>
> Key: TEIIDDES-1730
> URL: https://issues.jboss.org/browse/TEIIDDES-1730
> Project: Teiid Designer
> Issue Type: Feature Request
> Components: Teiid Integration, Usability
> Affects Versions: 7.8
> Reporter: Van Halbert
> Assignee: Barry LaFond
> Fix For: 8.2.x-prod-eds6.0
>
> Attachments: create-vdb-data-source-dialog.png, data-source-exists-warning.png, vdb-not-deployed-warning-dialog.png
>
>
> From a usability issue, it would good if the default Teiid URL defined in the datasource that is created on the server is for the local connection. IMO, majority of the time when a Teiid datasource is defined in the server if for a local connection to be used by web applications or integration with other components (i.e, ESB) that will access Teiid via JNDI.
> Make sense to create a new CreateTeiidVdbDataSource Modeling action to handle this and make it show up in Model Explorer for VDB selection as well as in the Teiid Server tree for selected VDB.
> Key to this will be to circumvent the standard Create Data Source wizard knowing that this is a TEIID type data source for a specific VDB and that we'll need to remove the Host/Port info from the properties list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (TEIIDDES-1730) Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-1730?page=com.atlassian.jira.plu... ]
Barry LaFond commented on TEIIDDES-1730:
----------------------------------------
I'm seeding the DS Name with the VDB name for starters. I can leave if blank if you want?
> Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
> -------------------------------------------------------------------------------------
>
> Key: TEIIDDES-1730
> URL: https://issues.jboss.org/browse/TEIIDDES-1730
> Project: Teiid Designer
> Issue Type: Feature Request
> Components: Teiid Integration, Usability
> Affects Versions: 7.8
> Reporter: Van Halbert
> Assignee: Barry LaFond
> Fix For: 8.2.x-prod-eds6.0
>
> Attachments: create-vdb-data-source-dialog.png, data-source-exists-warning.png, vdb-not-deployed-warning-dialog.png
>
>
> From a usability issue, it would good if the default Teiid URL defined in the datasource that is created on the server is for the local connection. IMO, majority of the time when a Teiid datasource is defined in the server if for a local connection to be used by web applications or integration with other components (i.e, ESB) that will access Teiid via JNDI.
> Make sense to create a new CreateTeiidVdbDataSource Modeling action to handle this and make it show up in Model Explorer for VDB selection as well as in the Teiid Server tree for selected VDB.
> Key to this will be to circumvent the standard Create Data Source wizard knowing that this is a TEIID type data source for a specific VDB and that we'll need to remove the Host/Port info from the properties list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (TEIIDDES-1730) Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-1730?page=com.atlassian.jira.plu... ]
Van Halbert commented on TEIIDDES-1730:
---------------------------------------
I'm not so sure the warning message is needed after you specifically selected to create a data source and were prompted for the vdb name.
But the existing check and overwrite options seem good.
> Add Create Teiid VDB Data Source action to VDB selection in Teiid server and explorer
> -------------------------------------------------------------------------------------
>
> Key: TEIIDDES-1730
> URL: https://issues.jboss.org/browse/TEIIDDES-1730
> Project: Teiid Designer
> Issue Type: Feature Request
> Components: Teiid Integration, Usability
> Affects Versions: 7.8
> Reporter: Van Halbert
> Assignee: Barry LaFond
> Fix For: 8.2.x-prod-eds6.0
>
> Attachments: create-vdb-data-source-dialog.png, data-source-exists-warning.png, vdb-not-deployed-warning-dialog.png
>
>
> From a usability issue, it would good if the default Teiid URL defined in the datasource that is created on the server is for the local connection. IMO, majority of the time when a Teiid datasource is defined in the server if for a local connection to be used by web applications or integration with other components (i.e, ESB) that will access Teiid via JNDI.
> Make sense to create a new CreateTeiidVdbDataSource Modeling action to handle this and make it show up in Model Explorer for VDB selection as well as in the Teiid Server tree for selected VDB.
> Key to this will be to circumvent the standard Create Data Source wizard knowing that this is a TEIID type data source for a specific VDB and that we'll need to remove the Host/Port info from the properties list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months