[teiid-designer-issues] [JBoss JIRA] (TEIIDDES-1492) Validation problems created when importing a SOAP-based wsdl

[ https://issues.jboss.org/browse/TEIIDDES-1492?page=com.atlassian.jira.plu... ] Paul Richardson updated TEIIDDES-1492: -------------------------------------- Description: Use the SOAP-based model importer to create source and view models based on a wsdl, already configured in a jboss 7 server. Both the source and view models are created successfully yet 6 errors are generated in the Problems view. See the attached screenshot. h4. Investigation # The 6 problems are generated from SqlTransformationMappingRootValidationRule (lines 589-596) # The test (at line 589) checks the command's type, ie. {code} if (cmdType == Command.TYPE_UPDATE_PROCEDURE) {code} # The virtual procedure command instance is of the class CreateProcedureCommand * TransformationSqlHelper is responsible for creating the CreateProcedureCommand using the createVirtualProcCommmandForCommand() method * The CreateProcedureCommand command used to be CreateUpdateProcedureCommand but this was renamed in Teiid 8.0 * The new command class had the API isUpdateProcedure() and setUpdateProcedure() methods removed * Commit [#1e044a90|https://github.com/Teiid-Designer/teiid-designer/commit/1e044a90] fixed the compilation errors resulting from this API change by ** removing the setUpdateProcedure(false) call in TransformSqlHelper ** removing the isUpdateProcedure() test and the end of line 589 in SqlTransformationMappingRootValidationRule Thus, originally the commands were instantiated and changed to not be 'update procedures'. This is enough to avoid the test and line 589. With the reduction of API and the compilation fixes, the commands incorrectly generate the validation errors. was: Use the SOAP-based model importer to create source and view models based on a wsdl, already configured in a jboss 7 server. Both the source and view models are created successfully yet 6 errors are generated in the Problems view. See the attached screenshot. h4. Investigation # The 6 problems are generated from SqlTransformationMappingRootValidationRule (lines 589-596) # The test (at line 589) checks the command's type, ie. {code} if (cmdType == Command.TYPE_UPDATE_PROCEDURE) {code} # The virtual procedure command instance is of the class CreateProcedureCommand * TransformationSqlHelper is responsible for creating the CreateProcedureCommand using the createVirtualProcCommmandForCommand() method * The CreateProcedureCommand command used to be CreateUpdateProcedureCommand but this was renamed in Teiid 8.0 * The new command class had the API isUpdateProcedure() and setUpdateProcedure() methods removed * Commit [#1e044a90|https://github.com/Teiid-Designer/teiid-designer/commit/1e044a90] fixed the compilation errors resulting from this API change by ** removing the setUpdateProcedure(false) call in TransformSqlHelper ** removing the isUpdateProcedure() test and the end of line 589 in SqlTransformationMappingRootValidationRule Therefore, originally the commands were modified to not be 'update procedures'. With the reduction of API and the compilation fixes, the commands are incorrectly labelled as validation problems. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira