[teiid-designer-issues] [JBoss JIRA] (TEIIDDES-2477) Nullpointer in WSConnectionInfoProvider.java when user is null

Nullpointer in WSConnectionInfoProvider.java when user is null -------------------------------------------------------------- Key: TEIIDDES-2477 URL: https://issues.jboss.org/browse/TEIIDDES-2477 Project: Teiid Designer Issue Type: Bug Components: Data Preview Affects Versions: 8.6, 9.0 Environment: Windows 7, JBoss Developer Studio 8.1.0, Teiid Designer 9.0.1.Final Reporter: Daan Creemers Assignee: Ted Jones Fix For: 9.1, 8.6.2 Beta1, 9.0.2 Beta1, 9.0.2, 8.6.2 In the file https://github.com/Teiid-Designer/teiid-designer/blob/9.0.x/plugins/org.t... @line 101: if (null != user &! user.equals("")) { //$NON-NLS-1$ connectionProps.setProperty(ICredentialsCommon.USERNAME_PROP_ID, user); } It is not correctly captured that user can be null. No short-circuit operator is used and therefore, the right-hand side of the expression is evaluated which gives a NullPointer if user is null. Line 101 contains ampersand exclamation mark without a space in between such that short-circuit is not working. ( if (null != user &! user.equals("")) { ) This should be ( if (null != user && !user.equals("")) { ) After importing a REST Web Service to create a Source and View model, previewing the data generates the following NullPointer. java.lang.NullPointerException at org.teiid.designer.datatools.profiles.ws.WSConnectionInfoProvider.getTeiidRelatedProperties(WSConnectionInfoProvider.java:101) at org.teiid.designer.runtime.TeiidDataSourceFactory.createDataSource(TeiidDataSourceFactory.java:127) at org.teiid.designer.runtime.preview.PreviewManager.ensureConnectionInfoIsValid(PreviewManager.java:527) at org.teiid.designer.runtime.preview.PreviewManager.previewSetup(PreviewManager.java:1365) at org.teiid.designer.runtime.ui.preview.PreviewDataWorker$1.run(PreviewDataWorker.java:233) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)