[aerogear-dev] UnifiedPush Server domain model

[Erik Jan de Wit]

Hi,

Right now the domain model of the UnifiedPush Server has the variants split into separate collections. 

https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50

This could be improved to only use one collection, we’ll get more extendibility (adding another variant type for instance) and remove code like this:

https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96

In places where you only want the iOS variants for instance you could either query them, or have a getter that collects them by type.

What do you think?

	Cheers,
		Erik Jan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20140611/6930eea8/attachment-0001.html